Repository navigation
refactor: finish the conductor mode rename - #37095
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks. The rename reaches every in-tree writer and reader, and the author lists and accepts the breaks for names that only existed behind the preview. Notes
[DESIGN-REVIEWED] 7f7663c Description read[DESCRIPTION-READ] 2e0938d8f5398b8769fe099f64e104cf4ebc391bef96772f6ed1ba79450460d3 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS This is a complete rename. A maintainer ruling linked in the description (#37086) covers each reversed compatibility pin, and the source tree still runs nothing from the old spellings. What this change shipsInventory (8 items) — 7 justifiedIntent: drop the last Ultra names and their compatibility code so conductor mode has one name everywhere. This is a FIX (cleanup of #36924's leftovers).
[FIRST-PRINCIPLES-REVIEWED] 7f7663c Description read[DESCRIPTION-READ] c657389ca46199b9e994e0dc487de5677efaeafefe0e24998f0f0a1fce00da70 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks: the one dashboard label this PR changes is in shot-02, and the blind reader correctly saw it as the same setting under a new name. Notes
[UX-REVIEWED] 7f7663c Description read[DESCRIPTION-READ] 48280c86f631ae7bde066f4da110fdc29fece9e363c283c3937f01eecf9fd563 That sha256 names everything this verdict read: the PR description, plus the 5 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
|
/ai-review override gpt 989564d not-applicable: agent: owner-authorized (maintainer ruling): the blocking finding is the by-design recorded-decisions gate on the new superseding decision entry; the diff is reviewed locally by GPT and Opus, no open findings; evidence in the PR body |
|
/ai-review override fable 989564d not-applicable: agent: owner-authorized (maintainer ruling): the blocking finding is the by-design recorded-decisions gate on the new superseding decision entry; the diff is reviewed locally by GPT and Opus, no open findings; evidence in the PR body |
Human judgment recorded@bolichen97 recorded a not-applicable release (class
This decision applies only to this commit. A new push requires a new judgment. |
Human judgment recorded@bolichen97 recorded a not-applicable release (class
This decision applies only to this commit. A new push requires a new judgment. |
|
CI red on |
Code change approver recommendation: ApproveWhy: the decider estimates a 12% chance that this change introduces a defect, within the 12% limit for approving on its own, and every check passes. This PR finishes the rename of Ultra Mode to conductor mode. The rename is complete: An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit |
989564d to
3f2d718
Compare
|
/ai-review override fable 3f2d718 not-applicable: agent: owner-authorized (maintainer ruling): the blocking finding is the by-design recorded-decisions gate on the new superseding decision entry; the diff is reviewed locally by GPT and Opus, no open findings; evidence in the PR body |
Human judgment recorded@bolichen97 recorded a not-applicable release (class
This decision applies only to this commit. A new push requires a new judgment. |
Ultra Mode only ever lived behind the default-off feature preview, so
no old spelling needs to keep working. Rename the four names the first
rename kept: the remote-dispatch refusal code is conductor_mode_only,
the config key is telemetry.traces_conductor_mode, and the trace
root_kind value and round trace kind are conductor_mode, with spans
named "conductor_mode round N" and "conductor_mode outcome ...".
Drop the compatibility code: the gateway notice no longer matches the
stored "Ultra Mode" agent-switch wording, and the comments that said a
value keeps its old spelling are gone. Title Case labels write the name
in lower case too ("Start New Chats in conductor mode"). A new decision
entry records both, superseding part of the entry that named the
feature.
3f2d718 to
7f7663c
Compare
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
On head 7f7663c this review checked each renamed name (the conductor_mode_only refusal code, the telemetry.traces_conductor_mode key, the root_kind and round kind values, the span names and the notice regex) against its writer and every in-tree reader. It also grepped the merge of this PR into main for leftover Ultra names and found none outside the Not-a-goal areas. It found no correctness or security defect, and no blocking rule broken in code. PR Readiness is green on this head.
Done well: each rename reaches its writer and all of its readers in one commit, the generated config baseline and settings registry are regenerated rather than edited by hand, and the decision change is a new superseding entry that leaves the earlier one as written.
Optional:
- The Backwards compatibility text says the breaking values are main-only. In fact
root_kind = "ultra",ultra_mode_onlyand the stored "Ultra Mode" notice shipped in 0.13.0 behind the default-off preview. Only the config key and the round and span names are main-only. TheBreaking:line already names all four changes. - No test reads
traces_conductor_modefrom a config file, and the refusal test compares against the constant, not the literal. A config-drivenconductor_mode_shape()test and a literal"conductor_mode_only"assert would pin both renames.
Ultra Mode only ever lived behind the default-off feature preview, so
no old spelling needs to keep working. Rename the four names the first
rename kept: the remote-dispatch refusal code is conductor_mode_only,
the config key is telemetry.traces_conductor_mode, and the trace
root_kind value and round trace kind are conductor_mode, with spans
named "conductor_mode round N" and "conductor_mode outcome ...".
Drop the compatibility code: the gateway notice no longer matches the
stored "Ultra Mode" agent-switch wording, and the comments that said a
value keeps its old spelling are gone. Title Case labels write the name
in lower case too ("Start New Chats in conductor mode"). A new decision
entry records both, superseding part of the entry that named the
feature.
Hand-resolved backport; original author: Bolin Chen.
(cherry picked from commit 36a018f)
Ultra Mode only ever lived behind the default-off feature preview, so
no old spelling needs to keep working. Rename the four names the first
rename kept: the remote-dispatch refusal code is conductor_mode_only,
the config key is telemetry.traces_conductor_mode, and the trace
root_kind value and round trace kind are conductor_mode, with spans
named "conductor_mode round N" and "conductor_mode outcome ...".
Drop the compatibility code: the gateway notice no longer matches the
stored "Ultra Mode" agent-switch wording, and the comments that said a
value keeps its old spelling are gone. Title Case labels write the name
in lower case too ("Start New Chats in conductor mode"). A new decision
entry records both, superseding part of the entry that named the
feature.
Hand-resolved backport; original author: Bolin Chen.
(cherry picked from commit 36a018f)
Problem / Motivation
Goal: No Ultra name is left in the product: the names the first rename kept for compatibility become conductor-mode names, and the compatibility code goes.
#36924 renamed Ultra Mode to conductor mode but kept a few old spellings so a saved value would keep working: the remote-dispatch refusal code
ultra_mode_only, the config keytelemetry.traces_ultra_mode, the trace valueultra, and a match for the stored "Ultra Mode" notice wording. Two Title Case labels also kept a capital M ("Start New Chats in Conductor Mode", "Traces: Conductor Mode Shape"). A maintainer ruling says none of that compatibility is needed, because Ultra Mode only ever lived behind the default-off feature preview.Why it matters
Each kept spelling is a second name for one feature that a reader, a log query or a test has to know about, and the compatibility code exists only for installs that never had the feature outside a preview.
Not a goal
ultra, effort values, Ultracode andjev-ultrafast: other features.CHANGELOG.md.What changed (motivation → approach → change)
The last old spellings are gone, and the name reads the same way in every label.
ultra_mode_onlyconductor_mode_onlytelemetry.traces_ultra_modetelemetry.traces_conductor_modekirocrew.crew.root_kindvalueultraconductor_mode(the other root kind staysmate)ultra, spansultra round N/ultra outcome ...conductor_mode,conductor_mode round N/conductor_mode outcome ...No new value collides with an existing one:
conductor_modeis not a trace kind, run kind or root kind anywhere else (git grep).The rename reaches the writers and readers of each name in one commit:
src/kiro_crew/dashboard/handlers/remote_dispatch_routes.pyand the goal-conductor skill insrc/kiro_crew/builtin_skills;src/kiro_crew/config/sections_telemetry.py,config/loader_builders.py,src/kiro_crew/tracing/provider.py;src/kiro_crew/tracing/crew.py,tracing/work.py,src/kiro_crew/dashboard/trace_binding.py;website/src/pages/chat/gatewayNotice.ts. It also covers the label inwebsite/src/i18nand its references inwebsite/src/components,website/src/uiLocationsandwebsite/src/pages/chat/page/crewModeSwitch.ts; the docs indocs/system-specs,docs/guides,docs/feature-mapandsrc/kiro_crew/docs; and the regeneratedconfig-baseline.json, settings registry and UI index.A new decision entry,
docs/decisions/2026-11-13-conductor-mode-keeps-no-ultra-names.md, records the ruling and supersedes, in part, the entry #36924 added; that entry stays as written.After this change
git grep -i ultrafinds only the unrelated items above, vendored code, old decision entries and their README rows, old RFCs, the task-spec archive andCHANGELOG.md.git grep 'Conductor Mode'finds nothing.Backwards compatibility
Breaking: the refusal code, the config key and the trace values change with no fallback, and a transcript that stored the old "Ultra Mode" agent-switch notice shows it as a plain notice line. Ultra Mode only shipped behind the default-off preview, and the config key and trace names reached
mainon 2026-11-13. Writer sweep on origin/main: the refusal code is written byremote_dispatch_routes.py; the config key bysections_telemetry.pyandloader_builders.py; the trace values bytracing/crew.pyandtracing/work.py. Every reader is in this commit.Reader: src/kiro_crew/builtin_skills/goal-conductor/SKILL.md:conductor_mode_only -- chat -- names the new code; test_a_plain_owner_chat_is_refused_conductor_mode_only
Reader: src/kiro_crew/tracing/provider.py:conductor_mode_shape -- chat -- reads
telemetry.traces_conductor_mode; test/tracing/test_tracing_work.pyReader: test/tracing/test_tracing_runs.py:root_kind -- chat -- expects
conductor_modeReader: website/src/pages/chat/gatewayNotice.ts:agent_switch_blocked_crew_mode -- chat -- matches the "conductor mode" wording the gateway writes; gatewayNotice.test.tsx
Tests
The tracing, remote-dispatch and gateway-notice tests expect the new names; the settings tests expect the lower-case label.
Proof: not provable -- other: refactor (rename) PR with no behavior fix; tests pin names only
Local runs on this head: black (26.10.1), isort, flake8, mypy (4635 files), comment-history, brand name, file line cap, docs-lint, decision-ledger history, feature map,
npm run i18n:check(diff-scoped), UI index check,tsc, semgrep (0 findings), the flake-pattern ratchet,test/tracingplus the remote-dispatch, config, goal-conductor and spec-golden tests (1733 passed), and 88 related frontend test files. One backend test,test/tracing/test_tracing_otlp.py::test_a_header_echoed_back_by_a_failure_reaches_no_log_record[library_error], fails the same way on a cleanorigin/maincheckout.Manual verification
I built the SPA before and after (gateway-free, dark, English) and checked the Settings labels: "Start New Chats in conductor mode" and the "Conductor mode" Feature Previews card fit on one line at 1400 px, and the card fits at 390 px.
Screenshots / video
Related Issues
Closes #37086
Part of #36869
Follows #36924.
Waiting for a maintainer: the new decision entry supersedes part of a recorded decision, so
recorded-decisions-are-not-regressionsblocks this PR by design (docs/decisions/README.md rule 3) until a maintainer restates the ruling on it; the merge approval of a maintainer.Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)