Repository navigation
docs(rfc): propose an impact level for ErrorNotice so its look matches the failure (#37118) - #37124
Conversation
a2a355b to
b69a18e
Compare
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: this is a draft RFC that changes no code, and the shared-contract change it proposes is meant to wait for a maintainer to accept it. Notes
[DESIGN-REVIEWED] 402d23d Description read[DESCRIPTION-READ] f83a02f33db753a2aa7611144ed5a2fc6a666975e83f6ff41c7be81006860778 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
Code change approver recommendation: ApproveWhy: the decider estimates a 5% chance that this change introduces a defect, within the 12% limit for approving on its own, and every check passes. Docs-only draft RFC proposing an An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit |
b69a18e to
402d23d
Compare
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
This review checked head 402d23d. The diff is docs only: one draft RFC, 14 PNGs and one row in the RFC index. No code, test or workflow file changes. All 14 image links resolve to files in the commit. The RFC's citations hold on current main: the block root classes and the role logic in ErrorNotice.tsx, the dismissLabel sentence, the errors-use-error-notice rule and its role="status" bullet in website/AUTOSDE.yaml, and the --danger-subtle and --warn-subtle tokens. The branch merges cleanly with main, and no other open PR does the same work.
Done well: the safe default stays explicit. A call site with no impact stays blocking with role="alert", and a site that is unclear stays blocking. The RFC also names the code PR's tests in its exit criteria.
The design is signed off under the standing maintainer sign-off for changes by team members.
Optional:
- The new
actionsslot overlaps the existing block-onlyfooterslot, which already holds retry buttons (for example lazyRetry.tsx and ConnectPanel.tsx). The RFC could say which one hosts buttons in layout 2. - Backward compatibility calls the new fill "lighter". On main it is 12% vs 10% in dark and the same in light. The section also leaves out the blocking icon change from AlertTriangle to AlertCircle.
- The AA contrast table covers only the default light and dark themes. Several shipped dark palettes may stay below 4.5:1, so the code PR could measure every palette or state the scope.
Problem / Motivation
Goal: Propose, as an RFC for a maintainer to accept, that each
ErrorNoticein the dashboard looks as serious as its failure is, so a missing detail no longer gets the same red alarm as a failed page.ErrorNoticedraws every failure as a red box with a red body androle="alert". Inside an amber warning it becomes a red box in a yellow box. On open PR #36324, a failedkiro-cli whoamishows a loud red box inside the sign-in card's yellow warning, while the text says Kiro CLI is still signed in.Why it matters
The look tells users that something important broke when only a name or a forecast is missing. The
errors-use-error-noticereview rule and the component's doc comment forbid a calmer look, so this is a product-shape change to a shared contract and needs a recorded decision before the code PR moves about 150 call sites.Not a goal
draft; a maintainer records acceptance.What changed (motivation → approach → change)
One new RFC,
docs/request-for-change/rfc-error-notice-impact.md, its 14 screenshots underdocs/request-for-change/assets/error-notice-impact/, and its row indocs/request-for-change/README.md.impactblocking(default, today's meaning,role="alert"),partial(amber,role="status"),minor(grey line,role="status")nestederrors-use-error-noticeallows a calmer look throughimpactonly; the doc comment changes to matchpartialorminorand 22 tonested, each checked by hand with four questions; unclear ones stayblockingThe repository owner chose the layout, the blocking body tone and the button styling from earlier design rounds. The RFC lists the rejected options.
Backwards compatibility
Compatible: docs only; no code reads the new document.
Removes nothing: the diff adds one document, its screenshots and one index row.
Tests
Proof: not provable -- docs or config only
./scripts/docs-lint.shpasses locally ("All documentation checks passed").Manual verification
N/A — docs only. Every symbol the RFC cites was read at
8a1b4d3855. The contrast numbers were measured in Chromium from computed styles on the capture page that drew the screenshots.Screenshots / video
Why no screenshot: this PR changes only docs; the design's component renders (mocked data) are committed with the RFC under
docs/request-for-change/assets/error-notice-impact/and embedded in the document.Related Issues
Closes #37118
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license.