Skip to content

docs(rfc): propose an impact level for ErrorNotice so its look matches the failure (#37118) - #37124

Merged
KiroCrewCaptain merged 1 commit into
mainfrom
crew/slack/error-notice-redesign
Nov 14, 2026
Merged

KiroCrewCaptain merged 1 commit into
mainfrom
crew/slack/error-notice-redesign

Conversation

@buluoray

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Propose, as an RFC for a maintainer to accept, that each ErrorNotice in the dashboard looks as serious as its failure is, so a missing detail no longer gets the same red alarm as a failed page.

ErrorNotice draws every failure as a red box with a red body and role="alert". Inside an amber warning it becomes a red box in a yellow box. On open PR #36324, a failed kiro-cli whoami shows a loud red box inside the sign-in card's yellow warning, while the text says Kiro CLI is still signed in.

Why it matters

The look tells users that something important broke when only a name or a forecast is missing. The errors-use-error-notice review rule and the component's doc comment forbid a calmer look, so this is a product-shape change to a shared contract and needs a recorded decision before the code PR moves about 150 call sites.

Not a goal

What changed (motivation → approach → change)

One new RFC, docs/request-for-change/rfc-error-notice-impact.md, its 14 screenshots under docs/request-for-change/assets/error-notice-impact/, and its row in docs/request-for-change/README.md.

Part Proposal
impact blocking (default, today's meaning, role="alert"), partial (amber, role="status"), minor (grey line, role="status")
nested a notice inside a warning box draws no second box, just a line with a thin rule
Layout title line, body under it, one action row; host buttons there look like real buttons
Contrast every tone at WCAG AA in light and dark, with the measured numbers in the RFC
Rule errors-use-error-notice allows a calmer look through impact only; the doc comment changes to match
Migration about 130 sites to partial or minor and 22 to nested, each checked by hand with four questions; unclear ones stay blocking

The repository owner chose the layout, the blocking body tone and the button styling from earlier design rounds. The RFC lists the rejected options.

Backwards compatibility

Compatible: docs only; no code reads the new document.

Removes nothing: the diff adds one document, its screenshots and one index row.

Tests

Proof: not provable -- docs or config only

./scripts/docs-lint.sh passes locally ("All documentation checks passed").

Manual verification

N/A — docs only. Every symbol the RFC cites was read at 8a1b4d3855. The contrast numbers were measured in Chromium from computed styles on the capture page that drew the screenshots.

Screenshots / video

Why no screenshot: this PR changes only docs; the design's component renders (mocked data) are committed with the RFC under docs/request-for-change/assets/error-notice-impact/ and embedded in the document.

Related Issues

Closes #37118

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality (N/A: docs only)
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license.

@buluoray
buluoray requested review from a team and KiroCrewCaptain as code owners November 14, 2026 06:48
@buluoray
buluoray requested a review from CrysisDeu November 14, 2026 06:48
@buluoray
buluoray force-pushed the crew/slack/error-notice-redesign branch from a2a355b to b69a18e Compare November 14, 2026 06:48
@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 402d23dd09b5277cf87f6a87c7b5e2645827ddfc and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 402d23d

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 402d23dd09b5277cf87f6a87c7b5e2645827ddfc false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 14, 2026
@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision 402d23dd09b5277cf87f6a87c7b5e2645827ddfc ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 402d23dd09b5277cf87f6a87c7b5e2645827ddfc touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 402d23dd09b5277cf87f6a87c7b5e2645827ddfc — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: this is a draft RFC that changes no code, and the shared-contract change it proposes is meant to wait for a maintainer to accept it.

Notes

  • The RFC says messagePlacement/actionPlacement will "stop doing anything in the block variant". That quietly drops 61/67 call-site props. The code PR should delete them from the type or reject them on block, and must not ignore them silently.

[DESIGN-REVIEWED] 402d23d

Description read

[DESCRIPTION-READ] f83a02f33db753a2aa7611144ed5a2fc6a666975e83f6ff41c7be81006860778

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 402d23dd09b5277cf87f6a87c7b5e2645827ddfc — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 402d23d

Verdict parsed from the review's SHA-scoped output markers for commit 402d23dd09b5277cf87f6a87c7b5e2645827ddfc.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 402d23dd09b5277cf87f6a87c7b5e2645827ddfc false-positive: <reason, 20 to 500 characters>

@KiroCrewCaptain

Copy link
Copy Markdown
Collaborator

Code change approver recommendation: Approve

Why: the decider estimates a 5% chance that this change introduces a defect, within the 12% limit for approving on its own, and every check passes.

Docs-only draft RFC proposing an impact level (blocking/partial/minor) and a nested form for ErrorNotice, plus screenshots and an index row. Its claims about main check out: the block root at ErrorNotice.tsx:421 uses bg-danger/10 and text-danger-text, role="alert" is set at lines 353 and 420, the dismissLabel comment at lines 168-171 bans a toned-down register, and errors-use-error-notice sits at AUTOSDE.yaml:675 and is blocking. The default stays blocking with role="alert", so forgetting the prop is safe. The PR moves no trust boundary and changes no code, state or limits. The one failed CI check (CodeQL JS) hit a GitHub API rate limit; the pending jobs don't touch docs. It lands as draft, and a maintainer still has to accept it.

An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit b69a18e772 · 304 changed lines. If this recommendation is wrong, reply here: replies are how the approver is evaluated.

@github-actions github-actions Bot added the merge conflict Branch has merge conflicts with its base — author must resolve before merge label Nov 14, 2026
@buluoray
buluoray force-pushed the crew/slack/error-notice-redesign branch from b69a18e to 402d23d Compare November 14, 2026 08:16
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: checking Automated validation is still running labels Nov 14, 2026
@KiroCrewCaptain
KiroCrewCaptain enabled auto-merge (squash) November 14, 2026 09:35

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This review checked head 402d23d. The diff is docs only: one draft RFC, 14 PNGs and one row in the RFC index. No code, test or workflow file changes. All 14 image links resolve to files in the commit. The RFC's citations hold on current main: the block root classes and the role logic in ErrorNotice.tsx, the dismissLabel sentence, the errors-use-error-notice rule and its role="status" bullet in website/AUTOSDE.yaml, and the --danger-subtle and --warn-subtle tokens. The branch merges cleanly with main, and no other open PR does the same work.
Done well: the safe default stays explicit. A call site with no impact stays blocking with role="alert", and a site that is unclear stays blocking. The RFC also names the code PR's tests in its exit criteria.
The design is signed off under the standing maintainer sign-off for changes by team members.
Optional:

  • The new actions slot overlaps the existing block-only footer slot, which already holds retry buttons (for example lazyRetry.tsx and ConnectPanel.tsx). The RFC could say which one hosts buttons in layout 2.
  • Backward compatibility calls the new fill "lighter". On main it is 12% vs 10% in dark and the same in light. The section also leaves out the blocking icon change from AlertTriangle to AlertCircle.
  • The AA contrast table covers only the default light and dark themes. Several shipped dark palettes may stay below 4.5:1, so the code PR could measure every palette or state the scope.

@KiroCrewCaptain
KiroCrewCaptain merged commit ca3c4ab into main Nov 14, 2026
97 of 98 checks passed
@KiroCrewCaptain
KiroCrewCaptain deleted the crew/slack/error-notice-redesign branch November 14, 2026 09:36
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ErrorNotice: make the look match how serious the failure is (impact levels, nested form)

2 participants