Repository navigation
feat(website): ErrorNotice impact levels, nested form and a real-button action row (#37262) - #37263
Conversation
96cb63d to
e7b48dc
Compare
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the new props are optional and default to today's blocking role, rendered evidence is attached, and the block variant still accepts the placement props it now ignores. Notes
[DESIGN-REVIEWED] 3f6dd15 Description read[DESCRIPTION-READ] 2924d9840bc33ea99d23c106029c01c0bbe9ee8002ab5a7e499aa533500eb0e1 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. The accepted base RFC covers every default this changes (layout 2, the lighter fill, the role for each level). Item 9 is the one note. Notes
What this change shipsInventory (9 items) — 7 justifiedIntent: let a missing detail look calmer than a failed page, so users stop reading every gap as a breakage. ADDITION.
[FIRST-PRINCIPLES-REVIEWED] 3f6dd15 Description read[DESCRIPTION-READ] 371de4932ea8aed0268c4ef224bf2e059b8d81ec955f111f257d3f40f2fa7ad7 That sha256 names the PR description this verdict read. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks. Every changed level, the nested form and the action row are in the screenshots, and the blind reader read the Refresh and Retry buttons correctly. Notes
[UX-REVIEWED] 3f6dd15 Description read[DESCRIPTION-READ] d6467210dd7423289cc9ec00cdeaadce2f384815687f721f459ef78c5ca94e0f That sha256 names everything this verdict read: the PR description, plus the 19 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
|
span=d901abc4640f
|
Opus 5.5 Review — ✅ no blocking findingsReviewed Review detailsNo findings. Notes:
[OPUS-REVIEWED] 3f6dd15 Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
Code change approver recommendation: A person should decideWhy: the decider thinks the change is probably fine but estimates a 25% chance that this change introduces a defect, above the 12% limit for approving on its own. This PR implements Phase 1a of the error-notice impact RFC, following the RFC's design and its dated amendment. impact/nested/actions are optional, and the default stays blocking with role="alert". All tokens and colour classes exist and have Tailwind bridges, and the contrast test reads the real mixes from the stylesheet. The six example sites are reasonable (KiroPrerequisiteGate really is inside a warn box). Tests that depend on the old DOM shape (.flex-1, action-row lookups, roles) were updated, and new tests cover levels, nested, actions and contrast. The First Principles block on the RFC being "draft" is a governance call: the RFC explicitly accepts the new layout for every block notice, and the PR records the acceptance. There is no data, security or trust impact. Remaining risk: frontend CI was still pending at review time, and some cosmetic layout gaps (empty action row, labelled-dismiss evidence) are not blocking. An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit |
e7b48dc to
3f6dd15
Compare
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
The review checked head 3f6dd15: every new colour class has a matching theme token, the six call sites match the accepted RFC's Phase 1a list, a notice with no impact still renders role="alert" in red (pinned by errorToAgent.test and ErrorNotice.impact.test), and the new tests use no timers, sleeps or random values. PR Readiness is green on this head.
Well done: errorNoticeImpactContrast.test.ts reads each color-mix() straight from the stylesheet and measures it in every built-in palette, so a later token change gets measured instead of trusted.
Security: the flagged path, KiroAccountModal.signOutLink.test.tsx, changes one expected role from alert to status to match the new partial impact. It touches no sign-in or sign-out logic. The diff adds no HTML strings and no innerHTML.
The design is signed off under the standing maintainer sign-off for changes by team members.
Optional:
- Three capture scenes (balance with Refresh in the row, SecurityPanelConfigPending, KiroSignInSources) are captioned as shipped call sites, but no production ErrorNotice passes
actionson this head, and those last two files are not in the diff. Relabel them as future call sites. - ErrorNotice.tsx:477: when
askAgentis set and the gateway is offline, the hand-off renders nothing but the block notice still draws an empty action row, and the inline notice an empty span. Gate both on the connected state and add a test. - The Backwards compatibility section could say that every block notice now takes layout 2, the new fill and body ink, and a grey dismiss button.
Problem / Motivation
Goal: Give
ErrorNoticethe accepted impact levels, so a missing detail no longer looks like a failed page, and show the new look on a few example call sites.Every failure in the dashboard is a red box with a red body and
role="alert". Inside an amber warning it becomes a red box in a yellow box. The design is accepted in rfc-error-notice-impact.md (#37124).Why it matters
A user reads the loud red box as "something important broke" even when only a name or a forecast is missing. Call sites cannot pick a calmer look until the component and the review rule offer one.
Not a goal
impactkeeps today's meaning.What changed (motivation → approach → change)
impactblocking(default: red box,role="alert"),partial(amber,role="status"),minor(grey line,role="status")nestedactionsdesign-tokens.css, bridged intailwind-theme.css, measured in every built-in paletteerrors-use-error-noticeallows a calmer look only throughimpact; thedismissLabeldoc comment matchesKiroAccountModalforecast (minor), sign-in status and balance (partial);pages/chat/crew-window/CrewChatWindow.tsxeffort and mode (partial, inline);KiroPrerequisiteGate"Use Kiro CLI instead" error (blocking, nested)accepted, #37269)Measuring all palettes changed some mixes from the RFC. Several dark packs cannot reach 4.5:1 on their own tints with a mix toward
--text, so the nested, minor-link, border and ring tokens mix toward--text-strongor less hue. The RFC amendment lists each one and the numbers.Backwards compatibility
Compatible:
impact,nestedandactionsare optional, and a notice without them keepsrole="alert"and the blocking meaning.Reader: website/src/components/ErrorNotice.tsx:messagePlacement -- app -- still read by the inline variant; the block variant now always puts the message under the title (ErrorNotice.messagePlacement.test.tsx)
Reader: website/src/components/ErrorNotice.tsx:actionPlacement -- app -- still read by the inline variant; the block variant now always uses the action row (ErrorNotice.belowOnPhone.test.tsx)
Tests
ErrorNotice.impact.test.tsx(new): role, icon, fill and inks per level;nesteddraws no box and keeps its role;announce={false}drops the role at every level;actionsrenders host buttons before the hand-off link with the button skin; the default staysblocking.errorNoticeImpactContrast.test.ts(new): reads every notice mix from the stylesheet. Every light palette and the default dark palette clear 4.5:1 text and 3:1 border and ring over--bg,--bg-elevatedand--card; every other dark palette never drops below today's colour. Both files failed before the change.errorToAgent,ErrorNotice.messagePlacement,.belowOnPhone,.showIcon,TasksCapacityCard,TrustAppModal,ChatSidebar.folderSortMode,issue-radar/IssueRadarPrDetailCoverage.test.tsx,dev-fleet/DevFleetPage.liveStateUnknownNotice.test.tsx, theCrewLogPanelsnapshot, andKiroAccountModalandApp.topbarAndShortcuts(standing notices are nowstatus).Full frontend suite run locally in four shards: the only failure outside these files is
UsageTab.spendChartHarness"$0" axis tick, which also fails with this diff reverted.Manual verification
Rendered every scene with
node capture/shoot-error-notice-impact.mjsin light and dark and looked at each frame. The button-state scene forces:hoverand:focus-visiblethrough DevTools so the real rules show.Screenshots / video
Component render, not the live page. Mocked data. Scene 1 and scene 5 error text is made up.
Button on each impact: rest, hover, focus
Blocking (KasLoginGate), blocking + nested (KiroPrerequisiteGate)
Every scene, light and dark
Related Issues
Part of #37262
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license.