Repository navigation
feat: fold channels into core and retire its hidden app record - #37431
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks. This repeats the Command Bar and Task Runner folds. The off-by-default carry writes only an opt-in, so existing Channels state is kept. No reader outside the patch uses the retired Notes
[DESIGN-REVIEWED] 2e76fca Description read[DESCRIPTION-READ] 573b6c8d0c52854d4abd88aafe5b9336dc263da387203e61a631d9349dfb5ae5 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing blocks. The blind reader read the new "Show Channels" switch correctly, said they would use it, and the PR's screenshots show both the switch and the Channels rail row. Notes
[UX-REVIEWED] 2e76fca Description read[DESCRIPTION-READ] 00cd4c45ef187cbb3864997bcfa2437d71e384ac272d25479f401825a55670ef That sha256 names everything this verdict read: the PR description, plus the 5 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks: AGENTS.md "No built-in apps" (#26967) requires the fold, defaults stay where they were, and each new piece is needed to keep a user's existing Channels state. Notes
What this change shipsInventory (8 items) — 8 justifiedIntent: retire Channels as a built-in app so it becomes part of core, and every user keeps the Channels state they had. This is an ADDITION (a migration).
[FIRST-PRINCIPLES-REVIEWED] 2e76fca Description read[DESCRIPTION-READ] eba0711bb95bff074965bfd9ae8b4745a9f8132881167c1654fd0706d825e7d4 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
5d1a24a to
177afe7
Compare
|
CI reds on 5d1a24a, triaged before 177afe7:
|
Code change approver recommendation: A person should decideWhy: the decider thinks the change is probably fine but estimates a 16% chance that this change introduces a defect, above the 12% limit for approving on its own. Channels folds into core the same way Command Bar and Task Runner did. The boot carry writes a value only when it differs from the setting's default: an opt-in for Channels (default off), still only an opt-out for the two default-on switches. It keeps a key already in config.json, keeps the record if the write fails, and does nothing on a second start. test_channels_fold.py covers each case. An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit |
Channels shipped as the hidden, default-off, manifest-only built-in app channels, whose record held one choice: whether the Channels page had a sidebar row. It becomes part of core (part of #26967), so that choice moves to the new dashboard.channels_enabled setting, default off. channels joins _MIGRATED_BUILTINS with a _FOLDED_BUILTIN_SWITCHES row and _FOLDED_OFF_BY_DEFAULT, so the boot cleanup carries an ON record (the owner's protected disable still reads as off) into the setting before it retires the record as *.retired backups beside data/; the default-on switches still carry only an opt-out. kirocrew app enable and app disable for a folded name write its setting, so the command users ran before still works. The dashboard keeps the row exactly: same nav id, icon, place among the apps and pop-out window, shown only while the setting is true and never before the config is read (configSwitchDefault: false). The route and /api/channels are served either way, as before. Its Settings row is drawn, and offered by a settings search, only while it is on, as the hidden app was listed in Library only while enabled. Part of #26967
177afe7 to
2e76fca
Compare
buluoray
left a comment
There was a problem hiding this comment.
Approve on 2e76fca. This PR turns the hidden Channels app into the core setting dashboard.channels_enabled, default off as the app was. On upgrade, an enabled Channels record becomes the setting set to true, and a disabled record writes nothing. The old record files are kept as backups, and the channels a person made are stored outside the app folder, so nothing is lost. The owner's protected disable still reads as off, a key already in config.json is kept, and a failed write keeps the record for the next start. kirocrew app enable channels and app disable channels still work and now write the setting. Mutating the carry, dropping channels from the migration list, or removing the CLI hook each turns named tests in test_channels_fold.py red. Specs (app-kit-platform, persistent-agent-channels, config, cli) changed in the same commit. Follow-ups, non-blocking: a downgrade after this upgrade shows Channels off again until it is re-enabled (the channels themselves stay), and the apps governance allowlist no longer has any say over the sidebar row, which matches the fact that the page and its API were never gated by it. Decisive lines: src/kiro_crew/apps/builtin_fold.py:32 (carry writes an opt-in only for the default-off switch), src/kiro_crew/apps/builtins/init.py:53,62,68 (channels in _MIGRATED_BUILTINS, _FOLDED_BUILTIN_SWITCHES, _FOLDED_OFF_BY_DEFAULT), src/kiro_crew/apps/manager_builtins.py:1042-1119 (carry before retire; failed write keeps the record; files renamed to *.retired, data/ kept), src/kiro_crew/channel.py:830 (channel data lives in <config_dir>/channels, outside the app directory), src/kiro_crew/cli_commands_app.py:240-262,712,776 (app enable/disable channels writes the setting)
Problem / Motivation
Goal: Channels stops being a built-in app and becomes part of core, with every existing user keeping exactly the Channels they had.
Channels shipped as the hidden, default-off, manifest-only built-in app
channels. Its page and/api/channelsare core code; the app record held one choice, whether the Channels page had a sidebar row. Part of the campaign that empties the built-in app set.Why it matters
Kiro Crew accepts no built-in apps and is moving every one out. Channels cannot move to its own repository: it has no code of its own outside core. Folding it (the way #36358 did for the Command Bar and #36361 for Task Runner) is the only way it leaves the built-in set, and it must not change anything for a person who already turned it on, or who never did.
Not a goal
*.retired) or the owner's records undermember-records/.What changed (motivation → approach → change)
dashboard.channels_enabled(config/sections_dashboard.py, recorded inconfig-baseline.json; default off, as the app'sdefaultEnabledwas), editable from Settings (dashboard/handlers/core_config_schema.py, and a cannot-widen row inchange_card_catalog_kinds.py), live through the config watcher (dashboard/server_runtime/config_watch.pypushes aconfigrefresh frame, so a CLI write reaches open dashboards).channelsjoins_MIGRATED_BUILTINSwith a_FOLDED_BUILTIN_SWITCHESrow and the new_FOLDED_OFF_BY_DEFAULTset.carry_folded_switchnow writes a record's state only when it differs from the setting's default: an opt-in for Channels, and still only an opt-out for the two default-on switches. The boot cleanup carries an ON record (an owner's protected disable reads as off), then retiresinstalled.jsonandapp.jsonas*.retiredbesidedata/. A failed write keeps the record for the next start; a key already in the file is kept.kirocrew app enable <name>andapp disable <name>for a folded name write its setting (builtin_fold.set_folded_switch, reached through_set_folded_app_switch, which thecli_commands.pyfacade manifest names), sokirocrew app enable channelskeeps working. An app a user installed under the name is its own app and takes the ordinary path.surfaces/surfaceData.ts): the same nav id (channels, so saved rail order and unpinned set still find it), the same icon, its place among the app rows (formerApp), its pop-out window (corePopoutPages), and a Search Everywhere result, all only while the setting istrue. A newconfigSwitchDefault: falsemakes a not-yet-read config count as off, so the row never flashes in. The/channelsroute and/api/channelsare served whatever the setting says, exactly as they were whatever the app's state. The old/apps/channelsURL opens the page (SURFACE_FORMER_APPS).ChannelsSetting.tsx) is drawn only while the setting is on (and stays for that visit after turning it off, so it can be undone), and a settings search offers it only then (settingEntryOfferedviachannelsOn); the find_ui index records the condition (page_turned_on, inuiLocations/conditions.tsanduiLocations/descriptors.ts).nav.channelsand the three new Settings strings are translated in everywebsite/src/i18nlocale catalog.apps.md, and theAUTOSDE.yamlrule that named the old manifest path.Backwards compatibility
Compatible: every install keeps the Channels state it had. An enabled record becomes
dashboard.channels_enabled: true, a disabled one writes nothing (default off), the page, API, channels and app data stay, andkirocrew app enable/disable channelsstill work.Reader: src/kiro_crew/apps/manager_builtins.py:cleanup_migrated_builtin -- entry: release (gateway boot) -- retires the record after carrying it; test_channels_fold.py::test_an_enabled_record_turns_the_setting_on_and_stays_as_a_backup
Reader: src/kiro_crew/apps/manager_uninstall.py:uninstall_app (retired_builtin) -- entry: crew page (Migrate) -- carries the switch the same way; test_removing_the_retired_record_from_migrate_carries_the_switch
Reader: src/kiro_crew/cli_commands_app.py:_handle_app enable/disable -- entry: chat/CLI -- writes the setting; test_the_cli_answers_for_the_folded_app_without_a_gateway
Reader: website/src/apps/builtinRegistry.ts BUILTIN_COMPONENT_REGISTRY['/channels'] -- entry: crew page -- replaced by the core route in App.tsx and corePopoutPages; corePopoutPages.test.ts
Reader: website/src/appNav.ts:appNavTarget -- entry: crew page -- a not-yet-retired built-in
channelsrecord gets no second row (SURFACE_FORMER_APPS); appRail.channels.test.tsxReader: website/src/pages/AppPage.tsx -- entry: crew page -- /apps/channels opens /channels; SURFACE_FORMER_APPS test in appRail.channels.test.tsx
Reader: website/src/components/appstore/appManifest.ts APP_MANIFEST_KEY['channels'] -- entry: crew page (App Store) -- no manifest left to localize; check-app-manifest-sync.mjs OK
Reader: test/test_apps_doc_catalogue.py hidden-app set -- entry: release -- now Workflows only
The
appsgovernance allowlist is not read for the setting: it only ever gated whether the app record could be enabled, and the page and/api/channelswere served whatever the record said, so there is no capability for it to fence.Tests
test/test_channels_fold.py: an on record turns the setting on and stays as a backup; an off record writes nothing; the owner's protected disable keeps it off; a second start changes nothing; a key already in the file is kept; a failed write keeps the record; the Migrate removal carries it; a default-on switch still carries only an opt-out;set_folded_switchon/off, before retirement, for a user's own app under the name, and for a name that never folded; the CLI enable/disable path asks no gateway; Settings PATCH accepts only a boolean.test/test_command_bar_fold.py: every folded switch defaults to its app'sdefaultEnabled.test/test_config_live_server_appliers.py: the refresh-frame applier for the switch;test_dashboard_server_composition_contract_reach.py: one more boot cleanup.website/src/shell/nav/appRail.channels.test.tsx: id, place, saved order, unpin, shown only on a literal true, unread config is off; default-on unchanged.website/src/pages/settings/ChannelsSetting.test.tsx: drawn only while on, stays after turning off, pins back an unpinned row, nothing for an older gateway.pagesProvider.configSwitch.test.ts,corePopoutPages.test.ts,settingsSearchGovernance.test.ts: Search Everywhere page result, pop-out, settings-search withholding.website/src/test/builtinRegistry.test.tsandwebsite/src/test/libraryFilter.test.ts:/channelsis no longer a builtin route, and Workflows is the one self-concealing builtin left.Proof: not provable -- other: feature PR; every new test fails on main because channels is not a folded built-in there
Local, on the rebase onto ced9489: the fold, config, find_ui, composition, built-in adoption and CLI tests (1,328) green apart from two that are red the same way on pristine origin/main with this host's
static/distbuild andnode_modules(test_the_dashboard_boot_keeps_its_chain_hooks_and_order,test_find_ui_autoauto-tier label); the seven touched vitest files plus i18n (199 tests) green;gen:uiandgen:settingsregenerated;tsc,mypy, flake8, black, isort, flake-pattern ratchet, feature-map, comment-history, brand and file-line-cap gates green.Manual verification
Isolated loopback gateways, fresh data homes, never the real one:
kirocrew app enable channels, created a channel through/api/channels, wrote a marker intoapps/channels/data/, stopped.config.jsonholdsdashboard.channels_enabled: true;installed.json.retiredandapp.json.retiredare byte-identical to the old record; the data marker andmember-records/app-grants/channels.jsonare byte-identical;/api/appsno longer listschannels;GET /api/channelsstill returns the channel;/channelsserves the page;/api/config/kirocrewreportstrue.kirocrew app disable channelsthenapp enable channelsflipped the setting the gateway reports, and a Settings PATCH tofalsewas accepted.Screenshots / video
Isolated gateway on this branch, data home upgraded from origin/main with Channels enabled. Settings > Display > View draws the Channels switch below Task Runner's (only while Channels is on):
The Channels rail row keeps its app icon and place among the apps, and the page shows the channel created before the upgrade:
Related Issues
Part of #26967
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.