Skip to content

feat: fold channels into core and retire its hidden app record - #37431

Merged
bolichen97 merged 1 commit into
mainfrom
feat/w7-channels
Nov 15, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
feat/w7-channels

Conversation

@bolichen97

@bolichen97 bolichen97 commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Channels stops being a built-in app and becomes part of core, with every existing user keeping exactly the Channels they had.

Channels shipped as the hidden, default-off, manifest-only built-in app channels. Its page and /api/channels are core code; the app record held one choice, whether the Channels page had a sidebar row. Part of the campaign that empties the built-in app set.

Why it matters

Kiro Crew accepts no built-in apps and is moving every one out. Channels cannot move to its own repository: it has no code of its own outside core. Folding it (the way #36358 did for the Command Bar and #36361 for Task Runner) is the only way it leaves the built-in set, and it must not change anything for a person who already turned it on, or who never did.

Not a goal

  • Changing what Channels does, its page, its API or its data.
  • Making Channels more discoverable: it stays hidden until someone turns it on.
  • Moving or folding any other built-in app.
  • Deleting the retired record backups (*.retired) or the owner's records under member-records/.

What changed (motivation → approach → change)

  • The setting. New dashboard.channels_enabled (config/sections_dashboard.py, recorded in config-baseline.json; default off, as the app's defaultEnabled was), editable from Settings (dashboard/handlers/core_config_schema.py, and a cannot-widen row in change_card_catalog_kinds.py), live through the config watcher (dashboard/server_runtime/config_watch.py pushes a config refresh frame, so a CLI write reaches open dashboards).
  • The fold. channels joins _MIGRATED_BUILTINS with a _FOLDED_BUILTIN_SWITCHES row and the new _FOLDED_OFF_BY_DEFAULT set. carry_folded_switch now writes a record's state only when it differs from the setting's default: an opt-in for Channels, and still only an opt-out for the two default-on switches. The boot cleanup carries an ON record (an owner's protected disable reads as off), then retires installed.json and app.json as *.retired beside data/. A failed write keeps the record for the next start; a key already in the file is kept.
  • The commands users ran. kirocrew app enable <name> and app disable <name> for a folded name write its setting (builtin_fold.set_folded_switch, reached through _set_folded_app_switch, which the cli_commands.py facade manifest names), so kirocrew app enable channels keeps working. An app a user installed under the name is its own app and takes the ordinary path.
  • The dashboard keeps the row exactly. Channels is a core surface (surfaces/surfaceData.ts): the same nav id (channels, so saved rail order and unpinned set still find it), the same icon, its place among the app rows (formerApp), its pop-out window (corePopoutPages), and a Search Everywhere result, all only while the setting is true. A new configSwitchDefault: false makes a not-yet-read config count as off, so the row never flashes in. The /channels route and /api/channels are served whatever the setting says, exactly as they were whatever the app's state. The old /apps/channels URL opens the page (SURFACE_FORMER_APPS).
  • Hidden stays hidden. The hidden app was listed in Library only while enabled. Its replacement row (Settings > Display > View, ChannelsSetting.tsx) is drawn only while the setting is on (and stays for that visit after turning it off, so it can be undone), and a settings search offers it only then (settingEntryOffered via channelsOn); the find_ui index records the condition (page_turned_on, in uiLocations/conditions.ts and uiLocations/descriptors.ts).
  • The manifest package, its App Store art and its manifest copy leave core; nav.channels and the three new Settings strings are translated in every website/src/i18n locale catalog.
  • Specs updated in the same commit: app-kit-platform (folding section and table), persistent-agent-channels, config, cli, oss-fork-boundaries, feature map, apps.md, and the AUTOSDE.yaml rule that named the old manifest path.

Backwards compatibility

Compatible: every install keeps the Channels state it had. An enabled record becomes dashboard.channels_enabled: true, a disabled one writes nothing (default off), the page, API, channels and app data stay, and kirocrew app enable/disable channels still work.

Reader: src/kiro_crew/apps/manager_builtins.py:cleanup_migrated_builtin -- entry: release (gateway boot) -- retires the record after carrying it; test_channels_fold.py::test_an_enabled_record_turns_the_setting_on_and_stays_as_a_backup
Reader: src/kiro_crew/apps/manager_uninstall.py:uninstall_app (retired_builtin) -- entry: crew page (Migrate) -- carries the switch the same way; test_removing_the_retired_record_from_migrate_carries_the_switch
Reader: src/kiro_crew/cli_commands_app.py:_handle_app enable/disable -- entry: chat/CLI -- writes the setting; test_the_cli_answers_for_the_folded_app_without_a_gateway
Reader: website/src/apps/builtinRegistry.ts BUILTIN_COMPONENT_REGISTRY['/channels'] -- entry: crew page -- replaced by the core route in App.tsx and corePopoutPages; corePopoutPages.test.ts
Reader: website/src/appNav.ts:appNavTarget -- entry: crew page -- a not-yet-retired built-in channels record gets no second row (SURFACE_FORMER_APPS); appRail.channels.test.tsx
Reader: website/src/pages/AppPage.tsx -- entry: crew page -- /apps/channels opens /channels; SURFACE_FORMER_APPS test in appRail.channels.test.tsx
Reader: website/src/components/appstore/appManifest.ts APP_MANIFEST_KEY['channels'] -- entry: crew page (App Store) -- no manifest left to localize; check-app-manifest-sync.mjs OK
Reader: test/test_apps_doc_catalogue.py hidden-app set -- entry: release -- now Workflows only

The apps governance allowlist is not read for the setting: it only ever gated whether the app record could be enabled, and the page and /api/channels were served whatever the record said, so there is no capability for it to fence.

Tests

  • test/test_channels_fold.py: an on record turns the setting on and stays as a backup; an off record writes nothing; the owner's protected disable keeps it off; a second start changes nothing; a key already in the file is kept; a failed write keeps the record; the Migrate removal carries it; a default-on switch still carries only an opt-out; set_folded_switch on/off, before retirement, for a user's own app under the name, and for a name that never folded; the CLI enable/disable path asks no gateway; Settings PATCH accepts only a boolean.
  • test/test_command_bar_fold.py: every folded switch defaults to its app's defaultEnabled.
  • test/test_config_live_server_appliers.py: the refresh-frame applier for the switch; test_dashboard_server_composition_contract_reach.py: one more boot cleanup.
  • website/src/shell/nav/appRail.channels.test.tsx: id, place, saved order, unpin, shown only on a literal true, unread config is off; default-on unchanged.
  • website/src/pages/settings/ChannelsSetting.test.tsx: drawn only while on, stays after turning off, pins back an unpinned row, nothing for an older gateway.
  • pagesProvider.configSwitch.test.ts, corePopoutPages.test.ts, settingsSearchGovernance.test.ts: Search Everywhere page result, pop-out, settings-search withholding.
  • website/src/test/builtinRegistry.test.ts and website/src/test/libraryFilter.test.ts: /channels is no longer a builtin route, and Workflows is the one self-concealing builtin left.

Proof: not provable -- other: feature PR; every new test fails on main because channels is not a folded built-in there

Local, on the rebase onto ced9489: the fold, config, find_ui, composition, built-in adoption and CLI tests (1,328) green apart from two that are red the same way on pristine origin/main with this host's static/dist build and node_modules (test_the_dashboard_boot_keeps_its_chain_hooks_and_order, test_find_ui_auto auto-tier label); the seven touched vitest files plus i18n (199 tests) green; gen:ui and gen:settings regenerated; tsc, mypy, flake8, black, isort, flake-pattern ratchet, feature-map, comment-history, brand and file-line-cap gates green.

Manual verification

Isolated loopback gateways, fresh data homes, never the real one:

  1. Booted origin/main, kirocrew app enable channels, created a channel through /api/channels, wrote a marker into apps/channels/data/, stopped.
  2. Booted this branch on the same home: config.json holds dashboard.channels_enabled: true; installed.json.retired and app.json.retired are byte-identical to the old record; the data marker and member-records/app-grants/channels.json are byte-identical; /api/apps no longer lists channels; GET /api/channels still returns the channel; /channels serves the page; /api/config/kirocrew reports true.
  3. With that gateway running, kirocrew app disable channels then app enable channels flipped the setting the gateway reports, and a Settings PATCH to false was accepted.
  4. A second home where Channels was never enabled: after the upgrade boot no key is written, the setting reads false, the record is retired, and a further restart changes nothing.

Screenshots / video

Isolated gateway on this branch, data home upgraded from origin/main with Channels enabled. Settings > Display > View draws the Channels switch below Task Runner's (only while Channels is on):

Settings, Display, View with the Show Channels switch on

The Channels rail row keeps its app icon and place among the apps, and the page shows the channel created before the upgrade:

Channels page with its rail row active

Related Issues

Part of #26967

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license; see the Licensing section of CONTRIBUTING.md.

@bolichen97
bolichen97 requested review from a team and KiroCrewCaptain as code owners November 15, 2026 00:45
@bolichen97
bolichen97 enabled auto-merge (squash) November 15, 2026 00:45
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 15, 2026
@github-actions

github-actions Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 2e76fca54e7e39913f49adb5211a049032fa367a — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks. This repeats the Command Bar and Task Runner folds. The off-by-default carry writes only an opt-in, so existing Channels state is kept. No reader outside the patch uses the retired channels app id.

Notes

  • set_folded_switch also changes what kirocrew app enable/disable does for command-bar and projects: those commands now write their settings too. The description presents this as Channels-only. Say so in the description, or add a test for one default-on name.

[DESIGN-REVIEWED] 2e76fca

Description read

[DESCRIPTION-READ] 573b6c8d0c52854d4abd88aafe5b9336dc263da387203e61a631d9349dfb5ae5

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of 2e76fca54e7e39913f49adb5211a049032fa367a — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing blocks. The blind reader read the new "Show Channels" switch correctly, said they would use it, and the PR's screenshots show both the switch and the Channels rail row.

Notes

  • The blind reader couldn't tell "Show Channels" apart from the existing "Messaging Channels" settings page: "I can't tell if it's the same as 'Show Channels' or as the 'Channels' screen." Make channels_hint say what Channels is, e.g. "Channels are rooms where several agents work together. Off removes Channels from the left rail and from Search Everywhere…"
  • channels_hint uses two names the reader didn't know ("I don't know what 'Search Everywhere' is"; "I don't know which icon on the left strip is 'Channels'"). Use the names those places carry on screen, or say "sidebar" instead of "left rail".

[UX-REVIEWED] 2e76fca

Description read

[DESCRIPTION-READ] 00cd4c45ef187cbb3864997bcfa2437d71e384ac272d25479f401825a55670ef

That sha256 names everything this verdict read: the PR description, plus the 5 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 2e76fca54e7e39913f49adb5211a049032fa367a — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks: AGENTS.md "No built-in apps" (#26967) requires the fold, defaults stay where they were, and each new piece is needed to keep a user's existing Channels state.

Notes

  • Item 6 — undeclared: the app enable/disable alias goes through _FOLDED_BUILTIN_SWITCHES, so it now also answers for command-bar and projects. The description says only "for a folded name".

What this change ships

Inventory (8 items) — 8 justified

Intent: retire Channels as a built-in app so it becomes part of core, and every user keeps the Channels state they had. This is an ADDITION (a migration).

  1. An enabled channels app record becomes dashboard.channels_enabled: true at boot, and the record is kept as *.retired. — justified
  2. A new setting, dashboard.channels_enabled, default off, changeable in Settings and applied live through the config watcher. — justified
  3. The Channels sidebar row, its pop-out and its Search Everywhere result show only while the setting is on, with the same id and place as before. — justified
  4. configSwitchDefault: false makes a config that has not been read yet count as off, so the row never briefly appears. — justified
  5. A Settings > Display > View row for Channels, shown only while it is on. — justified
  6. kirocrew app enable/disable channels now writes the setting. — justified
  7. The /apps/channels URL opens /channels. — justified
  8. The manifest, its App Store art and its manifest copy are removed. — justified

[FIRST-PRINCIPLES-REVIEWED] 2e76fca

Description read

[DESCRIPTION-READ] eba0711bb95bff074965bfd9ae8b4745a9f8132881167c1654fd0706d825e7d4

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 2e76fca54e7e39913f49adb5211a049032fa367a — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 2e76fca

Verdict parsed from the review's SHA-scoped output markers for commit 2e76fca54e7e39913f49adb5211a049032fa367a.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 2e76fca54e7e39913f49adb5211a049032fa367a false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 2e76fca54e7e39913f49adb5211a049032fa367a and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 2e76fca

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 2e76fca54e7e39913f49adb5211a049032fa367a false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 15, 2026
@bolichen97

Copy link
Copy Markdown
Contributor Author

CI reds on 5d1a24a, triaged before 177afe7:

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 15, 2026
@KiroCrewCaptain

KiroCrewCaptain commented Nov 15, 2026 •

Copy link
Copy Markdown
Collaborator

Code change approver recommendation: A person should decide

Why: the decider thinks the change is probably fine but estimates a 16% chance that this change introduces a defect, above the 12% limit for approving on its own.

Channels folds into core the same way Command Bar and Task Runner did. The boot carry writes a value only when it differs from the setting's default: an opt-in for Channels (default off), still only an opt-out for the two default-on switches. It keeps a key already in config.json, keeps the record if the write fails, and does nothing on a second start. test_channels_fold.py covers each case. kirocrew app enable/disable for a folded name writes the setting; an app a user installed under that name still takes the normal path. On the dashboard, the sidebar row and the Search Everywhere result both go through surfaceSwitchedOn, and a config that hasn't loaded yet counts as off for Channels and still on for Task Runner. The Settings row and settings search show Channels only once the config has loaded and says true. The /channels route, the pop-out window and the /api/channels endpoints are kept as before, and the icon asset the row uses still exists. No regressions or trust-boundary problems found.

An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit 2e76fca54e · 1428 changed lines. If this recommendation is wrong, reply here: replies are how the approver is evaluated.

@github-actions github-actions Bot added merge conflict Branch has merge conflicts with its base — author must resolve before merge readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 15, 2026
Channels shipped as the hidden, default-off, manifest-only built-in app
channels, whose record held one choice: whether the Channels page had a
sidebar row. It becomes part of core (part of #26967), so that choice
moves to the new dashboard.channels_enabled setting, default off.

channels joins _MIGRATED_BUILTINS with a _FOLDED_BUILTIN_SWITCHES row and
_FOLDED_OFF_BY_DEFAULT, so the boot cleanup carries an ON record (the
owner's protected disable still reads as off) into the setting before it
retires the record as *.retired backups beside data/; the default-on
switches still carry only an opt-out. kirocrew app enable and app disable
for a folded name write its setting, so the command users ran before
still works.

The dashboard keeps the row exactly: same nav id, icon, place among the
apps and pop-out window, shown only while the setting is true and never
before the config is read (configSwitchDefault: false). The route and
/api/channels are served either way, as before. Its Settings row is
drawn, and offered by a settings search, only while it is on, as the
hidden app was listed in Library only while enabled.

Part of #26967
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: passed Eligible automated validation passed for the current revision merge conflict Branch has merge conflicts with its base — author must resolve before merge labels Nov 15, 2026

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve on 2e76fca. This PR turns the hidden Channels app into the core setting dashboard.channels_enabled, default off as the app was. On upgrade, an enabled Channels record becomes the setting set to true, and a disabled record writes nothing. The old record files are kept as backups, and the channels a person made are stored outside the app folder, so nothing is lost. The owner's protected disable still reads as off, a key already in config.json is kept, and a failed write keeps the record for the next start. kirocrew app enable channels and app disable channels still work and now write the setting. Mutating the carry, dropping channels from the migration list, or removing the CLI hook each turns named tests in test_channels_fold.py red. Specs (app-kit-platform, persistent-agent-channels, config, cli) changed in the same commit. Follow-ups, non-blocking: a downgrade after this upgrade shows Channels off again until it is re-enabled (the channels themselves stay), and the apps governance allowlist no longer has any say over the sidebar row, which matches the fact that the page and its API were never gated by it. Decisive lines: src/kiro_crew/apps/builtin_fold.py:32 (carry writes an opt-in only for the default-off switch), src/kiro_crew/apps/builtins/init.py:53,62,68 (channels in _MIGRATED_BUILTINS, _FOLDED_BUILTIN_SWITCHES, _FOLDED_OFF_BY_DEFAULT), src/kiro_crew/apps/manager_builtins.py:1042-1119 (carry before retire; failed write keeps the record; files renamed to *.retired, data/ kept), src/kiro_crew/channel.py:830 (channel data lives in <config_dir>/channels, outside the app directory), src/kiro_crew/cli_commands_app.py:240-262,712,776 (app enable/disable channels writes the setting)

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 15, 2026
@bolichen97
bolichen97 merged commit 3e0c728 into main Nov 15, 2026
101 checks passed
@bolichen97
bolichen97 deleted the feat/w7-channels branch November 15, 2026 04:58
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants