Repository navigation
feat(members): hide a Bot's sessions from the session list by default - #37713
Conversation
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: the retired preview has no readers left in the tree, and the LTS default change is a recorded maintainer decision. Notes
[DESIGN-REVIEWED] 7fed4da Description read[DESCRIPTION-READ] 8854325e8c03e8e32a3c086aaab03a8ac234a60c4cdb3b201cc0437641a71a0f That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
UX Review (Opus 5.5) — ✅ PASS (a BLOCK with no Trigger and no Outcome does not block)UX-level review of UX-Verdict: PASS cannot evaluate: missing the failed-save state of the new "Show in my Sessions list" switch. Neither screenshot shows its error notice, so nobody has seen how a failed save looks next to the switch. Evidence gaps
Notes
[UX-REVIEWED] 7fed4da Description read[DESCRIPTION-READ] 95eaab3098c2aba3115892eea298a7c8f318419e8b151f3ef3beaf2b594a92f5 That sha256 names everything this verdict read: the PR description, plus the 5 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. The default flip is RFC step 9 ("flag default on (owner call)") of Notes
What this change shipsInventory (8 items) — 6 justifiedIntent: keep a person's own chats from being buried under the sessions their Bots open. ADDITION (the default changes).
[FIRST-PRINCIPLES-REVIEWED] 7fed4da Description read[DESCRIPTION-READ] 610b0d0c0e5909d0ed01180fa523c903339bd0086e003154e144374e4347dac7 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
816bb34 to
1449ce7
Compare
|
1449ce7 to
fb95a80
Compare
|
Rebased: main moved in docs/system-specs/modules/platform-context.md (conflict, resolved by keeping main's rows and dropping the retired reader), src/kiro_crew/crew_mode.py, src/kiro_crew/config/sections_dashboard.py, config-baseline.json and docs/system-specs/modules/crew-mode.md since this head was pushed (59ce18f -> fa4e40d); CI re-running. |
fb95a80 to
d63cd6e
Compare
|
|
Backend Tests (3.12, 1) fails on |
The "Bot sessions on the bot's profile" Feature Preview is retired and its behavior is the default: the sessions a live Bot thread dispatched leave the person's session lists, Recents, grid and unread counts, and show on the Bot's Sessions tab. A stored mate_sessions switch is ignored. Each Bot's Settings gets one switch, "Show in my Sessions list" (show_sessions_in_list on the Bot record, off by default). The gateway stamps it on the Bot thread's slot row, a person's GET /api/chat/slots and the dashboard's crewModeView both read that stamp, and a change to it re-sends the slot list. The Bot's Sessions tab is unchanged. Closes #37712
d63cd6e to
7fed4da
Compare
buluoray
left a comment
There was a problem hiding this comment.
Approve on 7fed4da. The new head is a pure rebase of the commit I approved at d63cd6e. git range-diff shows the patch unchanged ("1: d63cd6e = 1: 7fed4da"), and the diff stat is the same: 57 files, +518/-301. It sits on 11 newer main commits, including #37726, which fixed the wakatime flake that turned shard 1 red last time. Main and this PR both touched only text files (locale catalogs, crew-mode.md, the RFC README, config-baseline.json), and they merge cleanly. None of the 11 main commits touch mate_root, show_sessions_in_list, crewModeView or list_view. The earlier findings stand unchanged. Ray decided the decision entry stands, because the repository owner (iamwhatever) asked for the change. He also decided that users who had the preview off need no migration and no notice. CI on this head is done: 85 success, 11 skipped, 0 failed, 0 running. All five AI review lanes reviewed this head and none blocks. Decisive lines: src/kiro_crew/crew_mode.py:497-499, src/kiro_crew/crew_mode.py:621-624, src/kiro_crew/dashboard/server_runtime/config_watch.py:304-311, src/kiro_crew/dashboard/agent_admin/crew_update.py:369-374, src/kiro_crew/config/sections_dashboard.py:61-67, website/src/lib/crewMode.ts:68-74, website/src/lib/crewMode.ts:292-293, website/src/store/dashboardSlice.ts:814-818, docs/decisions/2026-11-15-a-bots-sessions-leave-the-session-list-by-default.md
Problem / Motivation
Goal: A Bot's sessions stay out of the main session list by default, and each Bot has one switch to show them there again.
Bot sessions crowd the main session list. The "Bot sessions on the bot's profile" Feature Preview already moves them to the Bot's Sessions tab, and it ran for a week with no reported problems, but it is off by default.
Why it matters
Every chat a Bot opens lands in the person's sidebar, Recents and grid, so the person's own chats get buried. The Bot's Sessions tab already lists those chats, so the main list does not need them.
Not a goal
What changed (motivation → approach → change)
The preview is retired: its Feature previews row, flag, config name and copy are gone, and a stored
mate_sessionsvalue is ignored. This is step 9 of rfc-crewmate-workers-under-the-crewmate.md (statuspartialon main): the flag's default flips by the owner's call, recorded in a new decision entry.The switch lives on the Bot's record (
show_sessions_in_list). The gateway stamps it on the Bot thread's own slot row (crew_mode.py), and both the server's person-facing slot list (crew_mode.list_view) and the dashboard's lists (crewModeViewinlib/crewMode.ts, thestore/personSlots.tsselectors andstore/dashboard/unread.tscounts) read that one stamp;types/index.chat.tsandapi/client/agents.tscarry the field. A change to the switch, from the dashboard or a config edit, re-sends the slot list, so the lists follow it at once. The flag leavesutils/previewFlags.tsand the settings search (components/commandPalette/settingsSearchCore.ts). Docs,config-baseline.json, the generatedsrc/kiro_crew/docsregistry and UI index, and the locale catalogs (i18n/locales/en.jsonand each translation) are updated.Backwards compatibility
Compatible: the new field defaults to off and a missing or non-bool value reads as off; the API refuses a non-bool
show_sessions_in_listwith 400.Reader: src/kiro_crew/config/loader_builders.py:feature_previews -- release -- names outside
FEATURE_PREVIEW_FLAGSare dropped on load, so a storedmate_sessionsis ignored (test_lts_feature_previews_off.py)Reader: website/src/hooks/usePreviewFlagServerSync.ts -- crew page -- syncs only
PREVIEW_FLAGS, so the stalemc-preview-mate-sessionskey is an unused localStorage key (previewSurfaces.test.tsx)Reader: src/kiro_crew/dashboard/chat_api/slot_detail.py:api_chat_slots -- chat --
crew=alland agent reads still keep every row (test_chat_slots_crew_view.py::test_crew_all_and_an_agents_read_keep_a_mates_sessions)Reader: website/src/pages/members/MateSessionsList.tsx -- crew page -- reads the raw slot store, not the person's list, so the Sessions tab is unchanged (MateSessionsList.test.tsx)
Tests
test_crew_show_sessions_setting.py: default off and round trip, junk reads off, the PUT persists and refuses a non-bool, the stamp lands on the Bot thread's row only, and a flip re-sends the slot list.test_chat_slots_crew_view.py: a person's read drops a Bot's sessions (switch off, unset or junk), keeps them with it on, andcrew=alland agent reads keep them.crewMode.test.ts:crewModeView, unread counts and auto-open with the switch off and on.CrewProfileSettings.test.tsx: the toggle reads off by default, writes the record, updates the roster row and reports a failed write.Proof: not provable -- other: feature PR, not a fix; the behavior is pinned by the tests listed above
Manual verification
Built the SPA and ran
scripts/capture-crewmate-profile-settings.mjsagainst stubbed APIs: the Bot's Settings page shows the new switch, off, with its caption, above "Send replies in one click".Screenshots / video
Bot Settings, light and dark:
Related Issues
Closes #37712
Checklist