Skip to content

docs(rfc): redesign the crew-owned mcp sign-in flow - #38119

Merged
KiroCrewCaptain merged 2 commits into
mainfrom
crew/slack/rfc-signin-redesign
Nov 18, 2026
Merged

KiroCrewCaptain merged 2 commits into
mainfrom
crew/slack/rfc-signin-redesign

Conversation

@buluoray

@buluoray buluoray commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Propose a design that lets a person connect Slack (and the other Crew-signed-in providers) from the card or from chat, on a local or a remote gateway, without hidden settings, jargon or a false "Connected".

Setting up Slack through Settings → Connections on a remote gateway (a server with no browser, reached from a laptop) hit seven problems: the Connect button hides behind a preview switch on another page; making the Slack app takes five places; Connect can look like it did nothing; after Allow the browser says "This site can't be reached"; the paste box is labelled "Return address"; the card said Connected but the first tool call failed; and an agent that needs a connection can only send the person to Settings.

Why it matters

Every new Slack user meets these on first use, and every remote-gateway user meets the "can't be reached" page on every sign-in. A Connected badge that is not true sends people to debug the wrong thing.

Not a goal

  • No code. This PR only adds the RFC and its index row.
  • No change to custody, the vault, the bridge or the proxy approval gate (owned by rfc-crew-owned-oauth.md).
  • No root cause for the "user rejected this tool call" failure; a separate investigation owns it, and the RFC links it once posted.
  • No default-on for the Crew sign-in preview.
  • No per-person tokens. They moved to their own RFC in docs(rfc): propose per-person connection tokens in a shared crew #39049.

What changed (motivation → approach → change)

  • Adds docs/request-for-change/rfc-crew-oauth-sign-in-redesign.md (status: draft). It reads main at 3c9f33cdc80 (re-audited at 224959b4ade) and designs one fix per problem: a one-click enable on the card, a Create the Slack app button that reuses the shipped slack_manifest.py deep link, with the MCP fields that feat(slack): opt-in Slack MCP switch in the generated app manifest #38169 adds, a primary consent button for a refused tab, remote detection before Connect with the paste box open at once, an optional https return for gateways with an https dashboard.url, plain wording, a post-grant tools/list and a check that the token holds every needed scope before Connected (no tool call) plus live-session refresh, and the existing connection.connect change card extended so the agent (or the gateway, on needs_auth) can show the Connect card in chat. The agent only shows the card; it never sees a secret, code or token, and only a person's own click starts their sign-in.
  • Adds the RFC's row to docs/request-for-change/README.md.
  • After review: section 7.4 and Phases 5a and 5b (per-person tokens) moved to docs(rfc): propose per-person connection tokens in a shared crew #39049, with a pointer left here. Current state now says that on main the Connection routes' owner gate also admits Shared Crew teammates. Second round: §2 builds no new manifest generator; it uses slack_manifest.py and defers the MCP fields to feat(slack): opt-in Slack MCP switch in the generated app manifest #38169. Q9 is answered. Accepted from review: Connected also waits for the granted scopes to match the registry's (section 6; no tool call, because the gateway never calls a tool on its own), and the dashboard origin wins over the probe when they disagree (section 4.1).
  • Rollout is eight small PRs after a Phase 0 probe. Nine open questions are listed for the repository owner.
  • builder-security checked: no new listener or wider bind; the one new route lives on the existing loopback sign-in listener only while a sign-in is pending.

Backwards compatibility

Compatible: documentation only; nothing main accepts today changes.

Removes nothing: the PR adds two documentation lines and a new file.

Tests

N/A — documentation only. scripts/docs-lint.sh passes.

Manual verification

N/A — no behaviour changes. Every code claim in the RFC was read at 3c9f33cdc80.

Related Issues

None. Follows #34811.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license.

@buluoray
buluoray requested review from a team and KiroCrewCaptain as code owners November 16, 2026 21:48
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 16, 2026
@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision 19696501e79f12acfdf09b36366213b91e2a3bf8 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 19696501e79f12acfdf09b36366213b91e2a3bf8 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 19696501e79f12acfdf09b36366213b91e2a3bf8 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

A docs-only draft RFC with nothing irreversible in it. Each fix reuses an existing seam: connection.connect, slack_manifest.py, the state-gated callback and the loopback listener. One description claim contradicts the RFC.

Notes

  • The description says the opposite of §6. It claims Connected waits for "one governed read-only registry smoke call (through the proxy gate, tool policy and SEL audit)". §6 and Q11 say "The check makes no tools/call" and use smoke_fixture "for its name only". Fix the description so reviewers approve the design the RFC actually contains.
  • Q2's recommendation says "once per chat and provider", but §7.3 bounds the card to "one open card per chat, provider and person". Make them match before an owner rules on it.

[DESIGN-REVIEWED] 1969650

Description read

[DESCRIPTION-READ] 57f559aedcb3f5c15ea491bf16b72a24ea9224d35cb24cb435439464bbfe0ca2

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 19696501e79f12acfdf09b36366213b91e2a3bf8 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 1969650

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 19696501e79f12acfdf09b36366213b91e2a3bf8 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 19696501e79f12acfdf09b36366213b91e2a3bf8 — this comment is updated in place on each push.

Review details

No findings. This PR only adds an RFC and an index row, so no code path changes. None of the candidate inconsistencies in the draft has an outcome that reaches a user, an operator, data or a security boundary.

Notes:

  • §Security says the relay "delivers only into a sign-in the same person started". On main, api_mcp_oauth_relay has no per-person binding (dashboard/handlers/connections.py:266). Worth rewording, or deferring the binding to docs(rfc): propose per-person connection tokens in a shared crew #39049.
  • §6 keeps the pair stored after a failed check, and the status poll reads holds_grant. The RFC should say how grantPresent learns about the failed check, so it meets its own Phase 5 exit criterion.

[OPUS-REVIEWED] 1969650

Verdict parsed from the review's SHA-scoped output markers for commit 19696501e79f12acfdf09b36366213b91e2a3bf8.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 19696501e79f12acfdf09b36366213b91e2a3bf8 false-positive: <reason, 20 to 500 characters>

@buluoray
buluoray force-pushed the crew/slack/rfc-signin-redesign branch from d99f502 to 62399f2 Compare November 16, 2026 22:31
@buluoray
buluoray force-pushed the crew/slack/rfc-signin-redesign branch from b2d2b97 to 4635e70 Compare November 16, 2026 23:25
@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 17, 2026
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 17, 2026
@buluoray
buluoray force-pushed the crew/slack/rfc-signin-redesign branch from 8574b29 to d345902 Compare November 17, 2026 21:49
@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 17, 2026
@KiroCrewCaptain

KiroCrewCaptain commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

Code change approver recommendation: A person should decide

Why: the decider estimates an 8% chance that this change introduces a defect, within the 12% limit for approving on its own, but it changes 612 lines, more than the 400 it may approve on its own.

Docs-only draft RFC plus one README index row. Code claims I spot-checked hold: the sign-in-off slugs, live-session marks, grant fingerprint, off-dashboard codes, public origin and browser-open helpers all exist; Slack's registry smoke_fixture is slack_read_user_profile; the relay route exists. The trust design holds up. The one-click enable uses the same setPreviewFlag persister and route as the Settings row, so it gets the same gate. The /reachable probe stays on the existing loopback listener while a sign-in is pending, and the Security section lists its one leak. The agent only shows the card and never sees a secret, code or token. Per-person tokens are moved out of scope. CI and the review lanes are green. The remaining issues are wording drift and don't block.

Tier: 2, held for a person: design-doc-gate: D.

An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit 683d7f09c8 · 612 changed lines. If this recommendation is wrong, reply here: replies are how the approver is evaluated.

@KiroCrewCaptain

Copy link
Copy Markdown
Collaborator

This adds a new concept, so it needs a design sign-off from a maintainer before it can merge. A maintainer will post the decision here.

Review result: this is a docs-only draft RFC plus one row in the request-for-change index. There is no code or test change. PR Readiness is green on this head. No blocking finding came out of the review. We spot-checked the RFC's current-state claims against the commit it was audited at, and they hold: the order of window.open before await in startMint, the callback_port_busy bind, the state-routed DCR listener, the relay's loopback validator, and the card's Connect passing no on_granted. The exit criteria in the migration plan can all be tested, and the security design keeps the agent's payload down to {slug} and keeps the paste out of the transcript.

Optional:

  • Scope: section 7.4 and phases 5a and 5b (per-person Connection tokens) go beyond the Goal and touch the vault, custody and approval areas that "Not a goal" excludes. Phase 6, the chat card, now waits on 5a. One option is to move 7.4 and its phases into a companion RFC beside docs(rfc): amend per-person r5 and r9 for connection grants #38142, so the one-person flow does not depend on it.
  • Section 7.4 ("Who may start a sign-in"), Backward compatibility and the phase order were audited at an older commit. Please re-audit them against current main and bump the audited-at commit.
  • The body says eight PRs and nine open questions. The migration table has more phases (5a, and 5b with four parts), and there are ten open questions. "What changed" also leaves out the per-person half and the state-routed listener. A body edit is enough to fix this.

buluoray added a commit that referenced this pull request Nov 18, 2026
R5 now names a grant issued to the Crew's own OAuth app for a person
as gateway-held, used only in that person's runs and never in their
runtime. R9 names a Bot's own wake next to cron jobs and channel
answers. Both come from the per-person sign-in design in #38119.
buluoray added a commit that referenced this pull request Nov 18, 2026
R5 now names a grant issued to the Crew's own OAuth app for a person
as gateway-held, used only in that person's runs and never in their
runtime. R9 names a Bot's own wake next to cron jobs and channel
answers. Both come from the per-person sign-in design in #38119.

@bolichen97 bolichen97 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of d34590201f against main d71da6862d. Docs-only draft RFC; I read the full text, the Captain review, the code-change-approver note and the AI lanes (all PASS; Opus left one note).

What holds on main: _crew_sign_in_off_slugs (src/kiro_crew/connections/status.py:618), callback_port_busy (src/kiro_crew/connections/crew_oauth.py:802), holds_grant / token_entry_name (crew_oauth.py:472, :486), _public_origin (src/kiro_crew/connections/crew_oauth_dcr.py:62), _connection_grant_fingerprint (src/kiro_crew/dashboard/change_cards_readers.py:1011), _OFF_DASHBOARD_CODES (src/kiro_crew/mcp_guide.py:106), _browser_open_supported (src/kiro_crew/cloud/connect.py:500) and the Slack redirect localhost:48106 (src/kiro_crew/connections/registry.json:40).

1. "Owner-only today" is stale on current main (re-audit needed). The Captain and the Opus lane disagree on this. Both were right at different commits. Since #38437 (a1ac53ec4f, 2026-11-17), is_owner_dashboard_request also admits a Shared Crew teammate through teammate_passes_owner_gate (src/kiro_crew/dashboard/handlers/source_providers.py:976-987, src/kiro_crew/shared_crew/teammate_access.py:225-227). Mint (src/kiro_crew/dashboard/handlers/connections.py:556), relay (:270), cancel (:851) and the OAuth client save (:1472) all use that gate. is_owner_only_for_teammates (teammate_access.py:119-133) does not list them. I evaluated it on main: it returns False for POST /api/connections/mint and POST /api/mcp/oauth/relay. So on main a teammate can already start a sign-in for the Crew's one shared grant, and that grant then serves everyone. Three consequences for the RFC:

  • §7.4 "Who may start a sign-in", Backward compatibility and Security ("widens who may call them") should say Phase 5a narrows each call to the caller's own principal. It does not open the routes.
  • The single-grant borrowing the RFC wants to close is reachable now, not only after Phase 5a. The maintainer may want a stop-gap (add the mint, relay and client-save routes to the teammate owner-only set) before 5a lands.
  • "Saving it keeps today's gate" for the OAuth app now means teammates can replace the Client Secret. Please say whether that is intended.

Please bump audited-at to current main after the re-audit.

2. Scope. I agree with the Captain: §7.4 and Phases 5a/5b are a custody and identity change (vault key, proxy lookup, approvals). The Goal and "Not a goal" exclude those areas. Phase 6 (chat card) now depends on 5a. Splitting §7.4 into a companion RFC beside #38142 would let Phases 0–5 be signed on their own merits.

3. Decisions recorded in the RFC. Open question 3 and §7.4 record rulings "by the repository owner" made by the RFC's own author. A maintainer should confirm those rulings in the sign-off, so the record does not rest on the author alone.

Open questions

  • Q1 one-click enable: agree, if it reuses setPreviewFlag behind the same gate and never flips the previews main switch or an edition lock. Given point 1, the same gate now admits teammates. Say whether a teammate may flip it.
  • Q2 gateway-raised card: agree, with the one-per-chat-provider-person bound and dashboard turns only.
  • Q4 expiry warning: 3 days is fine; key it on refresh_lifetime_days as proposed.
  • Q5 /reachable: acceptable. One false "local" case: the person's own laptop runs a Crew with a pending sign-in on 48106. Signal 2 (non-loopback dashboard host) should win over the probe when they disagree.
  • Q6 https return: agree to defer until after Phases 1–7.
  • Section 6 (Connected means it works): tools/list proves the token authenticates, not that the scopes work. Slack can list tools and still answer missing_scope on a call. The registry already carries a read-only smoke_fixture (slack_read_user_profile, registry.json:40), which Test uses. Consider running that one read call as the post-grant check, or explain why tools/list is enough.
  • Q9 prefilled link: agree, Copy manifest only.
  • Q10 departed person: tie token delete and revoke to invite revocation in Phase 5a. It needs no roles, and otherwise a revoked person's token stays in the vault for up to 30 days.

No blocking defect in the text; point 1 is a factual correction with security weight.

A Kiro Crew team member must sign off on this design before it merges. This review does not approve it.

AI-assisted, sent by Bolin Review bot

@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: passed Eligible automated validation passed for the current revision labels Nov 18, 2026
Propose fixes for seven problems seen setting up Slack through
Settings > Connections on a remote gateway: the hidden preview switch,
the five-step Slack app, a lost consent pop-up, the failed-looking
return page, jargon on the paste box, Connected before a working call,
and no way to connect from inside a chat. In a shared Crew each person
connects their own account, built on rfc-per-person-execution. Changes
no code.
@buluoray
buluoray force-pushed the crew/slack/rfc-signin-redesign branch from d345902 to 683d7f0 Compare November 18, 2026 08:42
@buluoray

Copy link
Copy Markdown
Contributor Author

Thanks, @bolichen97. Here is what changed in 683d7f0 (rebased on main and re-audited at 224959b4ade):

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 18, 2026

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the careful current-state audit. Most claims match main down to the symbol. One point needs a fix before a maintainer can decide section 2 and Phase 3.

  1. docs/request-for-change/rfc-crew-oauth-sign-in-redesign.md:199 (also lines 219-221, 564-565 and Q9 at 604-605). Section 2 designs a new registry-driven Slack manifest generator (app_manifest: "slack", redirect_urls_extra). It also says a prefilled create link "is not documented by Slack" and is "not built", and Q9 recommends Copy manifest only. Main already has both. src/kiro_crew/slack_manifest.py is the single source for the Slack app manifest. Its deep_link() returns https://api.slack.com/apps?new_app=1&manifest_yaml=<encoded>. kirocrew manifest and GET /api/slack/manifest serve that link, and the exfil redactor exempts only that exact rebuilt link. Open PR #38169 adds the MCP redirect (localhost:48106/callback), pkce_enabled and the Slack MCP user scopes to that same manifest. The RFC names neither. Trigger: a maintainer decides section 2, Q9 and Phase 3 from the RFC as written. Outcome: two parallel designs for one Slack MCP manifest, and a second generator whose deep link the redactor would block. Smallest fix: add a current-state bullet that names slack_manifest.py and its shipped deep link, and name #38169. Then choose one path: extend that generator for a no-bot Connections shape, or defer to #38169's one-app design. Drop the app_manifest field if it is no longer needed, and restate Q9 and the Alternatives bullet.

Optional notes (not required for this round):

  • Section 6 (around line 364) has the gateway send a tools/call for smoke_fixture after the grant and calls it "the same call Test uses". On main, Test never reads smoke_fixture and is refused for Crew-owned slugs (crew_oauth_test_unsupported). The Connections spec ("The sweep never calls a tool") rules out a gateway-made tools/call, because it skips the policy and profile ceiling and the SEL record. Either route the call through the governed gate, or stop at tools/list and check the granted scopes. Then align the Phase 5 exit criterion.
  • The Security line around 527 says only the person who pressed Connect gets the consent URL. In a Shared Crew, any admitted teammate can read the pending URL from GET /api/connections/mint. Consider narrowing the sentence and pointing to #39049.
  • Section 7.3's gateway-raised card has a simpler option that the RFC does not weigh: the proxy's needs_auth refusal text could name connection.connect and the slug. Listing it as an alternative would let Q2 compare the two.

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: passed Eligible automated validation passed for the current revision labels Nov 18, 2026
@buluoray
buluoray force-pushed the crew/slack/rfc-signin-redesign branch from 683d7f0 to 17035c9 Compare November 18, 2026 11:39
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 18, 2026
@buluoray

Copy link
Copy Markdown
Contributor Author

Thanks for the review of 683d7f0. These changes are in 17035c9:

  • Section 2, the Slack manifest (blocking). Fixed. Current state now names slack_manifest.py and its shipped deep_link(), and names feat(slack): opt-in Slack MCP switch in the generated app manifest #38169. Section 2 builds no second generator: the card opens slack_manifest.deep_link() with feat(slack): opt-in Slack MCP switch in the generated app manifest #38169's MCP switch on, and offers Copy manifest for the same text. app_manifest and redirect_urls_extra are dropped. Phase 3 is blocked on feat(slack): opt-in Slack MCP switch in the generated app manifest #38169. Q9 is answered, and the Alternatives bullet now rejects a second generator.
  • Section 6, the post-grant read (optional note). Kept, but governed. The read-only smoke_fixture call now goes through the proxy's own approval gate (gate_calls) as a one-shot approval for exactly that tool and those arguments. The proxy's audit writes its SEL event. Before the call, the gateway applies the same tool policy a session would, which is the enterprise mcp control plus the person's profile. If policy denies the tool, or cannot be read, no call is made, and the check falls back to comparing the granted scopes with recommended_scopes. Phase 5 records this one governed read as an exception next to "The sweep never calls a tool". The "same call Test uses" wording is gone: on main, Test refuses Crew-owned slugs.
  • Consent URL (optional note). The security sentence now says that any admitted teammate can read a pending URL today, and points to docs(rfc): propose per-person connection tokens in a shared crew #39049.
  • Section 7.3 (optional note). Naming connection.connect in the needs_auth text is listed under Alternatives, and Q2 points to it.

@bolichen97, your note was "Connected only after a real read call". The governed route above is meant to keep that without the ungoverned tools/call the Connections spec forbids. Please confirm it keeps your intent, or say what it misses.

@buluoray
buluoray force-pushed the crew/slack/rfc-signin-redesign branch from 17035c9 to 1969650 Compare November 18, 2026 11:49
@buluoray

Copy link
Copy Markdown
Contributor Author

Update in 1969650. This replaces the section 6 design in my previous comment.

  • Section 6. The post-grant check makes no tool call at all, governed or not. Connected now needs three things: tools/list answers, it still lists the registry's smoke_fixture tool (used by name only, as in the sweep), and the scopes in the token response include every recommended_scope. If the provider reports no scopes, the card says so. The Phase 5 exit criterion and the security bullet match. The other changes from 17035c9 stay as listed before: section 2 uses slack_manifest.py and waits for feat(slack): opt-in Slack MCP switch in the generated app manifest #38169, the consent-URL sentence is narrowed, and the needs_auth alternative is listed.

@bolichen97, your "Connected only after a real read call" note became a granted-scope check. The gateway never calls a tool on its own, because that call would skip the tool approval and the security log (connections.md, "The sweep never calls a tool").

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 18, 2026
@KiroCrewCaptain
KiroCrewCaptain enabled auto-merge (squash) November 18, 2026 13:58

@KiroCrewCaptain KiroCrewCaptain left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-review of 1969650 after my change request on 683d7f0. This PR is a docs-only draft RFC plus one README index row. PR Readiness is green on this head, and both AI review lanes report no blocking findings.

Earlier items:

  • Section 2, the Slack manifest (the blocking item): fixed. Current state names slack_manifest.py and its deep_link(). Section 2 builds no second generator. app_manifest and redirect_urls_extra are gone. Phase 3 waits for #38169, and Q9 and the Alternatives bullet now match.
  • Optional note on the smoke_fixture call: fixed. Section 6 now makes no tool call. It checks tools/list, the smoke_fixture name and the granted scopes.
  • Optional note on the consent URL: fixed. The Security line now says any admitted teammate can read a pending URL, and it points to #39049.
  • Optional note on the needs_auth alternative: fixed. It is listed under Alternatives, and Q2 points to it.

The review checked the RFC's code claims against main: _crew_sign_in_off_slugs, crewSignInSetup, startMint opening the tab before its first await, _OFF_DASHBOARD_CODES, _connection_grant_fingerprint, tokens_from_response and slack_manifest.deep_link are all where the RFC says. No blocking repository rule matches the two changed files. One strength: the RFC reuses the existing connection.connect card kind and the shipped manifest link instead of adding parallel paths. It also refuses a gateway-side tools/call because that call would skip the tool approval and the SEL record.

The design is signed off under the standing maintainer sign-off for changes by team members.

Optional:

  • Section 6 keeps a pair stored after a failed check. On main, _classify in connections/status.py returns Connected whenever a grant is held, and the card's probeIndicatesConnected reads grantPresent. Consider saying how a failed check reaches holds_grant and grantPresent (for example, an unproven mark stored with the pair). Also add those readers to the Phase 5 list, so the exit criterion at line 491 holds.
  • The Security line at 546-547 says the relay "delivers only into a sign-in the same person started". On main the relay has no per-person binding. Consider "delivers only into the gateway's own pending loopback listener", with #39049 for the per-person binding.
  • Some per-person wording stayed after the split: line 447 ("for you"), lines 466-469 ("that person's grant"), and lines 461 and 551-552 ("per chat, provider and person"). Q2 at line 607 says "per chat and provider". Consider using the one-grant form here and leaving the per-person form to #39049.

@github-actions github-actions Bot added readiness: checking Automated validation is still running readiness: passed Eligible automated validation passed for the current revision and removed readiness: passed Eligible automated validation passed for the current revision readiness: checking Automated validation is still running labels Nov 18, 2026
@KiroCrewCaptain
KiroCrewCaptain merged commit 8376d0b into main Nov 18, 2026
108 of 110 checks passed
@KiroCrewCaptain
KiroCrewCaptain deleted the crew/slack/rfc-signin-redesign branch November 18, 2026 14:22
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 18, 2026
buluoray added a commit that referenced this pull request Nov 18, 2026
R5 now names a grant issued to the Crew's own OAuth app for a person
as gateway-held, used only in that person's runs and never in their
runtime. R9 names a Bot's own wake next to cron jobs and channel
answers. Both come from the per-person sign-in design in #38119.
buluoray added a commit that referenced this pull request Nov 19, 2026
* docs(rfc): amend per-person r5 and r9 for connection grants

R5 now names a grant issued to the Crew's own OAuth app for a person
as gateway-held, used only in that person's runs and never in their
runtime. R9 names a Bot's own wake next to cron jobs and channel
answers. Both come from the per-person sign-in design in #38119.

* docs(rfc): fix the unchanged-rules list, carry the Bot wake through sections 3, 5 and 10, and list every change in section 15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants