Repository navigation
docs(rfc): amend per-person r5 and r9 for connection grants - #38142
Conversation
UX Review (Opus 5.5) — ⏭️ skippedRevision |
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: this is a documentation-only amendment to an RFC, it is consistent with its own sections, and it removes nothing. Notes
[DESIGN-REVIEWED] 49037e0 Description read[DESCRIPTION-READ] d35cb4d77c5a514bdbd86fa634e8607cbb895aa8f15108eb5b9d458e606cdd9b That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
Mark open question 3's three points as ruled on 2026-11-16 and point the R5 and R9 amendments, and phase 5b, at #38142.
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Mark open question 3's three points as ruled on 2026-11-16 and point the R5 and R9 amendments, and phase 5b, at #38142. Let the owner, tailnet collaborators and Kiro relay teammates each Connect, cancel, paste and Disconnect their own sign-in, keyed by their own Principal, since a relay teammate is not a collaborator. The relayed owner keeps the owner's grant because no Connection route asks for local_operator provenance.
Mark open question 3's three points as ruled on 2026-11-16 and point the R5 and R9 amendments, and phase 5b, at #38142. Let the owner, tailnet collaborators and Kiro relay teammates each Connect, cancel, paste and Disconnect their own sign-in, keyed by their own Principal, since a relay teammate is not a collaborator. The relayed owner keeps the owner's grant because no Connection route asks for local_operator provenance.
407cda0 to
13656a1
Compare
|
This adds a new concept, so it needs a design sign-off from a maintainer before it can merge. A maintainer will post the decision here. The review found no blocking issues on 13656a1. The diff changes two markdown files under docs/request-for-change/ and no code. PR Readiness passed on this head. The link to rfc-crew-owned-oauth.md resolves, and its §3 supports the claim that only the gateway proxy adds the Connection token. One thing done well: §15 says what changed, why, and what stays the same, and it keeps the promise that the person's own model, cloud and ssh credentials are never read. The amendment changes R5 (credential custody) and R9 (consent) of an accepted RFC. §15 says the RFC author's agreement is recorded by approving this pull request, and there is no review on this head yet. It should merge only after that approval. It may read best if it lands after #38119, or together with it, since the rationale points at that draft. Optional:
|
|
Thanks. All three optional notes from the review of 13656a1 are fixed in cc3e10b:
§15 lists each of these changes. The merge still waits for the maintainer's design sign-off and the RFC author's approval. The intended order is unchanged: this lands after #38119, or together with it. |
cc3e10b to
84c7676
Compare
Code change approver recommendation: A person should decideWhy: the decider estimates a 10% chance that this change introduces a defect, within the 12% limit for approving on its own, but it is held at tier 2: design-doc-gate: D. Docs-only amendment to the accepted per-person execution RFC. R5 gains a narrow exception: a Connection token issued to the Crew's own OAuth app is held by the gateway, used only in that person's runs and never put in their runtime. This matches the existing Connection proxy design in rfc-crew-owned-oauth §3, where the gateway proxy adds the token over a peer-uid-checked socket. R9 extends consent checks to a Bot's own wake, with matching edits in §3, §5 and §10. §14 now names the tokens among what the host owner can read, and a new §15 records the amendment. The text is internally consistent and the trust boundary stays sound under run-as. No repository rule forbids amending an accepted RFC in place, and other RFCs carry dated in-place amendments. CI is green. Tier: 2, held for a person: design-doc-gate: D. An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit |
bolichen97
left a comment
There was a problem hiding this comment.
Review of 84c7676858 against main d71da6862d. Docs-only amendment of an accepted RFC; I read the diff, the Captain review of 13656a12d1, the author's reply, the code-change-approver note on this head and the AI lanes (all PASS / no findings).
What holds
- The three optional notes from the Captain's earlier review are fixed on this head: §3 has a "Bot's own wake" row, §5 records a Bot's creator and editors, phase 3 in §10 covers Bot wakes, R5 cites R11, and §15 lists the §14 note.
- R11 (peer uid must equal the run-as account,
docs/request-for-change/rfc-per-person-execution.md:178-182) does support "used only in that person's runs". - The R9 change only adds consent checks, so it narrows.
- The R5 carve-out is narrow: it covers only grants issued to the Crew's own OAuth app, and keeps model logins and cloud or ssh keys unreadable.
Input before acceptance
- §15 should name who agreed, accurately. It says "Agreed by the repository owner (buluoray); the author's agreement is recorded by approving the pull request." The RFC's frontmatter says
author: bolichen(rfc-per-person-execution.md:4), and the README row says it was accepted by the maintainer @bolichen97. So the agreement that makes this amendment binding is the RFC author's and a maintainer's. Please name the proposer (buluoray) and the agreeing maintainer by handle, and link the approving review, without a role title. - It amends an accepted RFC to fit two drafts. The rationale rests on #38119 (draft) and on
rfc-crew-owned-oauth.md, which is stillstatus: draft(docs/request-for-change/rfc-crew-owned-oauth.md:3). If #38119's per-person token section changes or is split out, R5 would carry a carve-out with no design behind it. Merge this with #38119, or after it is accepted, as the author already proposes. - Nit: the reflowed §5 paragraph has a line well over the file's wrap width ("moment. Revoking consent stops jobs and Bots already saved. Every use ...").
The substance is sound and I have no blocking finding. The amendment changes the custody rule of an accepted RFC, so the decision is a maintainer's.
A Kiro Crew team member must sign off on this design before it merges. This review does not approve it.
AI-assisted, sent by Bolin Review bot
84c7676 to
89c2871
Compare
|
Thanks, @bolichen97. Here is what changed in 89c2871:
|
R5 now names a grant issued to the Crew's own OAuth app for a person as gateway-held, used only in that person's runs and never in their runtime. R9 names a Bot's own wake next to cron jobs and channel answers. Both come from the per-person sign-in design in #38119.
…ections 3, 5 and 10, and list every change in section 15
89c2871 to
49037e0
Compare
bolichen97
left a comment
There was a problem hiding this comment.
Agreement from @bolichen97, the per-person execution RFC's author, on 49037e0: the R5 and R9 amendments are accepted. R5's carve-out covers only grants issued to the Crew's own OAuth app, used only in that person's runs (R11); model logins and cloud or ssh keys stay unreadable. R9 only adds consent checks. This amendment rests on #39049, accepted above, and should merge after it.
AI-assisted, sent by Bolin Review bot at @bolichen97's direction
Problem / Motivation
Goal: Amend R5 and R9 of the accepted per-person execution RFC so that each person in a shared Crew can hold their own Connection sign-in under its rules.
Per-person Connection tokens in #39049 (split out of the sign-in redesign in #38119) give each person in a shared Crew their own Connection token (Slack, GitHub and the other Crew-signed-in providers). It builds on this RFC, but two rules do not fit as written:
Why it matters
Without these two amendments, the per-person design in #39049 either breaks R5 or keeps one shared token that every person's chat borrows, and a Bot wake could spend someone's token with no consent check.
Not a goal
What changed (motivation → approach → change)
Agreement. Proposed by @buluoray on 2026-11-16. It takes effect with an approving review by @bolichen97, the RFC's author; this PR waits for that review.
Backwards compatibility
Compatible: documentation only; nothing main accepts today changes.
Removes nothing: the change adds sentences to two rules and one section.
Tests
N/A — documentation only.
scripts/docs-lint.shpasses.Manual verification
N/A — no behaviour changes.
Related Issues
Part of #27006. Follows #38119; needed by #39049.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributions are accepted under the project's Apache-2.0 license.