Repository navigation
test: count the fourteen diff-scoped base-ref wirings on main - #38295
Conversation
#38250 (METRICS_SCHEMA_BASE_REF in ci.yml) and #38097 (EMOJI_ICON_BASE_REF in fast-gate.yml) each bumped the wiring count in renderVerdict.test.ts from 12 to 13 against the same base. Both merged, so main now carries 14 wirings and the test still expects 13, which fails Frontend Tests (1) on main and on every open PR.
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing to check. The diff only changes an expected count in a test, so no user-visible control is added or changed. [UX-REVIEWED] b007f52 Description read[DESCRIPTION-READ] a6d95e54b7b0685bb16543c6fcaa0e05bf74c122c7c5bee0e569c50338bf06bc That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS A test-only count bump that brings the expectation back in line with the 14 wirings on main. Notes
[DESIGN-REVIEWED] b007f52 Description read[DESCRIPTION-READ] 08b43d1b3049550c331e00f800f542638c5ddc891cc59df94c50620e1e963409 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
buluoray
left a comment
There was a problem hiding this comment.
🤖 Kiro Crew Auto-Pipeline [operator: buluoray#rayrayxu]: Approve at b007f52.
Verified on origin/main: the *_BASE_REF: ${{ lines number 14 (fast-gate.yml 9, ci.yml 5). #38250 added METRICS_SCHEMA_BASE_REF (ci.yml) and #38097 added EMOJI_ICON_BASE_REF (fast-gate.yml); both use the shared base.sha / merge_group.base_sha / event.before expression, so the per-line assertions below the count already cover them. Main CI run 44029599376 fails Frontend Tests (1) on exactly expected 13, got 14.
Non-blocking follow-up: the comment now says "nine of the fourteen wirings ... on the remaining four". ci.yml carries five now, so "remaining four" should read "remaining five".
Problem / Motivation
Goal: Frontend Tests (1) goes green again on main and on every open PR.
website/src/test/renderVerdict.test.ts> "CI supplies a base commit on both paths" > "wires every diff-scoped gate step" fails on main084b4c1bac:expected [ …(14) ] to have a length of 13 but got 14. #38250 addedMETRICS_SCHEMA_BASE_REFtoci.ymland #38097 addedEMOJI_ICON_BASE_REFtofast-gate.yml. Each one bumped the count from 12 to 13 against the same base, and both merged, so main has 14 wirings.Why it matters
Every open PR gets a red Frontend Tests (1) shard that its own diff did not cause (seen on #38254, which touches no
website/or.github/file), so nothing can merge on green until the count matches.Not a goal
What changed (motivation → approach → change)
Symptom: the wiring-count assertion fails on main. Root cause: two PRs raced on the same counter. Change: the expected count goes from 13 to 14, and the comment that names fast-gate's share now reads "nine of the fourteen". Both new wirings use the shared expression (
pull_request.base.sha/merge_group.base_sha/event.before), so the per-line assertions in the same block already pass for them.Backwards compatibility
Compatible: test-only change.
Removes nothing: the diff only raises an expected count in a test.
Tests
renderVerdict.test.ts: 61/61 pass locally withnpx vitest run src/test/renderVerdict.test.ts.Proof: not provable -- frontend test (prove.py runs Python only)
Manual verification
N/A — unit coverage sufficient; the change is the test itself.
Related Issues
Unblocks #38254.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)Contribution License Agreement
Contributed under the project's Apache-2.0 license.