Skip to content

test: count the fourteen diff-scoped base-ref wirings on main - #38295

Merged
bolichen97 merged 1 commit into
mainfrom
crew/LinuxFlackyGuard/render-verdict-wiring-count
Nov 17, 2026
Merged

bolichen97 merged 1 commit into
mainfrom
crew/LinuxFlackyGuard/render-verdict-wiring-count

Conversation

@bolichen97

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Frontend Tests (1) goes green again on main and on every open PR.

website/src/test/renderVerdict.test.ts > "CI supplies a base commit on both paths" > "wires every diff-scoped gate step" fails on main 084b4c1bac: expected [ …(14) ] to have a length of 13 but got 14. #38250 added METRICS_SCHEMA_BASE_REF to ci.yml and #38097 added EMOJI_ICON_BASE_REF to fast-gate.yml. Each one bumped the count from 12 to 13 against the same base, and both merged, so main has 14 wirings.

Why it matters

Every open PR gets a red Frontend Tests (1) shard that its own diff did not cause (seen on #38254, which touches no website/ or .github/ file), so nothing can merge on green until the count matches.

Not a goal

  • Changing either gate or its workflow wiring.
  • Replacing the count with a set, which the test's own comment rejects on purpose.

What changed (motivation → approach → change)

Symptom: the wiring-count assertion fails on main. Root cause: two PRs raced on the same counter. Change: the expected count goes from 13 to 14, and the comment that names fast-gate's share now reads "nine of the fourteen". Both new wirings use the shared expression (pull_request.base.sha / merge_group.base_sha / event.before), so the per-line assertions in the same block already pass for them.

Backwards compatibility

Compatible: test-only change.

Removes nothing: the diff only raises an expected count in a test.

Tests

renderVerdict.test.ts: 61/61 pass locally with npx vitest run src/test/renderVerdict.test.ts.

Proof: not provable -- frontend test (prove.py runs Python only)

Manual verification

N/A — unit coverage sufficient; the change is the test itself.

Related Issues

Unblocks #38254.

Checklist

  • At most two commits (one is the norm), with a Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...)
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributed under the project's Apache-2.0 license.

#38250 (METRICS_SCHEMA_BASE_REF in ci.yml) and #38097
(EMOJI_ICON_BASE_REF in fast-gate.yml) each bumped the wiring count
in renderVerdict.test.ts from 12 to 13 against the same base. Both
merged, so main now carries 14 wirings and the test still expects 13,
which fails Frontend Tests (1) on main and on every open PR.
@bolichen97
bolichen97 requested review from a team and KiroCrewCaptain as code owners November 17, 2026 06:39
@bolichen97
bolichen97 requested a review from buluoray November 17, 2026 06:39
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision b007f52bc1c8c7a7266df9fd87afbcebc37c812a ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ✅ PASS

UX-level review of b007f52bc1c8c7a7266df9fd87afbcebc37c812a — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

UX-Verdict: PASS

Nothing to check. The diff only changes an expected count in a test, so no user-visible control is added or changed.

[UX-REVIEWED] b007f52

Description read

[DESCRIPTION-READ] a6d95e54b7b0685bb16543c6fcaa0e05bf74c122c7c5bee0e569c50338bf06bc

That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of b007f52bc1c8c7a7266df9fd87afbcebc37c812a — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

A test-only count bump that brings the expectation back in line with the 14 wirings on main.

Notes

  • The comment now reads "nine of the fourteen … the remaining four", but ci.yml carries five *_BASE_REF wirings and fast-gate.yml nine, so "four" should be "five".

[DESIGN-REVIEWED] b007f52

Description read

[DESCRIPTION-READ] 08b43d1b3049550c331e00f800f542638c5ddc891cc59df94c50620e1e963409

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed b007f52bc1c8c7a7266df9fd87afbcebc37c812a — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] b007f52

Verdict parsed from the review's SHA-scoped output markers for commit b007f52bc1c8c7a7266df9fd87afbcebc37c812a.

False positive or not applicable? A repository writer can comment:
/ai-review override fable b007f52bc1c8c7a7266df9fd87afbcebc37c812a false-positive: <reason, 20 to 500 characters>

@github-actions

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of b007f52bc1c8c7a7266df9fd87afbcebc37c812a and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] b007f52

False positive or not applicable? A repository writer can comment:
/ai-review override gpt b007f52bc1c8c7a7266df9fd87afbcebc37c812a false-positive: <reason, 20 to 500 characters>

@bolichen97
bolichen97 enabled auto-merge (squash) November 17, 2026 06:45

@buluoray buluoray left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Kiro Crew Auto-Pipeline [operator: buluoray#rayrayxu]: Approve at b007f52.

Verified on origin/main: the *_BASE_REF: ${{ lines number 14 (fast-gate.yml 9, ci.yml 5). #38250 added METRICS_SCHEMA_BASE_REF (ci.yml) and #38097 added EMOJI_ICON_BASE_REF (fast-gate.yml); both use the shared base.sha / merge_group.base_sha / event.before expression, so the per-line assertions below the count already cover them. Main CI run 44029599376 fails Frontend Tests (1) on exactly expected 13, got 14.

Non-blocking follow-up: the comment now says "nine of the fourteen wirings ... on the remaining four". ci.yml carries five now, so "remaining four" should read "remaining five".

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 17, 2026
@bolichen97
bolichen97 merged commit 48d0a93 into main Nov 17, 2026
99 checks passed
@bolichen97
bolichen97 deleted the crew/LinuxFlackyGuard/render-verdict-wiring-count branch November 17, 2026 07:32
@github-actions github-actions Bot removed the readiness: passed Eligible automated validation passed for the current revision label Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants