Repository navigation
revert: restore emoji status marks in kirocrew doctor - #39226
Conversation
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks. This is a clean revert of a reversed product decision, and the doctor's status-line parser and its writer ( Notes
[DESIGN-REVIEWED] 58aa793 Description read[DESCRIPTION-READ] 80879a91b61cae655ab6f68b3a5b9f17b64f99cf1a66cc65753fd08292d2607f That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. This is a pure revert of #38843, backed by an owner decision recorded in #39217. Every hunk changes a doctor status mark back to its emoji, and the doctor's status-line parser changes with it. What this change shipsInventory (4 items) — 4 justifiedIntent: let
[FIRST-PRINCIPLES-REVIEWED] 58aa793 Description read[DESCRIPTION-READ] 3fc30905e31fe0baf1f42438e7de8c4bd28e0320dfa54fbaa4fb6a6b00ed11f4 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
bb3954d to
7fbabe7
Compare
This reverts commit 2f88858, the merge of #38843, which replaced the doctor's emoji status marks with plain words. The owner decided that only the web UI loses emoji; the CLI, CI, doctor, Slack and the chat apps keep them. Doctor output has no web UI caller. The revert also restores the doctor's own status-line parser (line[2:] after the mark), so the two stay in step. Fixes #39217
7fbabe7 to
58aa793
Compare
Problem / Motivation
Goal:
kirocrew doctorprints its emoji status marks again, as it did before #38843.#38843 replaced the doctor's emoji status marks (
✅,⚠️,❌, ...) with plain words. The owner, Zezhen, has since decided that only the web UI loses emoji; the CLI, CI output,kirocrew doctor, Slack and the chat apps keep them.Why it matters
Doctor output is terminal-only (it has no web UI caller), so the plain-word change has no remaining reason. Leaving it in place makes doctor disagree with the owner's decision and with the rest of the CLI once its own revert lands.
Not a goal
website/srcguard; both stay.What changed (motivation → approach → change)
Owner decision (only the web UI loses emoji) → a pure
git revert -m1 2f88858c53of #38843's merge commit, off freshorigin/main, with no hand edits → the doctor's status marks, its tests and goldens, and thedocs/system-specs/modules/cli.md/security.mdlines #38843 changed come back. The revert also restorescli_doctor.py's own status-line parser (line.startswith("❌")thenline[2:]) together withlts_sign_in.describe()'s❌lead, so the writer and the parser stay in step.It applied without conflicts. Later main changes to the same files (#38908 Windows ffmpeg hint, #36476 Pi MCP note) do not touch the reverted lines and are kept.
Backwards compatibility
Compatible: this restores the output shape doctor had before #38843; no config, key, API or file format changes.
Removes nothing: the diff only swaps the plain status words in doctor output back to the emoji marks; no path, record, key or function is removed.
Tests
The tests and goldens #38843 changed are reverted with it, so they expect the emoji marks again.
Proof: not provable -- other: a pure revert; the restored tests are the pre-#38843 tests and CI runs them.
Static gates run locally: black (26.10.1, bounded gate), subprocess-encoding, flake8, comment-history, brand-name, file-line-cap, mypy
--platform linux(no errors in changed files). isort flags one unchanged import block incli_doctor.pythat main flags the same way.Manual verification
N/A -- a pure revert to the previously shipped doctor output; CI runs the restored doctor tests.
Real-machine verification
N/A -- a pure revert of string marks in doctor output to the shape main shipped before #38843; no new behaviour runs.
Related Issues
Fixes #39217
Related: #39208 (revert of the backend emoji CI guard, PR #39210). Until #39210 merges, the
backend-emoji-lintcheck fails on this PR, because the guard rejects every restored emoji line; that failure is expected.Sibling sweep
Siblings: none -- the other backend emoji areas are reverted in their own PRs per the owner's plan.
Pattern harvest
Not generalizable: a revert of an owner-reversed product decision, not a defect class.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...); PR Hygiene does not count commitsContribution License Agreement
Contributed under the project's Apache-2.0 license.