Skip to content

revert: restore emoji status marks in kirocrew doctor - #39226

Merged
CrysisDeu merged 1 commit into
mainfrom
revert/39217-doctor-emoji
Nov 18, 2026
Merged

CrysisDeu merged 1 commit into
mainfrom
revert/39217-doctor-emoji

Conversation

@CrysisDeu

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: kirocrew doctor prints its emoji status marks again, as it did before #38843.

#38843 replaced the doctor's emoji status marks (✅, ⚠️, ❌, ...) with plain words. The owner, Zezhen, has since decided that only the web UI loses emoji; the CLI, CI output, kirocrew doctor, Slack and the chat apps keep them.

Why it matters

Doctor output is terminal-only (it has no web UI caller), so the plain-word change has no remaining reason. Leaving it in place makes doctor disagree with the owner's decision and with the rest of the CLI once its own revert lands.

Not a goal

What changed (motivation → approach → change)

Owner decision (only the web UI loses emoji) → a pure git revert -m1 2f88858c53 of #38843's merge commit, off fresh origin/main, with no hand edits → the doctor's status marks, its tests and goldens, and the docs/system-specs/modules/cli.md / security.md lines #38843 changed come back. The revert also restores cli_doctor.py's own status-line parser (line.startswith("❌") then line[2:]) together with lts_sign_in.describe()'s ❌ lead, so the writer and the parser stay in step.

It applied without conflicts. Later main changes to the same files (#38908 Windows ffmpeg hint, #36476 Pi MCP note) do not touch the reverted lines and are kept.

Backwards compatibility

Compatible: this restores the output shape doctor had before #38843; no config, key, API or file format changes.

Removes nothing: the diff only swaps the plain status words in doctor output back to the emoji marks; no path, record, key or function is removed.

Tests

The tests and goldens #38843 changed are reverted with it, so they expect the emoji marks again.

Proof: not provable -- other: a pure revert; the restored tests are the pre-#38843 tests and CI runs them.

Static gates run locally: black (26.10.1, bounded gate), subprocess-encoding, flake8, comment-history, brand-name, file-line-cap, mypy --platform linux (no errors in changed files). isort flags one unchanged import block in cli_doctor.py that main flags the same way.

Manual verification

N/A -- a pure revert to the previously shipped doctor output; CI runs the restored doctor tests.

Real-machine verification

N/A -- a pure revert of string marks in doctor output to the shape main shipped before #38843; no new behaviour runs.

Related Issues

Fixes #39217
Related: #39208 (revert of the backend emoji CI guard, PR #39210). Until #39210 merges, the backend-emoji-lint check fails on this PR, because the guard rejects every restored emoji line; that failure is expected.

Sibling sweep

Siblings: none -- the other backend emoji areas are reverted in their own PRs per the owner's plan.

Pattern harvest

Not generalizable: a revert of an owner-reversed product decision, not a defect class.

Checklist

  • A Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...); PR Hygiene does not count commits
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributed under the project's Apache-2.0 license.

@CrysisDeu
CrysisDeu requested review from a team and KiroCrewCaptain as code owners November 18, 2026 19:53
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 18, 2026
@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 58aa7938531d6a3cbd47618ca7e942613f6f3aa8 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 58aa7938531d6a3cbd47618ca7e942613f6f3aa8 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks. This is a clean revert of a reversed product decision, and the doctor's status-line parser and its writer (lts_sign_in.describe()) are restored together. No dashboard or web UI code reads doctor output.

Notes

[DESIGN-REVIEWED] 58aa793

Description read

[DESCRIPTION-READ] 80879a91b61cae655ab6f68b3a5b9f17b64f99cf1a66cc65753fd08292d2607f

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 58aa7938531d6a3cbd47618ca7e942613f6f3aa8 — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks. This is a pure revert of #38843, backed by an owner decision recorded in #39217. Every hunk changes a doctor status mark back to its emoji, and the doctor's status-line parser changes with it.

What this change ships

Inventory (4 items) — 4 justified

Intent: let kirocrew doctor users see emoji status marks again, matching the owner's rule that only the web UI drops emoji. This is a FIX (revert).

  1. Doctor rows show ✅/⚠️/❌/ℹ️/⏹ instead of OK:/Warning:/Error:/Note: — justified
  2. The LTS sign-in line in doctor starts with ❌/✅ again, and cli_doctor.py's startswith("❌") parser matches it — justified
  3. The cli.md/security.md spec rule "a plain word, never an emoji" is deleted. The deleted pin is named in the description and reversed by Revert the doctor emoji removal (#38843) #39217 — justified
  4. The doctor tests and goldens expect emoji again — justified

[FIRST-PRINCIPLES-REVIEWED] 58aa793

Description read

[DESCRIPTION-READ] 3fc30905e31fe0baf1f42438e7de8c4bd28e0320dfa54fbaa4fb6a6b00ed11f4

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 58aa7938531d6a3cbd47618ca7e942613f6f3aa8 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 58aa793

Verdict parsed from the review's SHA-scoped output markers for commit 58aa7938531d6a3cbd47618ca7e942613f6f3aa8.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 58aa7938531d6a3cbd47618ca7e942613f6f3aa8 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 58aa7938531d6a3cbd47618ca7e942613f6f3aa8 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 58aa793

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 58aa7938531d6a3cbd47618ca7e942613f6f3aa8 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 18, 2026
@CrysisDeu
CrysisDeu force-pushed the revert/39217-doctor-emoji branch from bb3954d to 7fbabe7 Compare November 18, 2026 21:04
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 18, 2026
This reverts commit 2f88858, the
merge of #38843, which replaced the doctor's emoji status marks with
plain words.

The owner decided that only the web UI loses emoji; the CLI, CI,
doctor, Slack and the chat apps keep them. Doctor output has no web
UI caller. The revert also restores the doctor's own status-line
parser (line[2:] after the mark), so the two stay in step.

Fixes #39217
@CrysisDeu
CrysisDeu force-pushed the revert/39217-doctor-emoji branch from 7fbabe7 to 58aa793 Compare November 18, 2026 22:24
@CrysisDeu
CrysisDeu merged commit 3f9acc8 into main Nov 18, 2026
98 of 102 checks passed
@CrysisDeu
CrysisDeu deleted the revert/39217-doctor-emoji branch November 18, 2026 22:38
@github-actions github-actions Bot removed the readiness: checking Automated validation is still running label Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revert the doctor emoji removal (#38843)

1 participant