Repository navigation
revert: bring back emoji in slack and console text from #38837 - #39230
Conversation
UX Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: this only changes text on Slack and console surfaces, the lines the dashboard shows stay plain as the owner decided, and none of it touches [DESIGN-REVIEWED] 3751858 Description read[DESCRIPTION-READ] eff7abe0de44cae21280805ddc08aee0aa92e0315674dd6cf49a5e2df8df277f That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS Nothing blocks. This is a scoped revert of #38837 that issue #39225 and the owner's decision ask for. Text the dashboard shows stays plain, and none of these strings is a default mode or a removed capability. What this change shipsInventory (6 items) — 6 justifiedIntent: Slack and gateway-console readers get their emoji back, and the web UI stays emoji-free. This is a FIX (revert).
[FIRST-PRINCIPLES-REVIEWED] 3751858 Description read[DESCRIPTION-READ] fa8a51afcb0f116ba634db06b33e990dd42e03775a631ecfb682b451a016af9d That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
10b74d6 to
ff6ab2d
Compare
Partial revert of #38837 (merge 5c68161). The owner decided only the web UI drops emoji; Slack messages and the gateway's console lines keep them. Reverted: every slack/ file outside gateway_runtime/, and in gateway_runtime/ the console prints (channel_lifecycle, exit_path, install_repair, process_entry, service_boot, update_schedule), the Slack approval card (turn_approvals), the Slack-only cron and heartbeat headers (cron_delivery, result_egress) and the subagent status log line (subagent_wiring). Kept plain, because the dashboard shows them: cron_exec, cron_failure, cron_fire, cron_turn, cron_verdict, heartbeat_turns, the dashboard lines of cron_delivery and the heartbeat chat title in result_egress. Conflicts in events_slash, interactions and renderer keep main's later code (#38938, #30760, #39112); only #38837's own emoji come back. Tests that #30760 and #38938 wrote against the plain words now expect the restored glyphs. Refs #38837 Closes #39225
ff6ab2d to
3751858
Compare
Problem / Motivation
Goal: Slack messages and the gateway's console lines show their emoji again, while every line the web UI shows stays plain.
#38837 swapped the emoji in Slack messages, Block Kit labels, Home Tab headers and the gateway's terminal lines for plain lead words (
Warning:,Blocked:,Error:,Stopped:...). The owner, Zezhen, decided that only the web UI drops emoji. Slack and the console keep them.Why it matters
Slack users and people watching the gateway's terminal lost the emoji they scan for. A full
git revertof #38837 is not safe: someslack/gateway_runtime/files also write the dashboard's cron and heartbeat notification titles, cron result leads and the heartbeat chat title, so it would put emoji back in the web UI.Not a goal
SHARED_OWNER_ONLY_TEXTinslack/shared_access.py:196, fix(slack): post the thinking reply above the answer, not after it #39112's*Thinking*label inslack/renderer_thinking.py, feat(slack): code-channel bar actions, canvas comments, view tabs #22370's tool replies inslack/code_channels/tools.py).What changed (motivation → approach → change)
Owner decision (only the web UI loses emoji) →
git revert -m1 5c68161b70, then put back main's plain text on every line the dashboard can show → partial revert.Reverted to the emoji version:
src/kiro_crew/slack/file outsidegateway_runtime/, andsrc/kiro_crew/docs/slack-integration.md.gateway_runtime/: the consoleprints inchannel_lifecycle.py,exit_path.py,install_repair.py,process_entry.py,service_boot.pyandupdate_schedule.py; the Slack approval card text inturn_approvals.py; the Slack-only cron header incron_delivery.py(⏰ *Cron: …*); the Slack heartbeat header inresult_egress.py(💓 *title*); the📡 subagent_statuslog line insubagent_wiring.py.Conflicts (
slack/events_slash.py,slack/interactions.py,slack/renderer.py) keep main's later code from #38938, #30760 and #39112. Only #38837's own emoji come back: the⛔on the unauthorized-button refusal ininteractions.py. #38938 removed the⚠ … set up for …slash reply, so it stays gone. The renderer's Thinking path and its comments stay as #39112 wrote them.Kept plain (not reverted), because the web UI shows them:
gateway_runtime/cron_exec.py⚡ {label}notify titles (:506-511);_strip_error_lead(:245, #38821)gateway_runtime/cron_failure.pymark, so they stay plain too)gateway_runtime/cron_delivery.pyWarning: … same result(:76), dup title (:88),Warning: Job completed but Slack delivery failed(:431)gateway_runtime/cron_delivery.pyCron: {name}channel delivery (:265)gateway_runtime/heartbeat_turns.pyHeartbeattitle (:352),Warning:lead (:253)gateway_runtime/result_egress.py{seed}(:511)gateway_runtime/cron_fire.pyWarning: Model … unavailable(:107)gateway_runtime/cron_turn.pyWarning:leads (:413, :985)gateway_runtime/cron_verdict.pyBlocked:partial-block lead (:210)gateway_runtime/subagent_wiring.pyAgent x failed/Warning: Result delivery failed(:493-497, #38861)Because the heartbeat title stays
Heartbeatand the Slack header adds💓, Slack now shows💓 *Heartbeat*(before #38837 it showed💓 *💓 Heartbeat*).Tests: test files for the kept lines stay at main (
test_cron_dedup,test_cron_empty_reply_dedup,test_cron_gateway_integration_llm,test_cron_mirror_backend_model_pin,test_cron_refusal_status,test_cron_slack_delivery,test_cron_stop_interrupt_notice,test_heartbeat_deliver_default,test_heartbeat_prompt_deliver,test_heartbeat_prompt_inject_row,test_slack_gateway, and the matching hunks intest_slack_gateway_coverage_notifications,test_slack_gateway_cron_exec_coverage_delivery,test_slack_backports,test_slack_renderer). Tests that later PRs wrote against the plain words now expect the restored glyphs:test_slack_shared_access.py(⛔ Not authorized.,⛔ Owner-only command.) andtest_slack_manifest_command.py(⛔ You are not authorized to use this command.).Backwards compatibility
Compatible: only message text changes. No key, field, type or reader is changed; the protocol readers from #38861 accept both the glyph and the word.
Removes nothing: the diff changes the wording of Slack and console strings back to their earlier emoji form; no path, record, key, validator or function is removed.
Tests
Updated tests follow the restored strings (see the list above). The Slack handler golden checksums in
test_slack_handler_composition_contract_golden.pyandtest/fixtures/channel_cards/slack_stop_working_goldens.jsonare restored from before #38837; CI confirms they still match.Proof: not provable -- copy-only change
Local runs: static gates only (black 26.10.1 gate, subprocess-encoding, isort, flake8, mypy, comment-history, brand, file-line-cap). No local test suite was run; CI is the test runner.
The
backend-emoji-lintcheck is expected to fail until #39210 removes that guard. This PR is rebased after #39210 merges.Manual verification
N/A — text-only change; the tests assert the restored strings.
Real-machine verification
N/A -- the diff changes message strings only; no behaviour runs differently.
Related Issues
Closes #39225
Partial revert of #38837. Related: #39208, #39210.
Sibling sweep
Swept:
git revert -m1 5c68161b70on main, then every reverted hunk undersrc/kiro_crew/slack/gateway_runtime/was checked for adashboard_state.notify,slot.append,slot.titleor returned cron result.Sibling: src/kiro_crew/slack/gateway_runtime/cron_failure.py -- not affected -- kept plain because the dashboard shows its notify text
Sibling: src/kiro_crew/slack/gateway_runtime/cron_delivery.py -- changed here -- only the Slack header line goes back to the emoji
Pattern harvest
Not generalizable: a one-off owner decision on which surfaces keep emoji, applied to one earlier PR.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...); PR Hygiene does not count commitsContribution License Agreement
Contributions are accepted under the project's Apache-2.0 license.