Skip to content

revert: bring back emoji in slack and console text from #38837 - #39230

Merged
CrysisDeu merged 1 commit into
mainfrom
revert/slack-emoji-partial
Nov 18, 2026
Merged

CrysisDeu merged 1 commit into
mainfrom
revert/slack-emoji-partial

Conversation

@CrysisDeu

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Slack messages and the gateway's console lines show their emoji again, while every line the web UI shows stays plain.

#38837 swapped the emoji in Slack messages, Block Kit labels, Home Tab headers and the gateway's terminal lines for plain lead words (Warning:, Blocked:, Error:, Stopped: ...). The owner, Zezhen, decided that only the web UI drops emoji. Slack and the console keep them.

Why it matters

Slack users and people watching the gateway's terminal lost the emoji they scan for. A full git revert of #38837 is not safe: some slack/gateway_runtime/ files also write the dashboard's cron and heartbeat notification titles, cron result leads and the heartbeat chat title, so it would put emoji back in the web UI.

Not a goal

What changed (motivation → approach → change)

Owner decision (only the web UI loses emoji) → git revert -m1 5c68161b70, then put back main's plain text on every line the dashboard can show → partial revert.

Reverted to the emoji version:

  • Every src/kiro_crew/slack/ file outside gateway_runtime/, and src/kiro_crew/docs/slack-integration.md.
  • In gateway_runtime/: the console prints in channel_lifecycle.py, exit_path.py, install_repair.py, process_entry.py, service_boot.py and update_schedule.py; the Slack approval card text in turn_approvals.py; the Slack-only cron header in cron_delivery.py (⏰ *Cron: …*); the Slack heartbeat header in result_egress.py (💓 *title*); the 📡 subagent_status log line in subagent_wiring.py.

Conflicts (slack/events_slash.py, slack/interactions.py, slack/renderer.py) keep main's later code from #38938, #30760 and #39112. Only #38837's own emoji come back: the ⛔ on the unauthorized-button refusal in interactions.py. #38938 removed the ⚠ … set up for … slash reply, so it stays gone. The renderer's Thinking path and its comments stay as #39112 wrote them.

Kept plain (not reverted), because the web UI shows them:

File Lines kept plain Where it shows
gateway_runtime/cron_exec.py ⚡ {label} notify titles (:506-511); _strip_error_lead (:245, #38821) dashboard notifications
gateway_runtime/cron_failure.py whole file (dashboard notify titles and bodies; its Slack alert lines share the same mark, so they stay plain too) dashboard notifications
gateway_runtime/cron_delivery.py Warning: … same result (:76), dup title (:88), Warning: Job completed but Slack delivery failed (:431) cron result and dashboard notify
gateway_runtime/cron_delivery.py Cron: {name} channel delivery (:265) not sure: chat-app channel delivery; kept plain to be safe
gateway_runtime/heartbeat_turns.py Heartbeat title (:352), Warning: lead (:253) dashboard notify and chat
gateway_runtime/result_egress.py heartbeat chat title {seed} (:511) dashboard sidebar
gateway_runtime/cron_fire.py Warning: Model … unavailable (:107) cron result in dashboard chat
gateway_runtime/cron_turn.py Warning: leads (:413, :985) cron result in dashboard chat
gateway_runtime/cron_verdict.py Blocked: partial-block lead (:210) cron result in dashboard chat
gateway_runtime/subagent_wiring.py Agent x failed / Warning: Result delivery failed (:493-497, #38861) not touched by #38837

Because the heartbeat title stays Heartbeat and the Slack header adds 💓, Slack now shows 💓 *Heartbeat* (before #38837 it showed 💓 *💓 Heartbeat*).

Tests: test files for the kept lines stay at main (test_cron_dedup, test_cron_empty_reply_dedup, test_cron_gateway_integration_llm, test_cron_mirror_backend_model_pin, test_cron_refusal_status, test_cron_slack_delivery, test_cron_stop_interrupt_notice, test_heartbeat_deliver_default, test_heartbeat_prompt_deliver, test_heartbeat_prompt_inject_row, test_slack_gateway, and the matching hunks in test_slack_gateway_coverage_notifications, test_slack_gateway_cron_exec_coverage_delivery, test_slack_backports, test_slack_renderer). Tests that later PRs wrote against the plain words now expect the restored glyphs: test_slack_shared_access.py (⛔ Not authorized., ⛔ Owner-only command.) and test_slack_manifest_command.py (⛔ You are not authorized to use this command.).

Backwards compatibility

Compatible: only message text changes. No key, field, type or reader is changed; the protocol readers from #38861 accept both the glyph and the word.

Removes nothing: the diff changes the wording of Slack and console strings back to their earlier emoji form; no path, record, key, validator or function is removed.

Tests

Updated tests follow the restored strings (see the list above). The Slack handler golden checksums in test_slack_handler_composition_contract_golden.py and test/fixtures/channel_cards/slack_stop_working_goldens.json are restored from before #38837; CI confirms they still match.

Proof: not provable -- copy-only change

Local runs: static gates only (black 26.10.1 gate, subprocess-encoding, isort, flake8, mypy, comment-history, brand, file-line-cap). No local test suite was run; CI is the test runner.

The backend-emoji-lint check is expected to fail until #39210 removes that guard. This PR is rebased after #39210 merges.

Manual verification

N/A — text-only change; the tests assert the restored strings.

Real-machine verification

N/A -- the diff changes message strings only; no behaviour runs differently.

Related Issues

Closes #39225
Partial revert of #38837. Related: #39208, #39210.

Sibling sweep

Swept: git revert -m1 5c68161b70 on main, then every reverted hunk under src/kiro_crew/slack/gateway_runtime/ was checked for a dashboard_state.notify, slot.append, slot.title or returned cron result.
Sibling: src/kiro_crew/slack/gateway_runtime/cron_failure.py -- not affected -- kept plain because the dashboard shows its notify text
Sibling: src/kiro_crew/slack/gateway_runtime/cron_delivery.py -- changed here -- only the Slack header line goes back to the emoji

Pattern harvest

Not generalizable: a one-off owner decision on which surfaces keep emoji, applied to one earlier PR.

Checklist

  • A Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...); PR Hygiene does not count commits
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributions are accepted under the project's Apache-2.0 license.

@CrysisDeu
CrysisDeu requested review from a team and KiroCrewCaptain as code owners November 18, 2026 19:59
@CrysisDeu
CrysisDeu requested a review from buluoray November 18, 2026 19:59
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 18, 2026
@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision 375185893b9ea9f890c3da70626824c0a2938dcf touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of 375185893b9ea9f890c3da70626824c0a2938dcf — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Nothing blocks: this only changes text on Slack and console surfaces, the lines the dashboard shows stay plain as the owner decided, and none of it touches website/src/.

[DESIGN-REVIEWED] 3751858

Description read

[DESCRIPTION-READ] eff7abe0de44cae21280805ddc08aee0aa92e0315674dd6cf49a5e2df8df277f

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ✅ PASS

Premise-level review of 375185893b9ea9f890c3da70626824c0a2938dcf — why this exists and whether the shipped surface is the smallest honest version. Updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

First-Principles-Verdict: PASS

Nothing blocks. This is a scoped revert of #38837 that issue #39225 and the owner's decision ask for. Text the dashboard shows stays plain, and none of these strings is a default mode or a removed capability.

What this change ships

Inventory (6 items) — 6 justified

Intent: Slack and gateway-console readers get their emoji back, and the web UI stays emoji-free. This is a FIX (revert).

  1. Slack messages, Block Kit cards, Home Tab headers and slash/bang refusals show emoji again (⛔, :white_check_mark:, ⏹) — justified
  2. Gateway terminal print lines at boot, exit, update and repair show emoji again — justified
  3. The Slack turn-timing footer gets its colored context-usage dot back (🟢/🟡/🟠/🔴 by ctx_pct) — justified
  4. The Slack heartbeat header reads 💓 *Heartbeat*, without the doubled glyph it had before fix(slack): use plain words instead of emoji in slack messages #38837 — justified
  5. Cron and heartbeat titles, leads and notifications the dashboard shows stay plain — justified
  6. Tests from later PRs (feat(slack): let the owner share Slack access with named people, off by default #30760 shared-access, manifest command) now expect ⛔; SHARED_OWNER_ONLY_TEXT (shared_access.py:196) is untouched — justified

[FIRST-PRINCIPLES-REVIEWED] 3751858

Description read

[DESCRIPTION-READ] fa8a51afcb0f116ba634db06b33e990dd42e03775a631ecfb682b451a016af9d

That sha256 names the PR description this verdict read. Recompute it with .github/scripts/pr-description-capture.sh; if it differs, the description changed after this verdict was formed and any finding drawn from the description is unproven.

@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed 375185893b9ea9f890c3da70626824c0a2938dcf — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] 3751858

Verdict parsed from the review's SHA-scoped output markers for commit 375185893b9ea9f890c3da70626824c0a2938dcf.

False positive or not applicable? A repository writer can comment:
/ai-review override fable 375185893b9ea9f890c3da70626824c0a2938dcf false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of 375185893b9ea9f890c3da70626824c0a2938dcf and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] 3751858

False positive or not applicable? A repository writer can comment:
/ai-review override gpt 375185893b9ea9f890c3da70626824c0a2938dcf false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: action required A blocking check or review needs attention and removed readiness: checking Automated validation is still running labels Nov 18, 2026
@CrysisDeu
CrysisDeu force-pushed the revert/slack-emoji-partial branch from 10b74d6 to ff6ab2d Compare November 18, 2026 21:02
@github-actions github-actions Bot added readiness: checking Automated validation is still running and removed readiness: action required A blocking check or review needs attention labels Nov 18, 2026
Partial revert of #38837 (merge 5c68161). The owner decided only
the web UI drops emoji; Slack messages and the gateway's console lines
keep them.

Reverted: every slack/ file outside gateway_runtime/, and in
gateway_runtime/ the console prints (channel_lifecycle, exit_path,
install_repair, process_entry, service_boot, update_schedule), the
Slack approval card (turn_approvals), the Slack-only cron and
heartbeat headers (cron_delivery, result_egress) and the subagent
status log line (subagent_wiring).

Kept plain, because the dashboard shows them: cron_exec, cron_failure,
cron_fire, cron_turn, cron_verdict, heartbeat_turns, the dashboard
lines of cron_delivery and the heartbeat chat title in result_egress.

Conflicts in events_slash, interactions and renderer keep main's
later code (#38938, #30760, #39112); only #38837's own emoji come
back. Tests that #30760 and #38938 wrote against the plain words now
expect the restored glyphs.

Refs #38837
Closes #39225
@CrysisDeu
CrysisDeu force-pushed the revert/slack-emoji-partial branch from ff6ab2d to 3751858 Compare November 18, 2026 22:06
@CrysisDeu
CrysisDeu merged commit 6437679 into main Nov 18, 2026
95 of 100 checks passed
@CrysisDeu
CrysisDeu deleted the revert/slack-emoji-partial branch November 18, 2026 22:38
@github-actions github-actions Bot removed the readiness: checking Automated validation is still running label Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Slack and console messages should keep their emoji (partly revert #38837)

1 participant