Skip to content

docs(rfc): mark rfc-host-memory-guard accepted - #39290

Open
iamwhatever wants to merge 1 commit into
mainfrom
docs/rfc-host-memory-guard-accepted
Open

iamwhatever wants to merge 1 commit into
mainfrom
docs/rfc-host-memory-guard-accepted

Conversation

@iamwhatever

@iamwhatever iamwhatever commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Problem / Motivation

Goal: Record the host memory guard RFC as accepted, so its implementation PRs can cite an accepted RFC.

docs/request-for-change/rfc-host-memory-guard.md was approved and merged in #39188 (2026-11-18T20:57:55Z) but its front matter and Status line still read draft.

Why it matters

The First Principles lane reads the RFC status, so while it says draft it blocks the two implementation PRs #39270 and #39289.

Not a goal

  • No change to the RFC's design text, only its Status.
  • No code change.
  • No /ai-review override.

What changed (motivation → approach → change)

The repository owner approved this design as proposed in the conductor chat on 2026-11-18: stop internal non-gateway trees, heaviest test trees first, never the gateway; write a log line and a chat message; the conductor is told and actively manages memory and disk with high-level guidance.

The RFC says a maintainer records acceptance on its Status line. This PR proposes that line; the maintainer records it by approving and merging this PR.

Changes, in the same format as #33417:

Backwards compatibility

Compatible: docs-only status change; nothing that works today stops working.

Removes nothing: only the RFC status text changes.

Tests

python3 scripts/docs_lint.py: All documentation checks passed.

Proof: not provable -- docs or config only

Manual verification

N/A — docs-only change; docs_lint.py covers it.

Real-machine verification

N/A -- the diff changes two Markdown files and runs nothing.

Related Issues

Refs #22681. Follows #39188. Unblocks #39270 and #39289.

Checklist

  • A Conventional Commits title (feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...); PR Hygiene does not count commits
  • Existing tests pass and new tests added for new functionality
  • Self-review completed; code follows project style guidelines
  • Documentation updated (if applicable)
  • No secrets, credentials, or internal references in the diff

Contribution License Agreement

Contributed under the project's Apache-2.0 license.

#39188 was approved and merged 2026-11-18 20:57Z but kept status: draft.
The repository owner approved the design as proposed in the conductor
chat on 2026-11-18. Record it as accepted so the implementation PRs
#39270 and #39289 can cite an accepted RFC.

Co-authored-by: Joe Guo <zejiangg@amazon.com>
@iamwhatever
iamwhatever requested review from a team and KiroCrewCaptain as code owners November 18, 2026 21:56
@github-actions github-actions Bot added the readiness: checking Automated validation is still running label Nov 18, 2026
@github-actions

Copy link
Copy Markdown
Contributor

First Principles Review (Opus 5.5) — ⏭️ skipped

Revision a22d72e9df90a4370d8e12bfd4b2bdfadb0bf184 ships no reviewable capability (docs, tests or generated files only), so there is nothing to inventory. Does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

UX Review (Opus 5.5) — ⏭️ skipped

Revision a22d72e9df90a4370d8e12bfd4b2bdfadb0bf184 touches no user-facing surface (no changes under website/ or committed screenshots), so the UX review was skipped. Does not block merge.

@github-actions

Copy link
Copy Markdown
Contributor

Design Review (Opus 5.5) — ✅ PASS

Design-level review of a22d72e9df90a4370d8e12bfd4b2bdfadb0bf184 — updated in place on each push. A BLOCK verdict blocks PR readiness; PASS does not.

Design-Verdict: PASS

Docs-only status flip. Acceptance takes effect only when a maintainer approves and merges this PR, which is what the RFC asks for.

Notes

  • The new Status line cites approval "in the conductor chat", which nobody can open later. Naming the merge review of this PR as the record would give a source that can be checked.

[DESIGN-REVIEWED] a22d72e

Description read

[DESCRIPTION-READ] 8c1b6f15e4df38874aca5ba3a8ccfd2f5adf9ae7033dba4f674f22e535ce69f8

That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with .github/scripts/pr-description-capture.sh over the same inputs; if it differs, the description or that evidence changed after this verdict was formed and any finding drawn from either is unproven.

@github-actions

Copy link
Copy Markdown
Contributor

Opus 5.5 Review — ✅ no blocking findings

Reviewed a22d72e9df90a4370d8e12bfd4b2bdfadb0bf184 — this comment is updated in place on each push.

Review details

No findings.

[OPUS-REVIEWED] a22d72e

Verdict parsed from the review's SHA-scoped output markers for commit a22d72e9df90a4370d8e12bfd4b2bdfadb0bf184.

False positive or not applicable? A repository writer can comment:
/ai-review override fable a22d72e9df90a4370d8e12bfd4b2bdfadb0bf184 false-positive: <reason, 20 to 500 characters>

@github-actions

github-actions Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

GPT 6.1 Review — ✅ no blocking findings

GPT 6.1 completed its review of a22d72e9df90a4370d8e12bfd4b2bdfadb0bf184 and found no blocking issues.

This comment is updated in place on each push.

Review details

No findings.
[GPT-REVIEWED] a22d72e

False positive or not applicable? A repository writer can comment:
/ai-review override gpt a22d72e9df90a4370d8e12bfd4b2bdfadb0bf184 false-positive: <reason, 20 to 500 characters>

@github-actions github-actions Bot added readiness: passed Eligible automated validation passed for the current revision and removed readiness: checking Automated validation is still running labels Nov 18, 2026
@KiroCrewCaptain

Copy link
Copy Markdown
Collaborator

This PR is the step that accepts the host memory guard RFC. The RFC names the repository owner as the decider, so that decision stays with the owner or a human maintainer. An automated approval should not record it. The owner or a maintainer will post the decision here.

What the review checked on this head:

The status flip is small and consistent: the front matter, the Status line and the index row all move together. The body says plainly that the merge review is what records the decision.

Optional notes for when a human approves:

  • Status line (rfc-host-memory-guard.md:16-18) and README row 34: cite that human approval, or the owner's restating comment, as the record of acceptance, as the rfc-bot-subfolder-person-delete row does. Describe docs(rfc): host memory guard stops the heaviest non-gateway tree, and the conductor keeps the host healthy #39188 as "merged as draft". Drop the private chat citation, because nobody can open it later.
  • §0 (rfc-host-memory-guard.md:52-53) still asks the owner to restate the decision on the pull request. Once that happens, link it there or remove the sentence, so the document does not contradict its own accepted status.

@KiroCrewCaptain

Copy link
Copy Markdown
Collaborator

Code change approver recommendation: A person should decide

Why: the decider estimates a 10% chance that this change introduces a defect, within the 12% limit for approving on its own, but it is held at tier 2: design-doc-gate: D.

Docs-only change that moves rfc-host-memory-guard from draft to accepted in its front matter, its Status line and the index row; the design text is unchanged. The repo's rules (request-for-change/README.md:313-318, ci-and-reviews.md:3486-3489) make a standalone status-flip PR a proposal that takes effect when a maintainer merges it, and the First Principles lane reads status from the base commit, so this PR cannot unblock its own implementation PRs. The design it accepts lets Crew stop running process trees without the user opting in, and the limits are sound: only processes started from Crew's sessions, with the gateway, session hosts, MCP servers and agent runtimes excluded; processes re-identified before signalling; off when agent.resource_critical_gb is 0; Linux only; and required tests cover these. No code, config, limits or stored data change. CI and all review lanes pass; the one failed check (Publish readiness signal) hit GitHub API rate limits. Remaining points are about wording and where the approval is recorded, and do not block.

Tier: 2, held for a person: design-doc-gate: D.

An automated recommendation, not a review: a maintainer still decides. It approves on its own only when the estimated chance of a defect is at most 12% and the change has at most 400 changed lines. Decider v3c (217fe607) · commit a22d72e9df · 9 changed lines. If this recommendation is wrong, reply here: replies are how the approver is evaluated.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

readiness: passed Eligible automated validation passed for the current revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants