Repository navigation
fix: 0.13 backport, two Windows P0 gateway fixes (#37927, #38025) - #39397
Conversation
UX Review (Opus 5.5) — ✅ PASSUX-level review of UX-Verdict: PASS Nothing to check. The diff adds or changes no user-visible control or string: the Electron changes only touch log lines and how the free port is detected, and the Feishu change only moves an import off the event loop. [UX-REVIEWED] b5698d5 Description read[DESCRIPTION-READ] ac0a17ff4a84522bc62e8c46345547a4e0f50050fed3982d966f3a90f0f4400d That sha256 names everything this verdict read: the PR description, plus the 3 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Nothing blocks: these are two clean cherry-picks of fixes already on main, and their Windows branches are covered by node tests that inject the platform. Notes
[DESIGN-REVIEWED] b5698d5 Description read[DESCRIPTION-READ] 245cb658209173b02bf90dedd7f060171f4456804f34247de9f259f8daa40291 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
First Principles Review (Opus 5.5) — ✅ PASSPremise-level review of First-Principles-Verdict: PASS This is a clean backport of two P0 Windows fixes that are already on main. Every item fixes the mechanism, not a symptom. The description leaves out two items, and neither carries a premise risk. Not checked: whether main's #37927 and #38025 carry the Feishu allow-list re-seed and the Notes
What this change shipsInventory (5 items) — 3 justifiedIntent: give 0.13 Windows users a gateway that starts with Feishu enabled and when netstat times out on a free port. FIX.
[FIRST-PRINCIPLES-REVIEWED] b5698d5 Description read[DESCRIPTION-READ] be5e176404dfdff7913e71110a15beee3da8dabe3e5b2e3514738083e455b593 That sha256 names the PR description this verdict read. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Problem / Motivation
Goal: 0.13 Windows users get two P0 fixes that main merged after the 0.13 fork.
Neither fix is on release/0.13.0, and neither was in #39387.
Why it matters
Both bugs leave a Windows install with no working gateway. 0.13 is the next stable line.
Not a goal
Any other fix. The open P0 #38811 has no merged fix on main yet.
What changed (motivation → approach → change)
Two
git cherry-pick -xcommits on release/0.13.0 (2835f547d0), in main's merge order. Both applied without a conflict. Each keeps its original author and main's message, with thecherry picked fromline.feishu/client.pyandfeishu/gateway.pyimport lark-oapi off the event loop.docs/guides/windows-install.md.Backwards compatibility
Compatible: both picks are code already on main.
Removes nothing: neither pick hides, deletes or tightens anything.
Tests
On this branch:
test/test_feishu_gateway.py: 20 passed.node --testongateway-stop.test.js,windows-port.test.jsandwindows-recovery-port-probe.test.js: 105 passed, 1 skipped, 0 failed.Proof: not provable -- other: a backport of fixes whose proof ran on their own main PRs
Manual verification
N/A: each fix was verified on its own main PR. This PR only carries them.
Related Issues
Part of #38021
Part of #37902
Sibling sweep
Siblings: none -- a backport; each fix's sweep is recorded on its own main PR
Pattern harvest
Not generalizable: a backport; the patterns are recorded on each main PR
Checklist