Repository navigation
docs: sync module specs (list B) with main - #39914
Conversation
UX Review (Opus 5.5) — ⏭️ skippedRevision |
First Principles Review (Opus 5.5) — ⏭️ skippedRevision |
Design Review (Opus 5.5) — ✅ PASSDesign-level review of Design-Verdict: PASS Docs-only sync of the module specs to the code on Notes
[DESIGN-REVIEWED] 6e35a00 Description read[DESCRIPTION-READ] d02e163e775a64efc720d39e5d85c32321d4924e8c96103e960b0f2c7e181565 That sha256 names everything this verdict read: the PR description, plus the 1 evidence file(s) the workflow collected from it and handed this review. It covers that evidence because the media strip replaces every attachment URL with the same placeholder, so an edit swapping one attachment for another would leave the description's captured text identical while what this review judged changed. Recompute it with |
Opus 5.5 Review — ✅ no blocking findingsReviewed Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
GPT 6.1 Review — ✅ no blocking findingsGPT 6.1 completed its review of This comment is updated in place on each push. Review detailsNo findings. False positive or not applicable? A repository writer can comment: |
Drop PR/issue provenance and history prose, fix claims that drifted from code.
Drop PR/issue provenance and history prose, fix claims that drifted from code.
Drop PR/issue provenance and history prose, fix claims that drifted from code.
Drop PR/issue provenance and history prose, fix claims that drifted from code.
Drop PR/issue provenance and history prose, fix claims that drifted from code.
Drop PR/issue provenance and history prose, fix claims that drifted from code.
Drop PR/issue provenance and history prose, fix claims that drifted from code.
…st spec with main Drop PR/issue provenance and history prose, fix claims that drifted from code.
Drop PR/issue provenance and history prose, fix claims that drifted from code.
Drop PR/issue provenance and history prose, fix claims that drifted from code.
Drop PR/issue provenance and history prose, fix claims that drifted from code.
Drop PR/issue provenance and history prose, fix claims that drifted from code.
… spec with main Drop PR/issue provenance and history prose, fix claims that drifted from code.
Drop PR/issue provenance and history prose, fix claims that drifted from code.
Drop PR/issue provenance and history prose, fix claims that drifted from code.
Drop PR/issue provenance and history prose, fix claims that drifted from code.
Drop PR/issue provenance and history prose, fix claims that drifted from code.
Drop PR/issue provenance and history prose, fix names and claims that drifted from code.
Drop PR/issue provenance and history prose, fix names and claims that drifted from code.
Drop PR/issue provenance and history prose, fix names and claims that drifted from code.
Drop PR/issue provenance and history prose, fix names and claims that drifted from code.
Drop PR/issue provenance and history prose, fix names and claims that drifted from code.
Drop PR/issue provenance and history prose, fix names and claims that drifted from code.
Drop PR/issue provenance and history prose, fix names and claims that drifted from code.
Drop PR/issue provenance and history prose, fix names and claims that drifted from code.
Drop PR/issue provenance and history prose, fix names and claims that drifted from code.
Drop PR/issue provenance and history prose, fix names and claims that drifted from code.
1eb3b95 to
6e35a00
Compare
KiroCrewCaptain
left a comment
There was a problem hiding this comment.
I reviewed head 6e35a00, which only changes prose in module specs. I checked the claims it adds or rewrites against the code at the same commit: the sandbox tightening recycle path, the IMDS expansion helper, the moved chat_turn segment and recipient helpers, the write-tier leaves, the shell wrapper rows, the grant-row order in the gate tiers, the dashboard middleware chain order, the update error codes and the SEL forward warning. All of them match the code, and the identifiers it removes no longer exist in the source tree. The docs lint passes on this head, and with no code, test or config change there is no behavioural risk that blocks merging.
Problem / Motivation
Goal: Every module spec in list B of the round-1b sweep (49 files under
docs/system-specs/modules/) states what the code onmaindoes today.Many of these specs name merged PRs and closed issues as provenance, carry history prose ("used to", "this PR", "the fix"), and in places describe behaviour, middleware order or opt-outs that the code no longer matches.
Why it matters
These specs are what agents and contributors read before they change the code. A wrong layer order, a stale opt-out list or a closed issue named as an open gap sends a reader to the wrong place or makes them re-solve a solved problem.
Not a goal
modules/README.md, the list-A specs,docs/decisions/, or code.examples/workflows/01_review_changes.pyis left to docs: sync module specs (list A) with main #39898, which carries the same change to all four example files.What changed (motivation → approach → change)
Approach: per file, mechanical checks (backticked identifiers against the code tree,
module.attragainst the module, cited test names against the test files, config defaults againstconfig-baseline.json, every#NNNreference classified by GitHub type and state), then a read of the prose against the code it describes. Merged PRs and closed issues named as provenance are dropped; an open issue that tracks a real gap stays; a closed issue named as an open gap is checked in code and the sentence states the current behaviour.Files changed, by area (one line on what was wrong):
Every file below also loses merged-PR / closed-issue provenance tags and history prose ("used to", "this PR", "the fix", "as before this change"); open issues that track a real gap stay.
Security and governance
security.md:_KIRO_CLI_WRITE_TIER_LEAVEScontents; no path matcher inis_sensitive_bash_command;crons.jsonis sandbox-visible andcron-historymasked;_cut_segment/_redact_segment/_redact_deltalive inchat_turn/; IMDS expansion check; aws s3 patterns;is_denied(..., waived); mirror/all catalog row;DENY_REASON_MATCH_PREFIX; extra_WRAPPERS;selforward logs a warning; no frontendEXFIL_B64_REand no_scan_span_urls;spec-builtin-grantis the fifth grant row; a sandbox tightening ends sessions at the next claim/turn boundary; retired-feature blocks restated in present tense.governance.md: adds theapp-own-toolsgrant; closed issues MCP Apps: route app-originated tool calls through the governance ceiling (M1 deferral) #418, governance: SCOPE_CATALOG capability for theme-pack persona/L2 activation #312, Add an agent_backend governance scope to bound which ACP harness a fleet may select #6622 restated as current behaviour.memory-skills-hooks.md: GATE_TIERS table gainsspec-builtin-grantandbatch-guard-grant;SessionSlotis_ChatSlot.CLI, sessions and Crew
cli.md:POST /api/updateonly arms an update; its error codes arenot_git_checkout,arm_check_failed,update_check_pending,no_update(dirty_tree/checkout_divergedare gone); no caller builds the frontend on update.session.md: opener inject kinds, steer states withretracted,deliver_noteinchat_api/slot_note.py,build_dm_session_key(..., chat_type),crew_filing._frame_parents; closed tracking issues restated as open gaps checked in code.session-control.md: every session-control route sits behind_require_internal.crew-mode.md: nolocal_persistence: pendingfield exists; a failed history write answers 503history_unavailable.agent-host-contract.md: a server is withheld with a logged warning (acp/client_mcp_array.py), not anarrowed_control_planetoken.metrics.md: telemetry config table lists all 16 fields (adds the traces, beacon andplan_alert_pctskeys);_persist_abnormal_turn_usagelives inchat_turn/turn_stats.py.monitor-architecture.md: names the work-ledger probe's host wakes (posture change, same-level fall, worker growth); wake board history rewritten.Messaging and channels
messaging.md:get_signing_key_from_jwt; recipient helpers live inchat_turn/recipient; ReceiptQueue still keys onsession_key(stated as a known gap).channel-history.md: per-message 300-character cap.Dashboard, auth and connections
dashboard-token-auth.md: middleware chain addsapp_web_origin,relay_origin,redaction_audience,team_configand_change_card_hook.connections.md:l0_probeandl1_smokehonour the proxyhttp_proxy.resolve_proxypicks.onboarding-import.md: first run has two chapters (Import setup, Customize tour); no Privacy chapter.prompt-optimizer.md: the relay Crew chat window and the Bot composer also turn the optimizer off.kas-auth.md,command-bar.md,computer-use.md,cloud.md,aws-control.md: provenance and history only; closed tracking issues checked in code (no Fargate sweep caller, no producer-held archive body).adaptive-concurrency.md,connector-capability-manifest.md,harness-plugin-mapping.md,mcp-apps.md,mcp-gateway-daemon-lifecycle.md,stt-streaming.md: history prose only.Checked and left unchanged (mechanical checks, and a full read where noted in the sweep report): the remaining list-B specs.
Backwards compatibility
Compatible: docs only.
Removes nothing: only doc prose changes; no code, key or path is removed.
Tests
Proof: not provable -- docs or config only
./scripts/docs-lint.shexits 0 on the head.Manual verification
N/A — docs only; each changed claim was checked against the cited source on
main.Real-machine verification
N/A -- docs only, the diff runs nothing.
Related Issues
Round-1b docs sweep, module specs list B.
Checklist
feat|fix|docs|style|refactor|perf|test|chore|ci|build|revert: ...); PR Hygiene does not count commitsContribution License Agreement
Contributed under the project's Apache-2.0 license.