Repository navigation
build(deps): bump step-security/harden-runner from 2.20.1 to 2.21.0 - #4718
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.20.1 to 2.21.0. - [Release notes](https://github.com/step-security/harden-runner/releases) - [Commits](step-security/harden-runner@b09bb98...05e3151) --- updated-dependencies: - dependency-name: step-security/harden-runner dependency-version: 2.21.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
9d815ea to
8668763
Compare
The self-heal sweep rescues a `pending` verdict on age and a `failure` verdict on later check evidence. Two freeze modes fell outside both tests and had no other recovery path, because the sweep is the only thing that recomputes an unchanged commit once its `workflow_run` events are spent. An UNPUBLISHED verdict was the live one. `pr-readiness.yml` deliberately does not retry its status POST -- a retry can overwrite a concurrent run's newer verdict -- and instead instructs a human to re-run the workflow. When that POST fails the SHA carries no readiness status at all, so there is no `pending` to age out, and the sweep skipped the PR on the assumption that its own run was still coming. The one case the publisher delegates to a re-run was the one case nothing re-ran. PR #2783 proves it: both readiness runs for f014465 failed on `gh: HTTP 503` from the POST on 2026-08-17, and eight days later the PR was still MERGEABLE with no readiness verdict of any kind. Today's #5282 hit the same POST with a 502 and survived only because an unrelated later event happened to republish. Rescued now on the PR's own last-activity age, which a push bumps, so the grace window restarts on every new revision and a genuinely queueing run is left alone. A STALE GREEN was the unsafe-direction gap. The re-run mechanism behind mode 2 is direction-blind: a job re-run that flips a lane red after a green verdict emits no `workflow_run: completed` either, leaving the required aggregate green over a now-red revision -- which PERMITS a merge, where a stale red only blocks one. The `*)` arm skipped it as "success needs no rescue". `success` and `error` now share mode 2's evidence test, narrowed to failure-class conclusions: housekeeping check-runs (`Strip stale workflow-change override`, `Fork workflow-change guard`) legitimately complete days after a verdict, so an unnarrowed "any check completed later" test would re-fire most green PRs every sweep while proving nothing. No live poisoned green was found in the current 250 open PRs -- the one candidate, #4272, turned out to be exactly that housekeeping false positive -- so this arm closes the mechanism, not an observed incident. `--paginate` WITHOUT `--slurp` was a latent defect in the pre-existing `failure` arm, found in review and fixed in both arms. gh concatenates one JSON document per page and jq evaluates each separately, so `max` emits one timestamp PER PAGE; `date -d` then rejects the multi-line string, the epoch reads 0, and the PR is skipped. That silently exempted every PR with more than 100 check-runs, which on this repo is any PR whose lanes have been re-run -- #4718 alone carries ~90. Verified against the live API: three pages produced three `max` lines unslurped and one slurped. The statuses read is now checked for FAILURE before its filter runs. A 503 and a genuinely absent status both yield empty jq output, and the new unpublished arm dispatches on the latter -- so without this, transient GitHub trouble would re-fire arbitrary old PRs every 15 minutes, on a shared token budget, which is the same exhaustion that causes the missing verdict in the first place. `--limit 300` on the open-PR listing is raised to 900 with a loud warning when the ceiling is hit, here and in the two sibling sweeps that share the defect (fork-pr-label.yml, pr-merge-conflict-label.yml, both found in review). `gh pr list` returns newest-first and truncates silently, so a ceiling near the real count drops the OLDEST PRs -- precisely the frozen or unlabelled ones each sweep exists to catch. At 250 open the old value was already at 83% of its ceiling. Same truncation class as the `pr_status_report` limit bug. `gh label list --limit` in those files counts labels, not PRs, and is untouched. The unpublished case is carried as a sentinel `state` rather than an early record write, so it reuses the single staleness comparison and the single stale-file record writer instead of restating either. GitHub's status states are error/failure/pending/success, so the sentinel cannot collide. Not addressed here, because the fix is a policy decision rather than a defect: a required lane that did not exist when the head SHA was pushed can never be satisfied, and a recompute re-derives `not started` forever. #3089 and #3037 are frozen on First Principles Review, which became blocking in #4253 but only exists from #3436. Auto-skipping the lane would let an unreviewed PR pass, so it wants a rebase or a deliberate eligibility rule. Filed as #5957. Test plan: - test/test_pr_readiness_sweep.py: 31 passed (18 pre-existing, 13 added). - unpublished: rescued past the window, left alone inside it, respects MAX_DISPATCH, fails closed on an unparseable timestamp, still reads as unpublished when only a foreign-context status exists, and is NOT triggered by a failed statuses read. - stale green: rescued for all six failure-class conclusions, never rescued by a later pass, self-terminating on republish, untouched with no evidence. - pagination: evidence on a SECOND page is found by both arms, which is what an unslurped `--paginate` cannot do. - truncation: the ceiling is a variable, and a hit is reported. - the context-isolation test now proves a foreign status cannot DRIVE the decision, rather than relying on the absent-status shape it used to assert. - the gh stub models `--paginate --slurp` (outer array of pages) and can fail a statuses read on demand, so both fixes are exercised rather than assumed. - Revert-verify: undoing each of the seven properties independently (unpublished arm, green arm, ceiling, failure-class narrowing, slurp on each arm, statuses transport guard) fails a named test; tree restored to 31 green. - test_workflows_conformance / test_workflow_permissions / test_github_workflow_security / test_pr_quality_gates / test_ai_review_workflows + the sweep suite: 289 passed. - check_black_formatting.py and flake8 clean; all three workflows parse as YAML. - test_pr_readiness_publish.py has 4 pre-existing failures on this host (local jq rejects `label` as an identifier); identical on pristine main, untouched here.
…#5955) The self-heal sweep rescues a `pending` verdict on age and a `failure` verdict on later check evidence. Two freeze modes fell outside both tests and had no other recovery path, because the sweep is the only thing that recomputes an unchanged commit once its `workflow_run` events are spent. An UNPUBLISHED verdict was the live one. `pr-readiness.yml` deliberately does not retry its status POST -- a retry can overwrite a concurrent run's newer verdict -- and instead instructs a human to re-run the workflow. When that POST fails the SHA carries no readiness status at all, so there is no `pending` to age out, and the sweep skipped the PR on the assumption that its own run was still coming. The one case the publisher delegates to a re-run was the one case nothing re-ran. PR #2783 proves it: both readiness runs for f014465 failed on `gh: HTTP 503` from the POST on 2026-08-17, and eight days later the PR was still MERGEABLE with no readiness verdict of any kind. Today's #5282 hit the same POST with a 502 and survived only because an unrelated later event happened to republish. Rescued now on the PR's own last-activity age, which a push bumps, so the grace window restarts on every new revision and a genuinely queueing run is left alone. A STALE GREEN was the unsafe-direction gap. The re-run mechanism behind mode 2 is direction-blind: a job re-run that flips a lane red after a green verdict emits no `workflow_run: completed` either, leaving the required aggregate green over a now-red revision -- which PERMITS a merge, where a stale red only blocks one. The `*)` arm skipped it as "success needs no rescue". `success` and `error` now share mode 2's evidence test, narrowed to failure-class conclusions: housekeeping check-runs (`Strip stale workflow-change override`, `Fork workflow-change guard`) legitimately complete days after a verdict, so an unnarrowed "any check completed later" test would re-fire most green PRs every sweep while proving nothing. No live poisoned green was found in the current 250 open PRs -- the one candidate, #4272, turned out to be exactly that housekeeping false positive -- so this arm closes the mechanism, not an observed incident. `--paginate` WITHOUT `--slurp` was a latent defect in the pre-existing `failure` arm, found in review and fixed in both arms. gh concatenates one JSON document per page and jq evaluates each separately, so `max` emits one timestamp PER PAGE; `date -d` then rejects the multi-line string, the epoch reads 0, and the PR is skipped. That silently exempted every PR with more than 100 check-runs, which on this repo is any PR whose lanes have been re-run -- #4718 alone carries ~90. Verified against the live API: three pages produced three `max` lines unslurped and one slurped. The statuses read is now checked for FAILURE before its filter runs. A 503 and a genuinely absent status both yield empty jq output, and the new unpublished arm dispatches on the latter -- so without this, transient GitHub trouble would re-fire arbitrary old PRs every 15 minutes, on a shared token budget, which is the same exhaustion that causes the missing verdict in the first place. `--limit 300` on the open-PR listing is raised to 900 with a loud warning when the ceiling is hit, here and in the two sibling sweeps that share the defect (fork-pr-label.yml, pr-merge-conflict-label.yml, both found in review). `gh pr list` returns newest-first and truncates silently, so a ceiling near the real count drops the OLDEST PRs -- precisely the frozen or unlabelled ones each sweep exists to catch. At 250 open the old value was already at 83% of its ceiling. Same truncation class as the `pr_status_report` limit bug. `gh label list --limit` in those files counts labels, not PRs, and is untouched. The unpublished case is carried as a sentinel `state` rather than an early record write, so it reuses the single staleness comparison and the single stale-file record writer instead of restating either. GitHub's status states are error/failure/pending/success, so the sentinel cannot collide. Not addressed here, because the fix is a policy decision rather than a defect: a required lane that did not exist when the head SHA was pushed can never be satisfied, and a recompute re-derives `not started` forever. #3089 and #3037 are frozen on First Principles Review, which became blocking in #4253 but only exists from #3436. Auto-skipping the lane would let an unreviewed PR pass, so it wants a rebase or a deliberate eligibility rule. Filed as #5957. Test plan: - test/test_pr_readiness_sweep.py: 31 passed (18 pre-existing, 13 added). - unpublished: rescued past the window, left alone inside it, respects MAX_DISPATCH, fails closed on an unparseable timestamp, still reads as unpublished when only a foreign-context status exists, and is NOT triggered by a failed statuses read. - stale green: rescued for all six failure-class conclusions, never rescued by a later pass, self-terminating on republish, untouched with no evidence. - pagination: evidence on a SECOND page is found by both arms, which is what an unslurped `--paginate` cannot do. - truncation: the ceiling is a variable, and a hit is reported. - the context-isolation test now proves a foreign status cannot DRIVE the decision, rather than relying on the absent-status shape it used to assert. - the gh stub models `--paginate --slurp` (outer array of pages) and can fail a statuses read on demand, so both fixes are exercised rather than assumed. - Revert-verify: undoing each of the seven properties independently (unpublished arm, green arm, ceiling, failure-class narrowing, slurp on each arm, statuses transport guard) fails a named test; tree restored to 31 green. - test_workflows_conformance / test_workflow_permissions / test_github_workflow_security / test_pr_quality_gates / test_ai_review_workflows + the sweep suite: 289 passed. - check_black_formatting.py and flake8 clean; all three workflows parse as YAML. - test_pr_readiness_publish.py has 4 pre-existing failures on this host (local jq rejects `label` as an identifier); identical on pristine main, untouched here. Co-authored-by: Joe Guo <zejiangg@amazon.com>
|
🤖 Kiro Crew [operator: NicholasRBowers#a942f9ca]: This PR has been inactive for 7+ days. I reviewed the blockers but they require your input:
When you've addressed these, the pipeline will re-assess on its next cycle. |
Open PR relationship auditThis is a consolidated, point-in-time code-level audit note. It compares complete merge-base diffs and current/merged code; it does not treat a shared topic as duplication or partial coverage as completion. DUPLICATE: closing this PRClose 4718 in favor of the newer PR #8179. Current main still pins harden-runner v2.20.1 in all five fork-review workflows - set by merged PR #3321, whose merge commit 62f21ba is exactly this PR's merge base - so nothing merged has covered the bump and 4718 is not superseded by shipped code. It is superseded by an open PR: PR #8179 performs the identical five-line edit from the same 2.20.1 baseline to the strictly newer 2.21.1, so landing 4718 buys one intermediate release and forces a rebase plus a second maintainer review of a security-sensitive workflow surface. The two cannot both apply. 4718 is still cleanly rebaseable (its anchor line is byte-identical on current main, only shifted by three lines), so REBASE is technically available but pointless while 8179 exists. Operational note: auto-merge (squash) is enabled on 4718 by bolichen97, so that must be disabled before closing, or the PR can merge on its own.
The audit recommendation is to close this PR; the relationship target above is the implementation to retain or the merged implementation that already covers it. No PR, Issue, label, branch, or review state was changed by the relationship-note portion of this audit. |
Pull request was closed
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps step-security/harden-runner from 2.20.1 to 2.21.0.
Release notes
Sourced from step-security/harden-runner's releases.
Commits
05e3151Merge pull request #684 from step-security/rc-420f37afafix: ignore denied-endpoints on non-enterprise tier93b58eefix: resolve cache host read-first and never downgrade egress policye7399ddfix: align deny-list mode detection with agent and log when both endpoint inp...c16689ftest: add denied_endpoints to Configuration fixtures and cover deny-list merge40b99cfMerge pull request #682 from rohan-stepsecurity/rp/feat/codebuild-self-v2fedec02Merge branch 'rc-42' into rp/feat/codebuild-self-v25361fb1feat: add build artifacts286474ffeat: Support Bravo agent install on CodeBuild runners051ec05Merge pull request #683 from h0x0er/jatin/deny-list