Repository navigation
feat: AgentCore Workload Gateway integration - #6598
kyleseaman wants to merge 2 commits into
Conversation
Design Review (Fable 5) — 🟡 CONCERNSDesign-level review of Design-Verdict: CONCERNS Sound proxy design, but a mutating control-plane route ships inside a PR whose description says sync is deferred to PR 6. Watch
[DESIGN-REVIEWED] 164d6e1 |
First Principles Review (Fable 5) — 🟡 CONCERNSPremise-level review of All evidence is in: contract, intent file, full patch, and repository greps for consumer counts ( First-Principles-Verdict: CONCERNS The SigV4 proxy and session-only inject are cause-level and earn their place; the preferred-port machinery and the /verify twin route do not. What this change shipsIntent: let kiro-cli call an IAM-inbound AgentCore Gateway without the unsigned hostname or a bearer ever reaching the agent. ADDITION (stack slice 4/6).
Watch
Subtractions
[FIRST-PRINCIPLES-REVIEWED] 164d6e1 |
GPT 5.6 Review — ✅ no blocking findingsGPT 5.6 completed its review of This comment is updated in place on each push. Review detailsFINDING -- src/kiro_crew/platform/agentcore_gateway.py:134 -- CloudFormation configures AgentCore via environment variables, so False positive or not applicable? A repository writer can comment: |
Opus 4.8 Review — ✅ no blocking findingsReviewed Review detailsBoth candidates are self-admittedly low-confidence and I could not re-derive a concrete input, call path, and observable wrong outcome for either. Candidate 1 ( Candidate 2 ( Step 2: I examined the security-load-bearing additions — the SigV4 proxy auth token (HMAC-bound to session_key + agent, so a restricted child cannot forge a broader agent), the post-body-read No findings. [OPUS-REVIEWED] 164d6e1 Verdict parsed from the review's SHA-scoped output markers for commit False positive or not applicable? A repository writer can comment: |
2c2c666 to
29e0fbc
Compare
10efeed to
bf6e726
Compare
UX Review (Fable 5) — ⏭️ skippedRevision |
29e0fbc to
e36252f
Compare
bf6e726 to
c0d6f70
Compare
e36252f to
18d6580
Compare
c0d6f70 to
7280f24
Compare
41b841a to
bbf8418
Compare
5e7df88 to
c5a236f
Compare
bbf8418 to
d3af616
Compare
c5a236f to
77b382b
Compare
77b382b to
485b967
Compare
d3af616 to
be3b14d
Compare
485b967 to
25da68e
Compare
Workload inbound is IAM. kiro-cli cannot sign InvokeGateway, so the adapter rewrites gateway_mcp_spec onto a 127.0.0.1 listener and session/new injects that live loopback URL. The unsigned hostname never reaches the agent file. Login sidecars and consent stay out.
|
Retrigger pull_request review workflows on 7a15a62 (synchronize dropped after rebase; CI/Build stay ineligible on a stacked base). |
Loopback is same-host, so each hop carries an HMAC-bound session token. Request-time signing requires the calling session's profile to still permit AgentCore and the composed posture to be workload — login uses JWT inbound, not instance IAM.
PR 4 of 6 in the AgentCore stack. Workload inbound is IAM. kiro-cli cannot SigV4-sign
InvokeGateway, so the unsigned Gateway hostname must never reach the agent file orsession/new. This is the focused security-review slice.A wiring gap here is an unsigned Invoke to a customer Gateway, or a bearer stuffed into
~/.kiro/agents/kirocrew.json. That review should not also cover OAuth consent or Settings UI.What changed
127.0.0.1reverse proxy (preferred port18765). HMAC-bound session token (X-Kirocrew-Proxy-Auth+X-Kirocrew-Proxy-Session); hop-by-hop headers are stripped before AWS.*.gateway.bedrock-agentcore.<region>.amazonaws.com.agentcore_posture == "workload"(not any AgentCore posture) and evaluates the calling session's profile, not the host profile.gateway_mcp_spec()returns the proxy listen URL, orNoneif the proxy cannot start.session/newinjects only that loopback URL.AcpRuntime;_mcp_servers_for_sessioninjects the per-session Gateway alongside pooled MCP servers (not onlyAcpClient)./api/agentcore/gateway{,/verify,/sync}) lazy-importagentcore_inspecton first request so gateway boot does not load the optional AgentCore subsystem.Not in this PR: login inbound sidecars, OAuth consent, Settings identity UI. Dashboard Gateway sync stays in PR 6 and is operator-gated there.
Stacked on #6597.
Tests
test_agentcore_sigv4.py: region parse, HMAC bind, upstream pin,test_proxy_recheck_refuses_login_posture,test_proxy_recheck_uses_calling_session_profiletest_agentcore_gateway_inject.py: sanitize drops headers; session injects loopback and refuses unsigned httpstest_agentcore_inspect.py: snapshot codes, owner-only handlersRelated
Stack after #6597. Supersedes the Gateway/SigV4/inspect slice of #6387.