Skip to content

chore(quest): small std gaps - #111

Merged
kixelated merged 2 commits into
mainfrom
quest/ts-std-gaps
Oct 27, 2026
Merged

kixelated merged 2 commits into
mainfrom
quest/ts-std-gaps

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

A follow-up quest the maintainer chose from #106's report: bool::then/then_some, iter::successors, usize::from(bool), and None.ok_or narrowing (from #87), which discovery.rs's parent walk needs.

Consumer: moq, through the translator's census.

Public API: none.

(written by Opus 5.5)

🤖 Generated with Claude Code

https://claude.ai/code/session_0115AT2ue6x9cT5e5J9SZtCn

From #87's and #106's reports.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0115AT2ue6x9cT5e5J9SZtCn
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T06:11:35.848260Z 4632135 New commits
🔒 Security Review ✅ Completed 2026-10-27T06:12:01.606661Z 4632135 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b5bf77c923

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread quest/m2/ts-std-gaps.md
Comment on lines +15 to +16
- `then` calls its closure only when true, and `successors` calls its closure only for
the next item it yields; cover both laziness points in the differential tests.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Specify Rust's actual successor evaluation timing

When iteration stops early, successors still evaluates a successor that is never yielded: each successful next() invokes the closure on the current item before returning that item. For example, native Rust's successors(Some(0), |n| { calls += 1; Some(n + 1) }).take(1) increments calls once despite yielding only the initial value. Requiring closure calls only for items actually yielded would therefore produce incorrect side effects and panic timing. Amend the plan and differential tests to preserve this eager one-item lookahead, as required by the repository's exact-semantics rule.

AGENTS.md reference: AGENTS.md:L15-L15

Useful? React with 👍 / 👎.

@kixelated kixelated left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review by review (OpenAI)
Reviewed commit: b5bf77c

The focused, consumer-driven quest is a sensible direction; no implementation complexity is introduced here. One existing finding remains actionable: successor evaluation timing in quest/m2/ts-std-gaps.md:15-16. Each successful next() computes the successor before returning the current item, even if that successor is never consumed. Correct the plan and cover early termination, side effects and panic timing rather than requiring calls only for yielded successors. Referencing the existing finding instead of adding a duplicate inline comment.

No additional actionable issues found. then_some should also be distinguished from lazy then in the eventual differential coverage. Verification: reviewed the two-file documentation change and repository guidance only; no implementation or tests were run.

(Written by OpenAI)

@kixelated
kixelated merged commit 53506aa into main Oct 27, 2026
1 check passed
@kixelated
kixelated deleted the quest/ts-std-gaps branch October 27, 2026 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant