Repository navigation
chore(quest): small std gaps #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| # [S] Small std gaps | ||
|
|
||
| ## Goal | ||
|
|
||
| rust2-ts translates `bool::then`, `bool::then_some`, `iter::successors`, and | ||
| `usize::from(bool)`, and `None.ok_or(e)` passes `tsc` where TypeScript narrowed the | ||
| value to `undefined`, so `discovery.rs`'s parent walk translates, proven by differential | ||
| tests against native Rust. | ||
|
|
||
| ## Plan | ||
|
|
||
| Found by [#87](https://github.com/kixelated/rust2/pull/87) and | ||
| [#106](https://github.com/kixelated/rust2/pull/106) on 2026-10-27. | ||
|
|
||
| - `then` calls its closure only when true, and `successors` calls its closure only for | ||
| the next item it yields; cover both laziness points in the differential tests. | ||
| - Report moq-net's census before and after. | ||
|
|
||
| Public API: the translator's output. | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When iteration stops early,
successorsstill evaluates a successor that is never yielded: each successfulnext()invokes the closure on the current item before returning that item. For example, native Rust'ssuccessors(Some(0), |n| { calls += 1; Some(n + 1) }).take(1)incrementscallsonce despite yielding only the initial value. Requiring closure calls only for items actually yielded would therefore produce incorrect side effects and panic timing. Amend the plan and differential tests to preserve this eager one-item lookahead, as required by the repository's exact-semantics rule.AGENTS.md reference: AGENTS.md:L15-L15
Useful? React with 👍 / 👎.