Repository navigation
chore(ffi): the exporter pins moq on its own - #736
Conversation
Quest-Claim: 2affd1073e87f27c
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
The exporter's `moq_rev` read rust2-ts's pin, so its moq bump waited on rind building for wasm32, which only the translator needs. It now holds the revision itself, starting at the same one, so nothing else moves. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
The maintainer chose the split on 2026-11-12: the exporter's pin bumps in moq-pin.md, and rust2-ts's pin bumps in m2/ts-model/moq-pin.md, which carries the rind 0.4 wait. The exporter's bump no longer waits on rind. Also drops the stale 'just ffi' from the model manifest's pin comment. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
The new ts-model quest ended with a stray closing tag. The exporter's bump still said its pin waited on 'just ts moq', which is the translator's wait. Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
|
@pullfrog review this PR. It was opened or marked ready during the 01:10Z to 04:25Z window when no Pullfrog runs fired, so it never got a review. (Written by Claude Opus 5.5 with high effort) |
There was a problem hiding this comment.
ℹ️ No critical issues. One link nit is inline.
Reviewed changes
I reviewed the split of the moq pin: the exporter now pins its own revision, and rust2-ts's bump moves to its own quest.
ffi/justfilepins moq itself:moq_revis now the literalffcb7cd9748422daa30e935ec464108b5a8ebb71, the same revision as the model fixture'srev, so the exported code is unchanged.moq-pinis the only recipe that reads it, and it already uses its owntarget/moqcheckout.- Comments in
ts/are updated:ts/justfile,ts/fixtures/model/Cargo.toml, andts/README.mdno longer sayjust ffifollows the model fixture's pin. No other doc inffi/,ts/,go/, orbench/still says it does. - The exporter's bump quest is narrowed:
quest/m1/ffi-refusals/moq-pin.mdnow bumps onlyffi/justfile. Its rindWaitingitem and itsown-pinrequirement are gone, and the 2026-11-07 decision is marked superseded. - A new quest covers rust2-ts's bump:
quest/m2/ts-model/moq-pin.mdtakes the rind 0.4 wait as it was written, and thets-modelepic records the 2026-11-12 decision. - The finished quest is deleted:
own-pin.mdis removed, and nothing in the tree still links to it.
claude-opus-5-5 | 𝕏
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Haiku 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes
I reviewed what changed since the prior Pullfrog review: two documentation-only commits.
- Corrected links in
quest/m2/ts-model/moq-pin.md: the#390link and the rind links now point atkixel-ai, which resolves the earlier thread. - Matched the rind links in
quest/m1/ffi-refusals/moq-pin.md: its rind#543and#511links also usekixel-ai. - Dropped a link in
quest/m1/ffi-export/README.md: theasync-start.mdlink is gone, which came in with the merge ofmain.
claude-sonnet-5-5 | 𝕏

Problem
The exporter's
moq_revread rust2-ts's pin fromts/fixtures/model/Cargo.toml, so moving the exporter's moq pin also moved the translator's. The moq pin bump (quest/m1/ffi-refusals/moq-pin.md) then waited on rind building for wasm32, which only the translator needs.Approach
ffi/justfileholds its own 40-character revision,ffcb7cd9748422daa30e935ec464108b5a8ebb71, which is today's shared one, so the exported code is unchanged.ts/justfilekeeps its pin ints/fixtures/model/Cargo.toml. Its comment no longer says the exporter follows it, and the manifest's comment no longer namesjust ffi.quest/m1/ffi-refusals/own-pin.mdis finished, so it is deleted with its links. Theffi-refusalsREADME decision line drops its link.moq-pin.mdis now the exporter's bump only: its Plan bumpsffi/justfile's pin, and its rindWaitingitem is gone. Its moq-tokioWaitingitem and itsRequiredquests stay.quest/m2/ts-model/moq-pin.md(see Follow-ups), which carries the rind 0.4 wait as written.Which pin each benchmark reads:
just ffi benchand the otherjust ffiexports (moq,moq-cpp,moq-swift,census) read the exporter's pin, throughmoq-export→standin→moq-pin.go/justfile'sbenchreads no moq pin: its codec fixture is vendored ints/fixtures/codec.bench/buildhas its own corpus revision inbench/build/corpus.toml, which this PR does not touch.Impact
Public API: none. Wire: none. No moq revision moves.
Alternatives
Validation
quest checkandquest check --base origin/main --branch quest/m1/ffi-refusals/own-pin: 62 documents ok, onaf87f11ac, after mergingmain(68ef19591).quest gate nix develop --command just ci origin/mainonaf87f11ac: exit 0.ci-selectran lint, quest, ffi, and ts.just --evaluate moq_revinffi/and ints/both printffcb7cd9748422daa30e935ec464108b5a8ebb71, the exporter's and the model fixture's current revs.just ffi moq-pinchecks outtarget/moqatffcb7cd9, and HEAD is verified.just ffi moq,just ffi census,just ffi bench. They are CPU-heavy exports, and the revision is unchanged, so their inputs are unchanged.Choices
ffi/justfile, not read from another file. No other recipe reads it, so the literal is the simplest form.Required, sincejust ts moqneeds only rind.ts/fixtures/model/Cargo.tomlsaidjust ffichecks the model's pin out, andts/README.mdsaid "too" after thejust tsrecipes.quest/m1/ffi-export/README.mdnow says the exporter's pin bump waited on rind, since it no longer does.moq-pin.md, marked superseded, as the record.mainbefore this PR's merge, re-linking the rind item tokixel-ai. Mergingmainconflicted on that item, which this PR moves out ofmoq-pin.md. The conflict is resolved by deleting the item here, and the follow-up quest carries it withkixel-ailinks, as docs: point rind links at kixel-ai #726's change moves with it.#390link in the follow-up quest pointed atmoq-dev/rust2. It now points atkixel-ai/rust2, as the exporter's quest does.Decisions
moq-pin.md, and rust2-ts's pin moves to its own quest. Rejected: keep one bump for both pins, which keeps the exporter waiting on rind.Follow-ups
ts/fixtures/model/Cargo.tomlonce moq'smainpassesjust ts moq, which waits on rind 0.4 (moq-dev/moq#8432). No open decisions. Kept by the maintainer on 2026-11-12, in the round that picked this PR to merge.Models
Size: XS
Implementer: Claude, claude-haiku-5-5, unknown effort
Implementer: Claude Code, claude-haiku-5-5, unknown effort (iterate, XS)
🤖 Generated with Claude Code
Review
Rewritten by
quest reviewafter each round.Head: af87f11
Base: origin/main at fa311d1
Reviewer: Codex, gpt-6.1-sol, medium effort
Session:
01a1d652-8ed5-7a32-8191-9cfdd5c99851, round 2Score: 10/10,
The only new branch change corrects a documentation link, and no actionable findings remain at the head after excluding changes inherited from main.Findings: none
Codex stands in for the local second reviewer, as the maintainer set on 2026-11-13: the round ran
quest review --harness codexalone, since the OpenCode Go account behindopencode-go/deepseek-v4.1-flashis out of credit. Pullfrog's online review replaces that second reviewer.Summary by CodeRabbit
moqrevisions and have independent update plans.moqrevision independently of the model fixture’s revision.Summary by CodeRabbit