Skip to content

ci: queue and link from the kixel-ai org - #740

Merged
kixelated merged 3 commits into
mainfrom
ci/kixel-ai
Nov 13, 2026
Merged

kixelated merged 3 commits into
mainfrom
ci/kixel-ai

Conversation

@kixelated

@kixelated kixelated commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

rust2 moved from moq-dev to kixel-ai on 2026-11-12.

Changes

  • queue.yml calls kixel-ai/rust2/.github/workflows/queue-build.yml@main. kixel-ai's rust2-queue runner group will admit only that ref.
  • repository in the driver, ffi, go and ts manifests, and the driver's bug report URL, name kixel-ai/rust2.
  • A mechanical rewrite of moq-dev/rust2 to kixel-ai/rust2 across the README files and quests. Links to moq-dev/moq and moq-dev/quest, which did not move, are unchanged.

No workflow gates on the repository owner, so nothing else depended on the old name.

Public API

None.

Caused by

No single PR. The repository transfer to kixel-ai.

Validation

  • just ci origin/main passed when the PR was opened. On re-validation at 475201ef it failed only api_swift ("futures" failed: Rust gives up on an async closure). That failure is pre-existing: just ffi test --test fixtures failed it in 2 of 4 runs on this branch and 1 of 5 at main 7008d1d3, and it passes alone. The follow-up owns it.
  • git grep moq-dev/rust2 finds nothing.

Deploy

Done on 2026-11-13: kixel-ai has the rust2-queue runner group, and nixos runs kixelated/nixos#66 and #67, with nixos-rust2-ci registered in that group. A merge group runs this PR's queue.yml, which calls main's kixel-ai/rust2 copy of queue-build.yml.

Follow-ups

  • quest/m0/swift-gives-up.md: api_swift's "Rust gives up on an async closure" check fails intermittently at main; the quest fixes the test's timing. No open decisions.

Models

Size: XS
Implementer: Claude Code, Claude Opus 5.5
Implementer: Claude Code, claude-opus-5-5 (iterate, XS)

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Documentation
    • Updated repository links throughout guides, plans, benchmark references, and bug-report instructions to point to the current rust2 location.
    • Refreshed links to related pull requests, issues, and CI runs while keeping surrounding explanations and findings unchanged.
    • Added troubleshooting guidance for intermittent Swift fixture test failures, including possible timing issues and recommended investigation steps.
    • Updated documented FFI refusal counts and census figures.
  • Chores
    • Updated package repository metadata and the build workflow to use the current rust2 location.

Review

Rewritten by quest review after each round.

  • Head: 058503f

  • Base: origin/main at 7008d1d

  • Reviewer: Codex, gpt-6.1-sol, medium effort

  • Session: 01a1d30a-15c2-7b23-bce7-d83d773286d6, round 3

  • Score: 9/10, The incremental change only refines the documented Swift test race, matches the relevant code, and introduces no concrete defects; builds and tests were not run as instructed.

  • Findings: none

  • Reviewer: opencode, opencode-go/deepseek-v4.1-flash, high effort

  • Session: ses_e2cf5d601ffeoVQrVit0lr7956, round 3

  • Score: 10/10, The plan now covers both the empty-closure race and the queued-resumption race, citing the relevant Pollable.poll and Within::poll behavior, so the earlier finding is fixed with no new defects.

  • Findings: none

  • The last round's findings, at 47d1740:

    • Fixed: medium, quest/m0/swift-gives-up.md:18: The proposed drain loop does not fix the empty-closure race; The Plan now names the empty-closure race at `ffi/runtime/rt.swift`'s `Pollable.poll` and `ffi/fixtures/api/src/lib.rs`'s `Within::poll`, requires the closure to stay pending, and keeps the drain-until wait for the resumption race.

rust2 moved from moq-dev to kixel-ai. The queue build's reusable
workflow ref, the crates' repository metadata, the driver's bug report
URL, and every doc and quest link now name kixel-ai/rust2.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The build workflow, package metadata, bug-report URL, and project documentation now reference kixel-ai/rust2. Quest documentation also updates repository links, census figures, and a decision date and pull-request reference. One M0 note documents intermittent Swift test failures and possible timing races.

Changes: Repository references and project documentation

Layer / File(s) Summary
Build and package references
.github/workflows/queue.yml, driver/Cargo.toml, driver/src/rustc.rs, ffi/Cargo.toml, go/Cargo.toml, ts/Cargo.toml
The build workflow, package repository URLs, and rustc bug-report URL now use kixel-ai/rust2.
Top-level and benchmark documentation
README.md, bench/build/README.md, ts/README.md
The lint example and benchmark references now point to kixel-ai/rust2.
M0 and M1 quest records
quest/m0/*, quest/m1/*
Rust2 links now point to kixel-ai/rust2. FFI-refusals notes revise census figures. A new note documents intermittent api_swift test failures and possible timing races.
M2–M4 quest records
quest/m2/*, quest/m3/*, quest/m4/*
Rust2 links now point to kixel-ai/rust2. The TypeScript model notes change a decision date and add a pull-request link.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: Minimal · up to 05850

This PR updates repository links and metadata to kixel-ai/rust2 and adds a troubleshooting note, with no runtime behavior change. The merge queue needs the reported runner group and deployment prerequisites in place before it can serve builds, but nothing in the code blocks merging.

Architecture risk: Low · up to 05850

The change affects 7 systems.

Changed systems: quest, driver, ts, bench, ffi, go, README.md

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — quest (service) was modified; 29 changed files map to changed impact.
  • observed — driver (service) was modified; 2 changed files map to changed impact.
  • observed — ts (service) was modified; 2 changed files map to changed impact.
  • observed — bench (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in README.md: The rust2-lint command example changes its Nix flake reference from github:moq-dev/rust2 to github:kixel-ai/rust2.
  • observed — Modified behavior in bench/build/README.md: The ra-jit bug description is unchanged; its linked run now points to kixel-ai/rust2 instead of moq-dev/rust2.
  • observed — Modified behavior in bench/build/README.md: The Cranelift pin reference now links to kixel-ai/rust2 instead of moq-dev/rust2; the reported test failures and other text are unchanged.
  • observed — Modified behavior in bench/build/README.md: The CI-run reference for the CPU-seconds measurements now points to kixel-ai/rust2 instead of moq-dev/rust2.
Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title "ci: queue and link from the kixel-ai org" matches the main change. The PR points the merge queue workflow (queue.yml) at kixel-ai/rust2 and updates repository links, manifests, and quest do…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Full details: Title check

Explanation

The title "ci: queue and link from the kixel-ai org" matches the main change. The PR points the merge queue workflow (queue.yml) at kixel-ai/rust2 and updates repository links, manifests, and quest docs that referenced moq-dev/rust2 after the move to kixel-ai. The title names the CI queue change and the org move, though it does not mention the many documentation and manifest link updates. That omission is expected for a title.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 9fdcd9a9-72af-40da-9ec3-47973f860665
Commits

Reviewing files that changed from the base of the PR and between 475201e and 058503f.

Files selected for processing: 1

  • quest/m0/swift-gives-up.md

Limit details: You’ve used all 10 included reviews currently available.

kixelated and others added 2 commits November 12, 2026 20:16
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated

Copy link
Copy Markdown
Collaborator Author

@pullfrog review this pull request. Its base requires an approving review, and Pullfrog's installation did not cover rust2 when this PR was opened after the move to kixel-ai.

(Written by Claude Opus 5.5)

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

The whole PR: the repository rename's CI and metadata edits, the mechanical link rewrite, and the new m0 quest for the intermittent api_swift failure.

  • Queue call: queue.yml's build job now calls kixel-ai/rust2/.github/workflows/queue-build.yml@main. That file exists on main and is a workflow_call workflow. No workflow gates on github.repository_owner, and the github.repository uses in nightly.yml and queue.yml's report job pick up the new owner on their own.
  • Manifests and bug URL: repository in driver, ffi, go, and ts, plus BUG_REPORT_URL in driver/src/rustc.rs, now name kixel-ai/rust2.
  • Link rewrite: git grep moq-dev/rust2 finds nothing at the head. The moq-dev/moq and moq-dev/quest references that remain are correct, because those repositories did not move: flake.nix's quest input, bench/build/corpus.toml, ts/fixtures/model/Cargo.toml, and the queue watcher comment in queue.yml.
  • quest/m0/swift-gives-up.md: I checked the diagnosis against the code and both races it names are real:
    • Empty closure: Pollable.poll in ffi/runtime/rt.swift starts the Task and then loads done again. Within::poll in ffi/fixtures/api/src/lib.rs polls the inner future before it checks left. So an empty closure that finishes in that window makes within(0) {} return Ok(()).
    • Single drain: the check in ffi/tests/api.swift reads threw after one q.drain(). The check above it uses until { q.drain(); ... } instead.

Pullfrog  | View workflow run | Using claude-opus-5-5 | 𝕏

@kixelated
kixelated added this pull request to the merge queue Nov 13, 2026
Merged via the queue into main with commit 7b0958b Nov 13, 2026
10 checks passed
@kixelated
kixelated deleted the ci/kixel-ai branch November 13, 2026 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant