Repository navigation
Recommend standard speed and report API-equivalent speed premiums - #10
Merged
Merged
Conversation
Quest-Claim: 8c8ebc38d434a1f5
…estimates Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
…sons Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
Collaborator
Author
|
Design change: Emit one speed check per current owning control with disjoint request subsets. Distinct known project settings should each receive their applicable warning or keep result; a standard project must not mask another known premium project. Unresolved profile/project ownership stays advisory. The comparison still holds other recorded settings constant and never sums independent savings. Also fixed all four initial review findings, with synthetic regressions for unsupported Opus history, the verified plain GPT-5.6 alias, nearest Codex project ownership and accurate error-file attribution. Full checks pass with 134 tests under both runtimes. Restarting local review for the committed head. (Written by GPT-6.1 Sol with xhigh) |
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
kixelated
marked this pull request as ready for review
November 7, 2026 20:00
kixelated
enabled auto-merge (squash)
November 7, 2026 20:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Recommend standard speed for justified current Claude Code/Codex premium preferences, naming the effective value, owner and replacement. Honor Claude per-session opt-in, managed false, active-profile environment disable, model support and current project/local settings. Honor Codex independent fast/ultrafast gates and local requirements; unresolved profile/project/provider ownership stays advisory. Historical premiums never recommend a change against current standard speed.
Add
fast-modeto the existing shared analysis/report union, human/details output and schema-version-1 JSON. Separate observed response-speed premiums, current-setting estimates, and unknown billing metadata. Reprice at the same model's standard API rate with recorded cache categories/lifetimes, context tiers and geography held constant. Explicitly label this rate-only API-price comparison: Claude cache-switch effects and latency value are excluded; no subscription/credit or summed savings claims.Native Codex TokenUsageRecord has no billed service tier. Remove the old requested-turn-tier fallback; retain requested controls separately without claiming they were billed. Claude recorded response usage can establish observed speed and standard fallback. Missing historical usage/prices does not block the current-setting warning or become invented dollars.
Complete and remove the fast-mode quest and parent reference. No publication, transcript repair or host-cost audit.
Choices
Public API and wire impact
Add the
fast-modecheck variant and structuralProfile.speed/speedDirectoriesandRequest.requestedSpeedmetadata to the existing schema-version-1 report. Native Codex billed tiers and orphan Claude attempt tiers are now unknown instead of inherited from request settings. No CLI flags or exit-policy change: applicable current premium settings exit 1, advisory only exits 0, failed scans exit 2.Validation
nix develop --command quest gate just check: formatting, TypeScript, JS build, 138 synthetic tests under Bun 1.4.4 and Node 24, quest validation, and packed standalone Node/npx/Node-free bunx consumers pass.Caused by
Models
Size: S
Implementer: Codex, gpt-6.1-sol, xhigh effort
Review
Rewritten by
quest reviewafter each round.0a43d748-1198-43a3-931c-83987b18b715, round 3Nothing under src or test changed since the last review, which already confirmed the fixes, so no open findings remain.(Written by GPT-6.1 Sol with xhigh)