Repository navigation
fix(nix): build the flake package with the files and SQLite it needs - #188
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
There was a problem hiding this comment.
✅ No new issues found.
Approach: sound. It fixes both build failures in the recipe, with no change to the code that gets built.
Reviewed changes: the single flake.nix change.
- Fileset: adds
./tests/ssh_windows.rs, the only fileCargo.tomlnames in a[[test]]table (line 43). The other tests undertests/are auto-discovered, so cargo doesn't need them present. - SQLite: adds
pkgs.pkg-configtonativeBuildInputsandpkgs.sqlitetobuildInputs. This follows the nixpkgs convention and fixes the-lsqlite3link error under newer nixpkgs. The added comment explains why it's needed.
claude-sonnet-5-5 | 𝕏
The bumped nixpkgs' Cargo setup hook makes rusqlite link the system SQLite, which token-max's flake package at f2bfa79 does not provide, so the dev shell failed with `ld: cannot find -lsqlite3`. kixel-ai/token-max#188 adds sqlite and pkg-config to its package; fff5368 is the first commit with it. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

Fixes
nix build github:kixel-ai/token-maxfailing two ways.Summary
flake.nix's fileset omittedtests/ssh_windows.rs, whichCargo.tomlnames as a[[test]], so every build at main failed withcan't find ssh_windows test. It now lists the file.cannot find -lsqlite3: nixpkgs' Cargo setup hook makes rusqlite link the system SQLite even with thebundledfeature, and the package declared neitherpkg-confignorsqlite. It now declares both, as nixpkgs' own Rust packages do. Flakes that follow their own nixpkgs, such as kixel-ai/dotfiles through moq-dev/quest, hit this.Public API
None. Build recipe only; no wire change.
Caused by
ssh_windowstest without adding it to the flake's fileset (found by person).-lsqlite3failure is no single PR's: it appears only under a nixpkgs whose Cargo hook forces pkg-config, which this repo's lock predates (an upstream nixpkgs change).Validation
nix build .#defaultat main fails with thessh_windowserror; with the fileset fixed and--override-input nixpkgs github:NixOS/nixpkgs/d4f25a3e562008648d45bcf2d70bcc7422cad84eit fails withld.bfd: cannot find -lsqlite3.4fe25e12eb9f4c744966dd3de5a05246cf098601, and the repo's own lock builds too; the builttoken-max --versionprints0.0.1and--helpruns.quest checkpasses.nix buildto the gate would cost a full release build per run, so this PR does not.Models
Size: XS
Implementer: Claude Code, claude-sonnet-5-5, unknown effort (iterate, XS, arm B)
🤖 Generated with Claude Code
(Written by Sonnet 5.5)
Review
Rewritten by
quest reviewafter each round.Head: 3727453
Base: origin/main at 4123fb4
Risk: medium,
the base has no RISK.md to name what is always high or customer-facing, so every change is mediumClassified: medium by default
Reviewer: Codex, gpt-6.1-sol, medium effort
Session:
01a1ff4a-e3e7-75f1-9d86-4efcfddd44ad, round 1Score: 9/10,
The changes supply the declared Cargo test target and SQLite build dependencies without an identifiable regression on code inspection; builds and tests were intentionally not run.Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0
Findings: none
Reviewer: Codex, gpt-6.1-sol, low effort, shadow
Session:
01a1ff4a-e3e8-72e1-b1a9-2df7ddda7672, round 1Score: 9/10,
Code inspection found no actionable regressions in the SQLite build dependencies or Nix test-source inclusion, but builds and tests were not run.Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0
Findings: none
Summary by CodeRabbit
pkg-configbuild inputs. These changes affect package build contents and requirements; no user-facing features or behavior changed.