Skip to content

docs(quest): finish the crates.io trusted publisher - #189

Open
kixelated wants to merge 2 commits into
mainfrom
quest/m1/trusted-publisher
Open

kixelated wants to merge 2 commits into
mainfrom
quest/m1/trusted-publisher

Conversation

@kixelated

@kixelated kixelated commented Nov 21, 2026 •

Copy link
Copy Markdown
Collaborator

Finishes quest/m1/trusted-publisher.md: the token-max crate on crates.io now has a trusted publisher, so the next Release dispatch runs in the default trusted mode without a token.

The maintainer signed in to GitHub and crates.io in the agent Chrome on desktop (the quest's Waiting item). An agent then added the publisher on the crate's settings page with the values that docs/releasing.md gives and release.yml uses: owner kixel-ai, repository token-max, workflow release.yml, environment crates-io. That job has id-token: write. crates.io found the workflow file on HEAD when the form was submitted.

The PR deletes the quest and updates its mention in quest/m0/README.md.

Validation

GET https://crates.io/api/v1/trusted_publishing/github_configs?crate=token-max (signed in) returns one config: id 36134, repository_owner: kixel-ai, repository_name: token-max, workflow_filename: release.yml, environment: crates-io, created 2026-11-21T23:17:40Z. The crate's settings page lists it too. The real test is the next Release run in trusted mode. quest check passes (11 documents ok). This PR changes only quest files, so there is no code behavior to exercise.

Reviewer re-check, independent of the implementer: the same endpoint, fetched in the signed-in agent Chrome, returns config 36134 with repository_owner_id: 355263551, which gh api orgs/kixel-ai --jq .id matches, and the repo has a crates-io environment. quest check --base origin/main passes. The Check failure on the draft is the workflow's draft gate (Source skipped); marking ready reruns it.

Public API

None.

Follow-ups

None.

Models

Size: XS
Implementer: Claude Code, claude-opus-5-5, unknown effort

(Written by Claude Opus 5.5)

🤖 Generated with Claude Code

Review

Rewritten by quest review after each round.

  • Head: 430b855

  • Base: origin/main at fff5368

  • Risk: medium, the base has no RISK.md to name what is always high or customer-facing, so every change is medium

  • Classified: medium by default

  • Reviewer: Codex, gpt-6.1-sol, medium effort

  • Session: 01a2006b-305d-7833-bf1b-ac243d6e1107, round 1

  • Score: 10/10, This documentation-only change records trusted-publisher setup as complete and removes its task file without dangling references or executable changes; external crates.io configuration was not independently verified.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

  • Reviewer: Codex, gpt-6.1-sol, low effort, shadow

  • Session: 01a2006b-305d-72c1-b3cf-02c45ba72770, round 1

  • Score: 10/10, The documentation-only change records completion of trusted-publisher setup and removes its pending task, with no identifiable defects.

  • Rounds: 1; first round 0; findings 0: fixed 0, refuted 0, open 0

  • Findings: none

Summary by CodeRabbit

  • Documentation
    • Updated the release plan to note that the crates.io trusted publisher was added on 2026-11-21 and that the next release uses trusted mode.
    • Removed the separate m1 quest documentation for adding the trusted publisher.

@coderabbitai

coderabbitai Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The plan now records the crates.io trusted publisher setup as complete and states that the next release runs in trusted mode. The separate quest document about setting up the publisher has been removed.

Changes: Trusted publisher status

Layer / File(s) Summary
Record publisher setup completion
quest/m0/README.md, quest/m1/trusted-publisher.md
The plan records the setup date and states that the next release runs in trusted mode. The separate setup quest document is removed.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Possibly related PRs

  • kixel-ai/token-max#170: Adds the trusted publisher setup quest document that this PR removes after recording the setup as complete.

Suggested reviewers: pullfrog

Merge Risk: Minimal · up to 430b8

This PR only updates planning documents to record that trusted publishing is set up. It changes no runtime behavior, so merge risk is minimal. The next release run will confirm that the external crates.io configuration works.

Architecture risk: Low · up to 430b8

The change affects 1 system.

Changed systems: quest

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — quest (service) was modified; 2 changed files map to changed impact.

Before / after behavior

  • observed — Modified behavior in quest/m0/README.md: The Plan now says the crates.io trusted publisher for later releases was added on 2026-11-21 and the next release runs in trusted mode, replacing the statement that this work was a separate m1 quest.
  • observed — Modified behavior in quest/m1/trusted-publisher.md: Removed the quest document describing the trusted-publisher setup, the 0.0.1 publication and token history, the required crates.io publisher configuration, and the maintainer sign-in dependency.
Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "docs(quest): finish the crates.io trusted publisher" matches the main change. The PR marks the crates.io trusted-publisher setup for token-max as complete, deletes quest/m1/trusted-publishe…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "docs(quest): finish the crates.io trusted publisher" matches the main change. The PR marks the crates.io trusted-publisher setup for token-max as complete, deletes quest/m1/trusted-publisher.md, and updates the mention in quest/m0/README.md. The title is specific, short, and follows a conventional commit style. It does not describe the workflow details, which is acceptable.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d2c035ce-6e48-4dd9-9c19-40f159203104
Commits

Reviewing files that changed from the base of the PR and between fff5368 and 430b855.

Files selected for processing: 2

  • quest/m0/README.md
  • quest/m1/trusted-publisher.md
Files with no reviewable changes: 1

  • quest/m1/trusted-publisher.md

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 4 remain after this review.

The trusted publisher for kixel-ai/token-max, release.yml, environment
crates-io was added on crates.io on 2026-11-21.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kixelated kixelated changed the title Add the crates.io trusted publisher docs(quest): finish the crates.io trusted publisher Nov 21, 2026
@kixelated
kixelated marked this pull request as ready for review November 21, 2026 23:23

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Approach: sound — the quest is complete, so the task file is deleted and its one mention is updated.

Reviewed changes: both changed files; no code is touched.

  • quest/m1/trusted-publisher.md removed: the finished quest is deleted. A search for trusted-publisher found no remaining references.
  • quest/m0/README.md updated: the link to the quest becomes a dated note (2026-11-21) that the next release runs in trusted mode.

I did not verify the crates.io configuration itself. I relied on the PR description's check of the config.

Pullfrog  | View workflow run | Using claude-sonnet-5-5 | 𝕏

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant