Repository navigation
Polished terminal report - #7
Conversation
Quest-Claim: 7e894e3f55a14754
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
|
Design change: Layout now wraps plain text before styling, using (Written by GPT-6.1 Sol with xhigh) |
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
|
Responses to the eight findings in session b65c3db7-8a3a-482d-b26c-f8542ca4b414, round 1. The layout now wraps plain text before styling with string-width and Intl.Segmenter; the Design change comment explains the new review session. The branch also merges main e778e8a and renders its actual TTL/compaction-window union, without changing the calculations.
Validation: the full repository check gate covers the built command and both real analyzer result variants, including a priced compaction recommendation from a synthetic transcript, every candidate and geometry witness, guidance and unknowns, cancellation, errors, pipes, plain and JSON. (Written by GPT-6.1 Sol with xhigh) |
Co-Authored-By: GPT-6.1 Sol <noreply@openai.com>
The CLI now puts actionable setting changes first, with current/suggested values, profile and owner, separate baselines, window/monthly estimates, and explicit evidence labels. A wrapping flow keeps complete names and money readable on narrow terminals.
--detailsexposes all check evidence without an interactive UI; JSON uses the same analysis and retains schema version 1.Interactive phase progress stays on stderr. Pipes,
--plain,NO_COLOR, JSON, empty histories, empty windows, offline prices, failures and cancellation have deliberate output. SIGINT/SIGTERM abort local scanning and pricing with exit 2 and no success report. Metadata controls and direction overrides are escaped before terminal rendering. No settings or transcript content are edited or printed.Design choices
src/report.ts; reuse the landed analyzer without recomputing settings, coverage or savings. Order changes, advisories and keeps without a top-N cutoff or combined savings total.--details. JSON remains the complete automation interface.string-width8.3.0 for terminal cells andIntl.Segmenterfor graphemes. Preserve Unicode spelling; redirected fields stay unwrapped and copyable. Color only reinforces text labels; Unicode decorations require a UTF-8 locale, and phase lines need no timers or cursor hiding.quest/m0/cli.mdand its parent link. Merge landed kixelated/token-max#6, basee778e8a9bfe88be4d912fbaa8de792cb8f878eb6, and render both actual check variants. Compaction cards retain the TTL-conditional baseline, each candidate, extra summary/resumed-prefix costs and provenance, sensitivities and break-evens. No compaction calculations are duplicated.Public API and wire impact
Adds
--detailsand--plain. Human text changes from the minimal renderer to a wrapping report.--helpdocuments profile selection, evidence, pricing, cancellation and exit codes. JSON schema version 1, output fields, decision logic and exit 0/1/2 remain unchanged. Discovery, scan and price options accept an optional AbortSignal. The internal renderer moves fromsrc/cli.tstosrc/report.ts.Validation
nix develop -c quest gate just check: passed formatting, TypeScript, JavaScript build, all 104 synthetic tests under Bun and Node 24, and quest validation.quest check --base origin/mainandgit diff --checkpassed. The independent exact-head review is recorded below.Caused by
Models
Size: M
Implementer: Codex, gpt-6.1-sol, xhigh effort
Review
Rewritten by
quest reviewafter each round.4c0dea29-b208-48a4-982c-2f841f5124f4, round 2All five earlier findings are fixed at the head and the new code adds no problems, so it can land as is.src/cli.ts:54:A second signal calls process.exit(2) and skips the cleanup that removes the price temp file;loadPrices now registers a synchronous `process.on("exit", discard)` that calls rmSync on its own UUID temp file (src/prices.ts:131-138), and removes that listener in the finally block (src/prices.ts:169-174), so the forced `process.exit(2)` at src/cli.ts:55 no longer leaves the partial file behind.src/cli.ts:184:Non-cancel diagnostics repeat 'no report produced' and 'use --help';The generic 'No report produced. Use --help...' suffix is gone, and the non-JSON diagnostic is now a single specific line (src/cli.ts:191).src/cli.ts:21:Option descriptions in --help do not line up;Every option row's description now starts at column 26; for example, ` --details` is padded out to 26 like ` --since YYYY-MM-DD|ISO ` (src/cli.ts:18-27).src/terminal.ts:13:Wrapped help lines go back to the option-name column, not the description column;wrapText accepts a `continuation` column and uses it for every row after the first (src/terminal.ts:19-31); help passes each option row's label-plus-separator length as that column (src/cli.ts:85-90).src/report.ts:100:The earliest request time is found with a reduce over requests that are already sorted;The header now uses `requests[0]?.time ?? null` (src/report.ts:100), which relies on the sort in reader.ts.(Written by GPT-6.1 Sol with xhigh)