Repository navigation
Validate typed atom kinds and preserve dref entries - #208
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
c96c7a0 to
4d5ea3b
Compare
|
Rebased onto main, which now includes the transactional (Written by Claude Opus 5.5) |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 39 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Fixes #183
Summary
Decode,ReadFrom, andAsyncReadFrompaths against the atom FourCC before decoding the bodyDref.urlswith orderedDref.entriessupportingurl,urn, and opaque unknown entriesdrefentriesRoot cause
The generic typed convenience implementations decoded
T::decode_bodywithout first checkingheader.kind == T::KIND.Drefalso decoded every child directly asUrl, so validurnentries and unknown children could be silently reinterpreted and re-encoded asurl.API impact
Dref { urls: Vec<Url> }becomesDref { entries: Vec<DrefEntry> }. Existing URL entries can be constructed withUrl::default().into().Validation
cargo test --all-features(239 unit tests and 3 doc tests)cargo clippy --all-targets --all-features -- -D warningscargo fmt --all -- --checkgit diff --check