Skip to content

chore: release v0.17.0 - #247

Merged
bradh merged 1 commit into
mainfrom
release-plz-2026-10-18T02-57-48Z
Oct 30, 2026
Merged

bradh merged 1 commit into
mainfrom
release-plz-2026-10-18T02-57-48Z

Conversation

@github-actions

@github-actions github-actions Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

🤖 New release

  • mp4-atom: 0.16.2 -> 0.17.0 (⚠ API breaking changes)

⚠ mp4-atom breaking changes

--- failure constructible_struct_adds_field: struct exhaustively constructible through public API adds field ---

Description:
A pub struct that could be exhaustively constructed with a literal using only public API has a new pub field, breaking existing exhaustive literals.
        ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.51.0/src/lints/constructible_struct_adds_field.ron

Failed in:
  field Dref.entries in /tmp/.tmpGc0ANw/mp4-atom/src/moov/trak/mdia/minf/dinf/dref/mod.rs:11
  field Jpeg.spatial in /tmp/.tmpGc0ANw/mp4-atom/src/moov/trak/mdia/minf/stbl/stsd/jpeg.rs:26
  field Hev1.spatial in /tmp/.tmpGc0ANw/mp4-atom/src/moov/trak/mdia/minf/stbl/stsd/hevc/hev1.rs:14
  field Hvc1.spatial in /tmp/.tmpGc0ANw/mp4-atom/src/moov/trak/mdia/minf/stbl/stsd/hevc/hvc1.rs:16
  field Tx3g.disp in /tmp/.tmpGc0ANw/mp4-atom/src/moov/trak/mdia/minf/stbl/stsd/tx3g.rs:19
  field Vp08.spatial in /tmp/.tmpGc0ANw/mp4-atom/src/moov/trak/mdia/minf/stbl/stsd/vp9/vp08.rs:12
  field Vp09.spatial in /tmp/.tmpGc0ANw/mp4-atom/src/moov/trak/mdia/minf/stbl/stsd/vp9/vp09.rs:12
  field Av01.spatial in /tmp/.tmpGc0ANw/mp4-atom/src/moov/trak/mdia/minf/stbl/stsd/av01.rs:18
  field Dops.channel_mapping in /tmp/.tmpGc0ANw/mp4-atom/src/moov/trak/mdia/minf/stbl/stsd/opus.rs:74
  field Trun.samples in /tmp/.tmpGc0ANw/mp4-atom/src/moof/traf/trun.rs:20
  field Uncv.spatial in /tmp/.tmpGc0ANw/mp4-atom/src/moov/trak/mdia/minf/stbl/stsd/uncv.rs:15
  field EsDescriptor.depends_on_es_id in /tmp/.tmpGc0ANw/mp4-atom/src/moov/trak/mdia/minf/stbl/stsd/mp4a/esds.rs:178
  field EsDescriptor.url in /tmp/.tmpGc0ANw/mp4-atom/src/moov/trak/mdia/minf/stbl/stsd/mp4a/esds.rs:180
  field EsDescriptor.ocr_es_id in /tmp/.tmpGc0ANw/mp4-atom/src/moov/trak/mdia/minf/stbl/stsd/mp4a/esds.rs:182
  field EsDescriptor.stream_priority in /tmp/.tmpGc0ANw/mp4-atom/src/moov/trak/mdia/minf/stbl/stsd/mp4a/esds.rs:184
  field Avc1.spatial in /tmp/.tmpGc0ANw/mp4-atom/src/moov/trak/mdia/minf/stbl/stsd/h264/avc1.rs:13
  field Avc3.spatial in /tmp/.tmpGc0ANw/mp4-atom/src/moov/trak/mdia/minf/stbl/stsd/h264/avc3.rs:16

--- failure copy_impl_added: type now implements Copy ---

Description:
A public type now implements Copy, causing non-move closures to capture it by reference instead of moving it.
        ref: https://github.com/rust-lang/rust/issues/100905
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.51.0/src/lints/copy_impl_added.ron

Failed in:
  mp4_atom::TrunEntry in /tmp/.tmpGc0ANw/mp4-atom/src/moof/traf/trun.rs:180

--- failure struct_pub_field_missing: pub struct's pub field removed or renamed ---

Description:
A publicly-visible struct has at least one public field that is no longer available under its prior name. It may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.51.0/src/lints/struct_pub_field_missing.ron

Failed in:
  field urls of struct Dref, previously in file /tmp/.tmpAePwEI/mp4-atom/src/moov/trak/mdia/minf/dinf/dref/mod.rs:9
  field entries of struct Trun, previously in file /tmp/.tmpAePwEI/mp4-atom/src/moof/traf/trun.rs:20
Changelog

0.17.0 - 2026-10-30

Added

  • [breaking] store field-less trun runs as a count (#254)

Fixed

  • [breaking] decode the ES descriptor's optional fields (#257)
  • [breaking] read version 0 trun composition offsets as unsigned (#258)
  • print correct values for FixedPoint (#249)

Other

  • Validate typed atom kinds and preserve dref entries (#208)
  • reduce code duplication in string decoding and encoding (#253)
  • add accessors for the base sample entries of Codec (#250)
  • Validate nested iref reference sizes (#219)
  • Fix sgpd entry boundaries (#202)
  • decode and encode any channel mapping family (#246)
  • Set Minimum Supported Rust Version (MSRV) to 1.88 (#255)
  • implement Decode and Encode for RgbaColor (#251)
  • add support for disp to tx3g sample entry (#252)
  • Add spherical and stereo video metadata (sv3d, st3d, vexu, hfov) (#244)
  • Return errors for missing infe content types (#245)


This PR was generated with release-plz.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-18T02:58:50.497369Z 70be4e6 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions
github-actions Bot force-pushed the release-plz-2026-10-18T02-57-48Z branch from 70be4e6 to 2bc818d Compare October 19, 2026 23:35
@github-actions github-actions Bot changed the title chore: release v0.16.3 chore: release v0.17.0 Oct 19, 2026
@bradh

bradh commented Oct 19, 2026

Copy link
Copy Markdown
Collaborator

@AdrianEddy Do you have more stereo video or similar related changes you want to add before this release?

@AdrianEddy

Copy link
Copy Markdown
Contributor

I have 7 more changes that break public API, and also would like to get #213 and #107 merged, but that's probably too much to squeeze into 0.17.

You're very responsive and fast with releases anyway, so whatever works for you - I can dump them all at once, or do them slowly one at a time. We can also chat about this to figure out the best way to handle all these changes - just let me know what works best for you

Brief table of the changes I have in my fork:

# PR What breaks
1 elst: keep out-of-spec media_time values (below −1 instead of erroring) ElstEntry::media_time becomes Option<i64>
2 Depth guard (MAX_ATOM_DEPTH = 12), against stack overflow on hostile files new Error::TooDeep variant
3 Codec::Unknown re-encodes verbatim (timed-metadata tracks survive a remux) Error::UnknownCodec removed
4 trak: keep uuid boxes (Spherical V1 XML) Trak::uuid
5 minf: QuickTime base media header (gmhd/gmin/tcmi) Minf::gmhd
6 QuickTime handlers and box order: hdlr component type and Pascal-string names, the data hdlr in minf, QuickTime child order Hdlr::component_type, Minf::hdlr
7 keep the JOC complexity index; find dac3/dec3 inside a QuickTime wave Ec3SpecificBox::complexity_index_type_a

Changes that don't break the API but do change bytes or results:

  • Box order:
    • moov writes mvhd, meta, trak, mvex, udta, ainf; it was mvhd, ainf, meta, mvex, udta, trak.
    • trak writes tkhd, edts, tref, meta, mdia, …; it was tkhd, mdia, edts, ….
    • minf writes the media header, then gmhd, hdlr, dinf, stbl; it was dinf, stbl, media header.
  • Header versions: mvhd/tkhd/mdhd are written as version 0 when the values fit; they were always version 1.
  • QuickTime hdlr: the component type and Pascal-string names are now read properly.
  • Fewer errors: Codec::Unknown entries re-encode instead of failing, and a media_time below −1 is kept instead of erroring.

Three things to know about these:

  • PR 2: add #[non_exhaustive] to Error in the same PR. 0.17 is a breaking release anyway, and it stops any future error variant from being breaking.
  • Shared code in PRs 4–6: PRs 5 and 6 both add a field to Minf, and PR 6 adds the order: arm to nested!, which PR 4's Trak uuid also appears in. Merge them in the order 4 → 5 → 6, or rebase whichever lands second; either way the conflicts are trivial.

@bradh

bradh commented Oct 20, 2026

Copy link
Copy Markdown
Collaborator

I have 7 more changes that break public API, and also would like to get #213 and #107 merged, but that's probably too much to squeeze into 0.17.

Brief table of the changes I have in my fork:

PR What breaks

1 elst: keep out-of-spec media_time values (below −1 instead of erroring) ElstEntry::media_time becomes Option<i64>

Later. Maybe gated on strict. Maybe not.

2 Depth guard (MAX_ATOM_DEPTH = 12), against stack overflow on hostile files new Error::TooDeep variant

Now

3 Codec::Unknown re-encodes verbatim (timed-metadata tracks survive a remux) Error::UnknownCodec removed

I'm unlikely to merge this - previously discussed. Luke might see it differently.

4 trak: keep uuid boxes (Spherical V1 XML) Trak::uuid

Now, assuming its pretty simple.

5 minf: QuickTime base media header (gmhd/gmin/tcmi) Minf::gmhd

Later

6 QuickTime handlers and box order: hdlr component type and Pascal-string names, the data hdlr in minf, QuickTime child order Hdlr::component_type, Minf::hdlr

Later

7 keep the JOC complexity index; find dac3/dec3 inside a QuickTime wave Ec3SpecificBox::complexity_index_type_a

Later

Changes that don't break the API but do change bytes or results:

* **Box order:**
  
  * `moov` writes `mvhd, meta, trak, mvex, udta, ainf`; it was `mvhd, ainf, meta, mvex, udta, trak`.
  * `trak` writes `tkhd, edts, tref, meta, mdia, …`; it was `tkhd, mdia, edts, …`.
  * `minf` writes the media header, then `gmhd`, `hdlr`, `dinf`, `stbl`; it was `dinf, stbl, media header`.

Probably want to understand the rationale, so Later at this stage.

* **Header versions:** `mvhd`/`tkhd`/`mdhd` are written as version 0 when the values fit; they were always version 1.

Now

* **QuickTime `hdlr`:** the component type and Pascal-string names are now read properly.

Soon, but not Now.

* **Fewer errors:** `Codec::Unknown` entries re-encode instead of failing, and a `media_time` below −1 is kept instead of erroring.

As above for 1 and 3.

Three things to know about these:

* **PR 2:** add `#[non_exhaustive]` to `Error` in the same PR. 0.17 is a breaking release anyway, and it stops any future error variant from being breaking.

Probably OK for Now.

* **Shared code in PRs 4–6:** PRs 5 and 6 both add a field to `Minf`, and PR 6 adds the `order:` arm to `nested!`, which PR 4's `Trak` `uuid` also appears in. Merge them in the order 4 → 5 → 6, or rebase whichever lands second; either way the conflicts are trivial.

So 4 for Now works.

"Now" and "Later" are relative, and should be seen as "what I think I can do pretty quickly", not demands for you do anything.

@github-actions
github-actions Bot force-pushed the release-plz-2026-10-18T02-57-48Z branch from 827825f to 74460d6 Compare October 30, 2026 06:30
@bradh
bradh merged commit b123336 into main Oct 30, 2026
2 checks passed
@bradh
bradh deleted the release-plz-2026-10-18T02-57-48Z branch October 30, 2026 06:58
@bradh

bradh commented Oct 30, 2026

Copy link
Copy Markdown
Collaborator

@AdrianEddy I pushed 0.17. I'll resurrect #213 as my next change - just need to get some sleep. #107 will get some attention after that.

@AdrianEddy

AdrianEddy commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

thanks, much appreciated.
I'll get to my other changes a bit later, I'm super busy these days and want to prepare these PRs properly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants