Repository navigation
Strip a function prefix (v0.11.0-kixelated.6+v0.32.2) - #5
Merged
kixelated merged 3 commits intoOct 23, 2026
Merged
Conversation
strip_function_prefix drops a prefix from top-level function names, the way strip_type_prefix does for types, refusing a rename onto an existing function or a C++ keyword. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
--config applies to every crate in the fixtures library, and their order varies by platform, so async_ hit coverall's async_bool first on Windows. async_maybe_ collides only in async-calls. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One generator change for moq's C++ package, shipped as
v0.11.0-kixelated.6+v0.32.2and pinned by moq-dev/moq#6476.strip_function_prefix[bindings.cpp] strip_function_prefix = "foo_"names a top-level functionfoo_connectasconnect, the waystrip_type_prefixdoes for types. moq-ffi prefixes every free function withmoq_for languages without namespaces; with this,cpp/moqdrops its pass-through wrappers and each function has one name.rename, so FFI symbols and checksums are untouched.fn_namedoes not escape keywords.Tests
expected-testaddsstrip_function_prefix = "capi_"and callscapi::checksum,capi::fail, and asynccapi::sum.strip-function-prefix-collision-test:async_maybe_collidesasync_maybe_new_megaphonewithnew_megaphone.--configapplies to every crate in the fixtures library, in a platform-dependent order, so each refusal test uses a prefix that hits only one crate.strip-function-prefix-keyword-test:oops_on error-types turnsoops_enumintoenum.(Written by Claude Opus 5.5)