Repository navigation
build: pin uniffi-bindgen-cpp with C durations - #6683
Conversation
Quest-Claim: edce8e1e23c5e549
Pins the fork commit that renders UniFFI's Duration in the generated C, kixelated/uniffi-bindgen-cpp#6, until it is tagged v0.11.0-kixelated.7+v0.32.2. Finishes quest/m1/c/duration.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review.
|
|
Merging eb3fd50 with the maintainer's approval. The non-Grok review of this head is clean, every finding is fixed or answered, and the pre-land (Written by Claude Opus 5.5) |
Finishes quest/m1/c/duration.md. The C backend of our
uniffi-bindgen-cppfork now renders UniFFI's builtinDuration, which unblocks binding durations. The generator change merged as kixelated/uniffi-bindgen-cpp#6 and is taggedv0.11.0-kixelated.7+v0.32.2.Changes
uniffi-bindgen-cpptov0.11.0-kixelated.7+v0.32.2everywhere the flake comment lists it:flake.nix,rs/moq-ffi/build.sh,cpp/moq/README.md, and thecpp,platform,release-cpp, andrelease-shared-ffiworkflows.What the generator does
Generated C spells a duration
moq_duration, atypedef int64_tcount of nanoseconds. That mirrors C++'sstd::chrono::nanosecondsand Go'stime.Duration.Option<Duration>is{ has_value, value }, like the other optional scalars.The C++ converter, which C goes through, used to silently corrupt out-of-range values:
INT64_MAXnanoseconds (about 292 years) overflowed.Both now fail. Under
cpp/moq's expected style, the failure is an abort with a message.The binding durations quest now notes that moq-ffi must not return a saturated
Duration::MAXwhere it clamps tou64::MAXmicroseconds today (auth.rs,session.rs). C and C++ would abort on it.Decisions made
int64_t, so the unit shows on every field, argument, and return.nix build --rebuild .#uniffi-bindgen-cpp.srcrefetched the tag and verified the same hash, and the generator builds from it.Impact
Duration, so the generated C and C++ are unchanged. The binding durations quest is the first consumer.Checks
just checkfails atcheck flake.nix flake checkbuilds thegithub-runnerimage, andsystemd-repartcannotunsharein this sandbox. That failure is known and cancelled the other lanes.rscheck and test (moq-ffi)jscheck and testpycheck and testkt,go,dart, andcppobs compileandobs checkmarkdownandghcheck and testquestanddrillshell,large_files,toml,nix, andjustfileswiftskipped locally because there is no Swift toolchain on Linux.Follow-ups
cpp/moq. The leak predates this change; the new duration refusal is now one more way to hit it.🤖 Generated with Claude Code
(Written by Claude Opus 5.5)