Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/cpp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
- uses: ./.github/actions/just

- name: Install uniffi-bindgen-cpp
run: cargo install uniffi-bindgen-cpp --locked --git https://github.com/kixelated/uniffi-bindgen-cpp --tag v0.11.0-kixelated.6+v0.32.2
run: cargo install uniffi-bindgen-cpp --locked --git https://github.com/kixelated/uniffi-bindgen-cpp --tag v0.11.0-kixelated.7+v0.32.2

- name: Check
run: just cpp check
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/platform.yml
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ jobs:
- name: Install uniffi-bindgen-cpp
if: needs.scope.outputs.cpp == 'true' || needs.scope.outputs.obs == 'true'
shell: bash
run: cargo install uniffi-bindgen-cpp --locked --git https://github.com/kixelated/uniffi-bindgen-cpp --tag v0.11.0-kixelated.6+v0.32.2
run: cargo install uniffi-bindgen-cpp --locked --git https://github.com/kixelated/uniffi-bindgen-cpp --tag v0.11.0-kixelated.7+v0.32.2
- name: Rust compile and tests
if: needs.scope.outputs.rs == 'true'
shell: bash
Expand Down Expand Up @@ -151,7 +151,7 @@ jobs:
secret-access-key: ${{ secrets.MBX_R2_SECRET_ACCESS_KEY }}
- name: Install uniffi-bindgen-cpp
if: needs.scope.outputs.obs == 'true'
run: cargo install uniffi-bindgen-cpp --locked --git https://github.com/kixelated/uniffi-bindgen-cpp --tag v0.11.0-kixelated.6+v0.32.2
run: cargo install uniffi-bindgen-cpp --locked --git https://github.com/kixelated/uniffi-bindgen-cpp --tag v0.11.0-kixelated.7+v0.32.2
- name: Rust compile and tests
if: needs.scope.outputs.rs == 'true'
env:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-cpp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ jobs:
# The tag flake.nix pins; see the comment there.
- name: Install uniffi-bindgen-cpp
shell: bash
run: cargo install uniffi-bindgen-cpp --locked --git https://github.com/kixelated/uniffi-bindgen-cpp --tag v0.11.0-kixelated.6+v0.32.2
run: cargo install uniffi-bindgen-cpp --locked --git https://github.com/kixelated/uniffi-bindgen-cpp --tag v0.11.0-kixelated.7+v0.32.2

# The package version lives in cpp/moq/VERSION; a tag that disagrees is a mistake.
- name: Check version
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-shared-ffi.yml
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ jobs:
- name: Install Rust
uses: dtolnay/rust-toolchain@29eef336d9b2848a0b548edc03f92a220660cdb8 # stable
- name: Install uniffi-bindgen-cpp
run: cargo install uniffi-bindgen-cpp --locked --git https://github.com/kixelated/uniffi-bindgen-cpp --tag v0.11.0-kixelated.6+v0.32.2
run: cargo install uniffi-bindgen-cpp --locked --git https://github.com/kixelated/uniffi-bindgen-cpp --tag v0.11.0-kixelated.7+v0.32.2
- name: Download default-feature input
uses: actions/download-artifact@9000827ccba6bdab643e8b6fd33ac0654aef8333 # v8
with:
Expand Down
2 changes: 1 addition & 1 deletion cpp/moq/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ The generator is a fork, [kixelated/uniffi-bindgen-cpp](https://github.com/kixel
```bash
cargo install uniffi-bindgen-cpp --locked \
--git https://github.com/kixelated/uniffi-bindgen-cpp \
--tag v0.11.0-kixelated.6+v0.32.2
--tag v0.11.0-kixelated.7+v0.32.2
```

`flake.nix` pins the same tag and lists every other place that names it.
Expand Down
6 changes: 3 additions & 3 deletions flake.nix
Original file line number Diff line number Diff line change
Expand Up @@ -408,16 +408,16 @@
# Move back upstream once one tags both.
uniffi-bindgen-cpp = pkgs.rustPlatform.buildRustPackage rec {
pname = "uniffi-bindgen-cpp";
version = "0.11.0-kixelated.6+v0.32.2";
version = "0.11.0-kixelated.7+v0.32.2";

src = pkgs.fetchFromGitHub {
owner = "kixelated";
repo = "uniffi-bindgen-cpp";
rev = "v${version}";
hash = "sha256-r0O/iAad2Z82KhG+6AOvqESAktaR7THQQVoR2CyP+ok=";
hash = "sha256-nErLn2hQus5omIaFheJWy06wKQS9HiKNtksxaJm9Z8k=";
};

cargoHash = "sha256-0YWQF8eSUsemU0Y3jgZh7Kgtno/58zBAxPYpcBwPRuk=";
cargoHash = "sha256-fz7fn6D12zmFFSVSdySDfNRtQe+n4KCB9bXAsuvq/QY=";

# The workspace's other member is the fixture crate, which pulls the
# uniffi examples in from git; build only the generator.
Expand Down
1 change: 0 additions & 1 deletion quest/m1/c/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,4 +68,3 @@ requests internally and keeps its ABI, so that quest does not wait here.
- [moq-c package](/quest/m1/c/package.md) - the generated header ships as `moq-c` 0.8.0 with `moq::c`, pkg-config, and a release workflow
- [C consumers](/quest/m1/c/consumers.md) - the C interop client and `doc/lib/c` samples move onto the generated API
- [Async failure contract](/quest/m1/c/async-failure-contract.md) - a generated async call that fails early fires no callback, and one that started always delivers its terminal callback
- [Durations in generated C](/quest/m1/c/duration.md) - the C backend renders UniFFI's `Duration` instead of refusing it
25 changes: 0 additions & 25 deletions quest/m1/c/duration.md

This file was deleted.

11 changes: 5 additions & 6 deletions quest/m1/ffi-durations.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,14 @@ breaks these options this release, so binding users migrate them once.
Checked 2026-10-23 against the pinned generators: UniFFI's builtin
`Duration` maps to `time.Duration` in Go, Dart's `Duration`, and
`std::chrono` nanoseconds in C++, and Python, Swift, and Kotlin are built
into UniFFI. Only the generated C refuses it, which the C prerequisite below
fixes.
into UniFFI. The generated C renders it as `moq_duration`, `int64_t`
nanoseconds like C++, since `uniffi-bindgen-cpp` `v0.11.0-kixelated.7`.
C and C++ abort on a duration past `INT64_MAX` nanoseconds (about 292
years), so moq-ffi must not hand out a saturated `Duration::MAX` where it
clamps to `u64::MAX` microseconds today (`auth.rs`, `session.rs`).

Public API: moq-ffi, moq-c, every wrapper breaking. Wire: none.

## Required

- [Durations in generated C](/quest/m1/c/duration.md) - the C backend renders UniFFI's `Duration` instead of refusing it

## Related

- [Exact timestamps in every binding](/quest/m1/binding-timestamps.md) - the same move for media timestamps
2 changes: 1 addition & 1 deletion rs/moq-ffi/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ generate_bindings() {

# C++ uses a third-party bindgen too: a fork carrying LiveKit's async support
# ported to uniffi 0.32, which upstream has not released. Install it with:
# cargo install --locked uniffi-bindgen-cpp --git https://github.com/kixelated/uniffi-bindgen-cpp --tag v0.11.0-kixelated.6+v0.32.2
# cargo install --locked uniffi-bindgen-cpp --git https://github.com/kixelated/uniffi-bindgen-cpp --tag v0.11.0-kixelated.7+v0.32.2
if command -v uniffi-bindgen-cpp >/dev/null 2>&1; then
echo " Generating cpp bindings..."
uniffi-bindgen-cpp --library "$lib_path" \
Expand Down
Loading