Repository navigation
Conversation
This was referenced Oct 9, 2026
BubbleCal
force-pushed
the
yang/layered-rq-cache-pins
branch
from
October 9, 2026 18:55
ffb720a to
e003e44
Compare
BubbleCal
added this pull request to stack #9866
October 10, 2026 04:37
BubbleCal
marked this pull request as ready for review
October 10, 2026 11:11
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Contributor
There was a problem hiding this comment.
✅ Gate recommendation: approve.
The earlier capacity bypass is fixed: lease ownership remains shared, while each admission retains its own budget reservation and eviction flag. Both original capacity reproducers and all 130 cache tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resident columns now use Arc ownership, a Weak registry and ordinary cache admission in #9835. The active stack no longer depends on this pin/lease implementation.
Historical description
Add CachePin/CacheLease and per-shard pin budgets so live owners can retain resident cache entries within a bounded budget. Include single-flight admission, replacement accounting, lease lifetime, and overflow coverage.
Lease ownership is shared by the value, while each live cache admission owns its budget reservation and eviction flag. Reusing a value under multiple keys or in multiple backends cannot transfer or reuse another admission's charge. Ending an admission releases only its reservation; replacements can reserve the freed capacity in the same budget partition. Public signatures are unchanged.
Dependencies
Uses the cache capabilities from merged #9829. Standalone benchmark/POC tools remain excluded.
Validation
On macOS arm64 with the repository's Rust 1.98.1 toolchain:
cargo test --locked -p lance-core --lib cache::: 130 passed, including per-admission accounting, release order, shard isolation, replacement, and concurrent admissions.cargo fmt --all -- --checkandcargo clippy --all --tests --benches -- -D warningspassed.No new performance measurement is claimed. CI is not awaited.
Tracking
OSS-2558