fix: use the String API that survives v4.35.0-rc3 - #10
Merged
Merged
Conversation
`String.trim` and `String.dropRight` are removed in v4.35.0-rc3, so `Core/Generate.lean` no longer elaborates there, which in turn breaks any downstream project that builds this package at that toolchain. Move the four sites to `trimAscii` and `dropEnd`. Both return a `String.Slice`, so each call gains the `.toString` that line 1848 of the same file was already using for `trimAsciiEnd`. The replacements have existed since well before v4.33.0 -- the old names were merely deprecated until rc3 removed them -- so this needs no toolchain change here: `lake build` is clean on this package's own v4.33.0 and on v4.35.0-rc3. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves four call sites off
String.trimandString.dropRight, which v4.35.0-rc3 removes.Core/Generate.leanstops elaborating at that toolchain, and because a Lake dependency is built with the root project's toolchain, that breaks any downstream project moving to v4.35.0-rc3 even though this package pins v4.33.0 itself. lean-eval hits it: itslean-evalexecutable fails to build with fourInvalid fielderrors from this file.The replacements are
trimAsciianddropEnd. Both return aString.Slicerather than aString, so each call gains the.toStringthat line 1848 of this same file was already using fortrimAsciiEnd.No toolchain change is needed here. The replacements have existed since long before v4.33.0 and the old names were merely deprecated until rc3 removed them, so
lake buildis clean both on this package's own v4.33.0 and on v4.35.0-rc3.🤖 Prepared with Claude Code