Skip to content

fix: use the String API that survives v4.35.0-rc3 #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kim-em merged 1 commit into from
Sep 28, 2026
Merged

fix: use the String API that survives v4.35.0-rc3 #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions LeanEvalGenerator/Core/Generate.lean
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ def RootRequire.ofSpec (spec : DependencySpec) : RootRequire :=
{ name := spec.name, git := some spec.git, rev := some spec.rev }

private def nonEmptyTrimmed? (value? : Option String) : Option String :=
value?.bind fun v => let v := v.trim; if v.isEmpty then none else some v
value?.bind fun v => let v := v.trimAscii.toString; if v.isEmpty then none else some v

/-- The `[[require]]` to emit for a selected root require, or an explanation of
why a standalone workspace cannot reproduce it. -/
Expand Down Expand Up @@ -1851,8 +1851,8 @@ def injectSolutionHoleModifiers (signature basename : String) : Option String :=
if trimmed == noncomputableKw then
""
else if trimmed.endsWith noncomputableKw &&
(trimmed.dropRight noncomputableKw.length).back.isWhitespace then
trimmed.dropRight noncomputableKw.length
(trimmed.dropEnd noncomputableKw.length).toString.back.isWhitespace then
(trimmed.dropEnd noncomputableKw.length).toString
else
prefixText
let trimmedPrefix := prefixText.trimAsciiEnd.toString
Expand Down Expand Up @@ -2919,7 +2919,7 @@ def buildHolesMetadata (root : System.FilePath) (entry : EvalProblemMetadata)
let startOff ← src.offsetForLineColumn e.startLine e.startColumn
let endOff ← src.offsetForLineColumn e.endLine e.endColumn
let bodyRaw := Source.slice src startOff endOff
let body := (stripProblemMarkers bodyRaw).trim
let body := (stripProblemMarkers bodyRaw).trimAscii.toString
holes := holes.push <| ojObj #[
("name", ojStr e.declarationName),
("basename", ojStr (lastComponentStr e.declarationName)),
Expand Down
Loading