Conversation
SwipeBackSceneContent registers a PredictiveBackHandler that is always enabled. On the root screen (no previous entry) it still consumed the back gesture/button, so pressing back did nothing instead of leaving the app. Only enable it when there is a previous entry to go back to. The onboarding BackHandler had the same problem on its first page; enable it only while the carousel can scroll backward. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pressing back on the root screen did nothing: the app never closed.
Cause:
SwipeBackSceneContentregisters aPredictiveBackHandlerthat is always enabled. On the root entry (nopreviousEntry) it still consumed the back event, then only animated and called anonDismissthat did nothing.BackHandlerhad the same problem on its first page.Fix:
PredictiveBackHandler(enabled = previousEntry != null).BackHandler(enabled = state.canScrollBackward)in onboarding.Testing
On a Galaxy S26 Ultra (One UI 9.0), with the app open on the device list, I sent
adb shell input keyevent KEYCODE_BACK. The top resumed activity changed fromme.kavishdevar.librepods/.presentation.activities.MainActivityto the launcher.The onboarding change hasn't been exercised on the device yet; it has only been built.
🤖 Generated with Claude Code