Skip to content

android(fix): back button/gesture doesn't exit the app from the root screen #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
QuerTeal wants to merge 1 commit into
base: android/rewrite
Choose a base branch
from
Open

android(fix): back button/gesture doesn't exit the app from the root screen #809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion android/app/src/main/kotlin/me/kavishdevar/librepods/presentation/navigation/SwipeBack.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,8 @@ private fun <T : Any> SwipeBackSceneContent(
}
}

PredictiveBackHandler { progressFlow ->
// only intercept back when there is a screen to go back to, otherwise let the activity handle it (exit the app)
PredictiveBackHandler(enabled = previousEntry != null) { progressFlow ->
try {
progressFlow.collect { backEvent ->
if (previousEntry == null) return@collect
Expand Down
2 changes: 1 addition & 1 deletion .../main/kotlin/me/kavishdevar/librepods/presentation/screens/onboarding/OnboardingScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ fun OnboardingScreen(

val animationScope = rememberCoroutineScope()

BackHandler {
BackHandler(enabled = state.canScrollBackward) {
animationScope.launch {
if (state.canScrollBackward) {
val targetItem = if (isSupported && state.currentItem == 3) 1 else state.currentItem - 1
Expand Down