Repository navigation
GameInput v4 support - #16590
Merged
Merged
GameInput v4 support#16590
Conversation
slouken
commented
Oct 25, 2026
slouken
commented
Collaborator
- I confirm that I am the author of this code and release it to the SDL project under the zlib license. This contribution does not contain code from other sources, including code generated by a Large Language Model ("AI").
This PR fixes the compilation errors introduced with updating to GameInput v4.
This simplifies the logic and we know we're building against GameInput v4. GameInput v0 support is still there for Xbox
madebr
reviewed
Oct 25, 2026
| #endif | ||
|
|
||
| #if GAMEINPUT_API_VERSION != 0 && GAMEINPUT_API_VERSION < 4 | ||
| #error Only GameInput v0 and v4 or newer are supported |
Contributor
There was a problem hiding this comment.
Is that true? We just found out gameinput v4's api is incompatible with v3's api.
The gameinput dll usually implements all interfaces.
Collaborator
Author
There was a problem hiding this comment.
Is is now. This change simplifies the mental gymnastics when writing GameInput support. :)
The assumption here is that when 3.6 releases any games that rely on GameInput functionality will either ship with the redist or Windows update will have installed it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.