Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
⏳ DRAFT
What to do
Review readiness checklist
0/4 boxes ticked. This pull request was already a draft. Its draft status will be preserved after every issue above is resolved. |
|
@lidge-jun This draft is blocked by @Ingwannu Both failed checks ( |
|
For the explicit review request: I confirmed head Cross-platform CI |
A custom native v1 compact send used whatever headers the pool recovery branches handed it. The 401 refresh replay and the quota/transient alternate-account sends materialize stored ChatGPT credentials, so a gateway row that ever carried a Codex account mode would receive them. Today the router pins the only pool-mode row to the canonical URL; this makes the gateway boundary hold locally instead of depending on that pin. Gateway sends now always use the gateway transport's headers, and pool recovery and pool outcome recording skip gateway transport.
|
Being carried into #7217 with your authorship preserved; this PR will be closed when the bundle lands. |
#6759, #6930, #6603, #6758) (#7217) Carried from #6759, #6930, #6603, #6758 (one commit per source PR, original authors preserved). Retention across account/model switches is opt-in and defaults off. Remote validation (hosted GitHub Actions unreliable; local tests not run by maintainer rule): union candidate codex/prr-integ-8 = dev c03eafd + #7224 + #7223 + #7225 + #7217 + #6454 + #6594 plus a Gentle Shell import-cycle fix (integ-9 e1f289c: typecheck + full suite on mini (Windows) and lidge (Linux), compared with the same host's dev runs) and a test-only Windows path-escaping fix for the reasoning-retention routing test (integ-10 0d4cba7, tree a2b309a: that file re-run on both hosts). Co-authored-by: fliaping <269832017@qq.com> Co-authored-by: panyuanyuan <panyuanyuan@hetao101.com> Co-authored-by: yuanyuanlove <yuanyuanlove@users.noreply.github.com>
Summary
compaction_trigger(supportsNativeCompactionTrigger) and v1/responses/compact(supportsNativeCompactEndpoint) on customopenai-responsesproviders. Custom gateways keep portable summaries by default. Neither flag implies ciphertext replay (decodesNativeCompactionBlobs), OpenAI identity, or permission to forward caller credentials.src/adapters/openai-responses/transport.ts) for key/local/forward routes, plus ordinary replay sanitization: explicit plaintext/metadata preservation, null-channel omission, drop-reasoning and strict adjacency policy. Generic OAuth providers stay on routed compaction with their existing credential selection, refresh and dispatch fence; native v2 remains independent.nativeCompactResponseSchema) before serving/replay provenance is committed. Failed, empty or malformed HTTP 200 bodies keep the prior identity. Cross-provider overrides and the v1 fallback stay portable.openai) to the canonical URL; the boundary now holds locally (tests/responses/native-compaction-gateway-credentials.test.ts).structure/notes are updated.Original contribution by @fliaping (
61afaab15); maintainer follow-ups throughb93c76f93; this push merges currentdevand adds the gateway recovery guard.Verification
Head
ae286e2ca60e0c66d133acb9c089eca2cc6eac50, merged withdev7640a942b350(0 behind at push). Normal fast-forward push to the contributor branch; no rebase or force push. Merge conflicts were only in docs,structure/and test-layout files and were resolved by keeping both sides.OCX_TEST_NO_QUEUE=1 OPENCODEX_HOME=$(mktemp -d) CODEX_HOME=$(mktemp -d) bun scripts/test.ts --parallel=1over 27 files (allnative-compaction-*,responses-compaction*incl.-http-isolation,responses-pool-401-refresh,compact-transient-alternate,responses-compact-handoff-admission,responses-canonical-only-top-level-fields,responses-opaque-blob-recovery,opaque-blob-wrapped-rejection,openai-responses-passthrough, reasoning-replay identity/robustness/scope-source,deepseek-reasoning-replay,test-layout,test-layout-tooling,file-size-ratchet,core-lab-boundary): 952 pass / 0 fail.bun run typecheck,bun run structure:check,bun run privacy:scan: exit 0.ae286e2ca: PASS, no P0–P3 findings, covering credential forwarding on every compact send path, OAuth exclusion, editor field policy, and replay/provenance binding.bun run test,bun run test:changed(its import graph selects ~1.8k files for this change), and the docs-site build (it last passed atb93c76f93; this push only merges one docs sentence). Cross-platform CI on the exact head: https://github.com/lidge-jun/opencodex/actions/runs/38714586378Checklist
Review readiness checklist