Repository navigation
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
✅ Deterministic PR hygiene checks passed. |
Contributor
⏳ DRAFT
What to do
Review readiness checklist
0/4 boxes ticked. This PR stays in draft until every box above is ticked. |
lidge-jun
pushed a commit
that referenced
this pull request
Oct 15, 2026
added 2 commits
October 15, 2026 18:47
Every row split carried a fixed 528px minimum, which only fits two panes. Splitting right three times put two nested row splits inside 50% tracks, so at the 1100px desktop default window (and up to ~2000px) two panes were hidden behind a horizontal scrollbar inside a pane column. A track holding a nested split now reserves that subtree's minimum width; leaf panes still follow the saved ratio, and an oversized tree scrolls the pane surface once.
…g panes React Doctor (PR gate) flagged a pure helper rebuilt on every SplitBranch render and an array lookup inside the reconcile loop.
2 of 3 tasks
Owner
|
Being carried into #7223 with your authorship preserved; this PR will be closed when the bundle lands. |
lidge-jun
added a commit
that referenced
this pull request
Oct 16, 2026
…d Gentle Shell (#7195, #6767, #6691, #7213) (#7223) Carried from #7195, #6767, #6691, #7213 (one commit per source PR, original authors preserved). #4649 held for security review. Security review follow-up: the Windows picker relay binds only when picker activation or selected-profile recovery needs it. Remote validation (hosted GitHub Actions unreliable; local tests not run by maintainer rule): union candidate codex/prr-integ-8 = dev c03eafd + #7224 + #7223 + #7225 + #7217 + #6454 + #6594 plus a Gentle Shell import-cycle fix (integ-9 e1f289c: typecheck + full suite on mini (Windows) and lidge (Linux), compared with the same host's dev runs) and a test-only Windows path-escaping fix for the reasoning-retention routing test (integ-10 0d4cba7, tree a2b309a: that file re-run on both hosts). Co-authored-by: xianhongtao <xianhongtao2022@outlook.com> Co-authored-by: 김민우 <minwokim@gmarket.com> Co-authored-by: hyuntae park <bluestar218ht@gmail.com> Co-authored-by: randalo-trc <randalo@trociuk.com>
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0c0101295b608be3275a72e5e9e97c639f640408), mergeorigin/devat7640a942b35044c974e534b84d5a8049f4a8ae9a, and add the narrow-screen/focus fixes and persistence regression coverage. Review commitcf49793c4fixes nested side-by-side splits: every row split had a fixed 528px minimum, so splitting right three times hid two panes behind a horizontal scrollbar inside a pane column at the 1100px desktop default (and at any width up to ~2000px). A track holding a nested split now reserves that subtree's minimum width; leaf panes still follow the saved ratio, and an oversized tree scrolls the pane surface once. Update the English/Korean guides and ownership documentation. No new repository dependencies.Verification
Current head
cf49793c41b9cb3457ab88a0271b0d61ab89e58d(0 behinddev7640a942b).cf49793c4):cd gui && bun run test3,339 passed, 0 failed, 344 files; focused split/workspace files 23 passed, 0 failed;guitsc --noEmit -p tsconfig.app.json,bun run lint,bun run lint:i18n, rootbun run build:gui,bun run typecheck,bun run structure:check,bun run privacy:scan,git diff --checkpassed. Browser (Chrome Headless Shell 154 against the built GUI on a sandboxed proxy, port 18791, synthetic/api/remote-workspaceresponses): real mouse drag moves the divider 50→70 with the separator focused, clamps at 80 past the container edge, stops on release; ArrowLeft → 75, persisted and restored after reload; 700px stacks with no divider and 0px document overflow, widening restores 75. Four panes split in one row at 900/1100/1280px: before the fix 2 split children overflowed sideways; after, 0 overflow, all panes 260px, one surface scroll (1,064px). A two-pane 0.75 split renders at 74%. Roottest:changedwas not rerun for this GUI/CSS-only commit.The items below are the earlier validation of head
2b49b5eabb0df0497828a96230f4700b9650642c. Every local test and proxy used freshOPENCODEX_HOME=$(mktemp -d)andCODEX_HOME=$(mktemp -d); screenshot proxies listened on ports 18677 and 18678. Bun test runner: 1.4.3.cd gui && bun ../scripts/test-with-pinned-bun.ts --isolate tests/remote-workspace-split.test.tsx tests/remote-workspace-split-layout.test.ts tests/remote-workspace.test.tsx: 22 passed, 0 failed, 3 files. Covers both resize axes, Home/End bounds, restored sizes, draft exclusion, cold-load restoration, session-scoped requests and late Stop responses.cd gui && bun run test: final unchanged-head rerun 3,338 passed, 0 failed, 344 files. The first full run had 3,337 passed, 1 failed in the unchangedremote-link.test.tsxtest “discovery loading, empty setup and rescan retain keyboard-accessible manual entry” (focus at line 927).bun ../scripts/test-with-pinned-bun.ts --isolate tests/remote-link.test.tsxthen passed 48/48 on both this head and cleanorigin/dev. The clean-dev full GUI suite passed 3,328/3,328, and the final PR full rerun passed as above. No unrelated focus code was changed; this records the transient full-run failure rather than treating the initial run as green.OCX_TEST_NO_QUEUE=1 bun run test:changed: 212 passed, 0 failed, 14 files, against theorigin/devmerge base above. The first queued attempt was cancelled while another worktree held the user lock; the explicit short overlap completed successfully.bun run typecheck,bun run structure:check,bun run privacy:scan, andgit diff --checkpassed.bun test tests/ci-workflows/file-size-ratchet.test.ts: 9 passed, 0 failed. The initial structure check caught a 602/600-line desktop document after the dev merge; clean dev passed, and condensing this PR's note restored the budget.cd gui && bun run lint,bun run lint:i18n, and rootbun run build:guipassed. Vite retains its large-chunk warning. The cleanorigin/devGUI build also passed for the before capture.cd docs-site && bun install --frozen-lockfile && bun run buildpassed: 577 pages, 81,206 internal links checked./Applications/Google Chrome.app(browserType.launch: Timeout 10000ms exceeded.). Captures and browser checks therefore used GOAT's installed Chrome Headless Shell 154.0.8037.92, driven byplaywright-coreinstalled only in scratch space outside the repository.rustfmtis unavailable locally; its check and native desktop compilation/OS-webview drag/drop were not validated here. The native change disables Tauri's native drag/drop interception so HTML pane dragging reaches the dashboard. Native platform evidence remains for CI/maintainer acceptance.cf49793c4(the earlier2b49b5eabrun was cancelled as superseded). Dispatched withgh workflow run ci.yml --repo lidge-jun/opencodex --ref ci/pr-6767; queued at handoff, not passing evidence. The PR remains draft; no merge is authorized by this validation.Before — real
origin/devbuild at7640a942b35044c974e534b84d5a8049f4a8ae9a, synthetic session snapshot:After — real PR-head build at
2b49b5eabb0df0497828a96230f4700b9650642c, the same synthetic sessions:After — 390px viewport with stacked panes:
After the nested-split fix — head
cf49793c4, 1100px desktop default, four sessions split right in one row, pane surface scrolled to its end (every pane reachable through one surface scroll):Screenshots are committed only on
pr-assets, never on this PR branch.Checklist
Review readiness checklist
This contributor PR remains draft pending CI and maintainer/native acceptance.