fix(anthropic): rebind reasoning-replay owner after pool rotation

[vadymhimself]

Summary

• The Anthropic OAuth pool rotation arms (429/403/401) in main adapter dispatch (adapter-dispatch.ts) and the terminal continuation retry (adapter-continuation.ts) commit the next account B but never rebind the route's replay scope. commitResolvedOAuthSelection already updates replayOAuthCredentialSnapshot, but nothing calls bindRouteReasoningReplayScope with it, so the reasoning-replay serving identity, the native-reasoning owner and the provider-continuation owner stay bound to the refused account A.
• Observed effects on dev (reproduced by the new test):
  • B's retry is built with A's provider-private continuation (private-a).
  • The turn served by B is persisted with __ocxOwner.credentialIdentity = A.
  • The next turn on B, same thread, finds a serving-identity change. It sets _stripReasoningEncryptedContent, which makes the Anthropic adapter drop replayed thinking blocks, and it discards B's continuation as foreign. The client loses reasoning continuity, and the changed history breaks the prompt-cache prefix, so the cache gets written again.
• Fix: after admission, rebind with transportState.replayOAuthCredentialSnapshot. This is the same call the key-429 and generic OAuth (Kiro/Antigravity) arms already make. The continuation arm rebinds both nextParsed and the outer parsed that persists the response, as its key-429 arm does. No new helper or state.
• The rotated send to B still strips A's reasoning blobs, because the strip flag stays set for the whole outbound request. Only the persisted owner and the next turn change.
• Kept off the recovery-kind ternary lines that open PR fix(anthropic): record account 403 rotations as oauth-account-403, not a 429 #7185 edits. git merge-tree against that branch merges cleanly.

Verification

• Red on dev (60bf4c7) with the source change reverse-applied: both new tests/adapters/terminal-continuation-owner-rotation.test.ts cases (Anthropic pool rotation on the initial send … and … on the terminal continuation …) fail. The persisted owner is A, B's build carries private-a, and the follow-up build on B has stripReasoning: true with no continuation.
• Green after the fix: bun test tests/adapters/terminal-continuation-owner-rotation.test.ts gives 3 pass, 0 fail.
• bun run typecheck: passes.
• bun run structure:check: passes.
• bun run privacy:scan: passes.
• bun run test:changed (against dev 60bf4c7): 14561 pass, 1 fail across 575 files. The failure is tests/cli/cli-connect-readiness.test.ts › connected-client runtime probe scope > a rejected preferred runtime falls back without rewriting the saved selection. It also fails on a clean dev worktree and is unrelated to this change.
• I did not run the full bun run test locally. test:changed covers the import graph of both changed source files, and CI covers the rest.
• No GUI changes.

Checklist

• Scope stays focused and avoids unrelated cleanup.
• Docs or release notes were updated when needed.
• Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes
  • Improved Anthropic account failover when a request is rate-limited. Retries and ongoing terminal continuations now consistently use the selected account and its session state, reducing the risk of interrupted or mismatched responses.
  • Improved handling of protected reasoning content during account changes, with appropriate safeguards applied when requests are retried.

Review readiness checklist

This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:

• Required local validation passed; commands, results, and any full-suite exception are documented.

• I pushed my PR to a recent dev commit (at most 10 behind; a maintainer may still ask for the exact tip before merge).

• I resolved all correct Codex and CodeRabbit findings.

• My PR is ready for review.

[vadymhimself]

@coderabbitai review

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository: lidge-jun/opencodex/.coderabbit.yaml
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: d75b68b6-7e3a-4a88-b77e-022eea43b35c

📥 Commits

Reviewing files that changed from the base of the PR and between 60bf4c7 and ac78226.

📒 Files selected for processing: 3

• src/server/responses/adapter-continuation.ts
• src/server/responses/adapter-dispatch.ts
• tests/adapters/terminal-continuation-owner-rotation.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review.

📝 Walkthrough

Anthropic OAuth account failover now binds the replay credential snapshot to the parsed request and continuation clone. Tests cover rotation from account A to account B during initial sends and terminal continuations.

Changes: Anthropic OAuth Rotation

Layer / File(s)	Summary
Bind replay scope after rotation src/server/responses/adapter-dispatch.ts, src/server/responses/adapter-continuation.ts	The failover paths bind the replay reasoning scope to the replay OAuth credential snapshot. The continuation path applies this binding to both nextParsed and the outer parsed request.
Verify rotated account ownership tests/adapters/terminal-continuation-owner-rotation.test.ts	Parameterized tests cover initial sends and terminal continuations. They check account authorization order, response ownership, provider continuation state, and whether reasoning is stripped. Test setup and teardown also clear Anthropic account-pool state.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~15 minutes

Change: Bug fix

Suggested reviewers: lidge-jun

Merge Risk: ⚪ Minimal · up to ac782

The reviewed rotation paths bind replay ownership to the admitted account. No actionable merge-blocking risk remains after normal checks.

Pre-merge checks: 5

Check name	Status	Explanation
Docstring Coverage		Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 3 files.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly identifies the Anthropic fix and the specific reasoning-replay ownership issue after OAuth pool rotation. It accurately summarizes the main change.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[github-actions]

✅ Deterministic PR hygiene checks passed.

[github-actions]

⏳ DRAFT

• review readiness checklist open (0/4 boxes ticked).

What to do

• Tick all four boxes in the PR description once you're done (currently 0/4).

Review readiness checklist

• ⬜ Required local validation passed; commands, results, and any full-suite exception are documented.
• ⬜ I pushed my PR to a recent dev commit (at most 10 behind; a maintainer may still ask for the exact tip before merge).
• ⬜ I resolved all correct Codex and CodeRabbit findings.
• ⬜ My PR is ready for review.

0/4 boxes ticked.

This PR stays in draft until every box above is ticked.

[lidge-jun]

Being carried into #7224 with your authorship preserved; this PR will be closed when the bundle lands.

[lidge-jun]

Landed on dev in 6ccb47a via #7224 (your change is its own commit in that bundle, and the squash keeps your authorship as Co-authored-by). Thank you!