Skip to content

feat: add Gentle Shell as an independent Connect target - #7213

Closed
rjoleinik wants to merge 1 commit into
lidge-jun:devfrom
rjoleinik:feat/gentle-shell-connect
Closed

rjoleinik wants to merge 1 commit into
lidge-jun:devfrom
rjoleinik:feat/gentle-shell-connect

Conversation

@rjoleinik

@rjoleinik rjoleinik commented Oct 15, 2026 •

Copy link
Copy Markdown

Summary

Adds Gentle Shell as a first-class, independent Connect integration target (issue #7208). Gentle Shell reuses the existing Pi protocol and serialization with its own distinct paths, ownership rules, journal, registry entry, GUI surface, and refresh enrollment — it does not share or alias the Pi client.

  • New src/clients/gentle-shell-path.ts with strict persistent-home validation (refuses shared/link/Pi/relative/malformed/unreadable destinations).
  • Wiring across the integrations registry, catalog refresh, mutation plans, and ocx export --client (roster grows 19 → 20).
  • CLI help and structure/ docs updated; GUI integrations tab, marks, overview, API, and FileIntegrationPage extended; i18n strings added for all 10 locales (en, de, es… zh, zh-TW, ja, ko, pt, ru, tr, vi).
  • Tests for the gentle-shell client, path validation, integrations state, config export, GUI invariants, and layout fixtures.

Verification

Focused suites on this branch (based on dev @ b6dffa0), Bun 1.4.3:

  • bun test tests/clients/gentle-shell-path.test.ts tests/clients/gentle-shell-client.test.ts tests/clients/integrations-state.test.ts tests/config/client-config-export.test.ts tests/test-layout.test.ts — 149 pass / 0 fail
  • bun test tests/gui/integrations-invariants.test.ts — 51 pass / 0 fail (includes the "CLI names every client it supports" invariant)
  • cd gui && bun test tests/integration-marks.test.ts tests/integrations-tab-coverage.test.ts — 13 pass / 0 fail

Screenshot of the new Gentle Shell integration page (asset per CONTRIBUTING.md pr-assets branch):

Gentle Shell integration page

Checklist

  • Scope stays focused and avoids unrelated cleanup.
  • Docs or release notes were updated when needed.
  • Security-sensitive changes were reviewed for secrets, auth, and unsafe defaults.

Refs #7208

Review readiness checklist

This PR stays in draft until every box below is ticked. Tick all four boxes once the requirements are met:

  • Required local validation passed; commands, results, and any full-suite exception are documented.

  • I pushed my PR to a recent dev commit (at most 10 behind; a maintainer may still ask for the exact tip before merge).

  • I resolved all correct Codex and CodeRabbit findings.

  • My PR is ready for review.

Add Gentle Shell as a first-class, independent Connect integration that
reuses the existing Pi protocol and serializer with its own paths,
ownership, journal, registry entries, GUI surface, and refresh enrollment.

- new src/clients/gentle-shell-path.ts with strict persistent-home validation
- registry, catalog-refresh, mutation-plan, and export wiring for the new client
- CLI help, integration plan DTO, and structure docs updated
- GUI: integrations tab, marks, overview, API, FileIntegrationPage, i18n (10 locales)
- tests: gentle-shell client/path/state, export, GUI invariants, layout fixtures

Refs lidge-jun#7208
@coderabbitai

coderabbitai Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lidge-jun

Copy link
Copy Markdown
Owner

Being carried into #7223 with your authorship preserved; this PR will be closed when the bundle lands.

@github-actions

Copy link
Copy Markdown
Contributor

✅ Deterministic PR hygiene checks passed.

@github-actions github-actions Bot added the enhancement New feature or request label Oct 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

⏳ DRAFT

  • review readiness checklist open (0/4 boxes ticked).

What to do

  • Tick all four boxes in the PR description once you're done (currently 0/4).

Review readiness checklist

  • ⬜ Required local validation passed; commands, results, and any full-suite exception are documented.
  • ⬜ I pushed my PR to a recent dev commit (at most 10 behind; a maintainer may still ask for the exact tip before merge).
  • ⬜ I resolved all correct Codex and CodeRabbit findings.
  • ⬜ My PR is ready for review.

0/4 boxes ticked.

This PR stays in draft until every box above is ticked.

lidge-jun added a commit that referenced this pull request Oct 16, 2026
…d Gentle Shell (#7195, #6767, #6691, #7213) (#7223)

Carried from #7195, #6767, #6691, #7213 (one commit per source PR, original authors preserved). #4649 held for security review. Security review follow-up: the Windows picker relay binds only when picker activation or selected-profile recovery needs it.

Remote validation (hosted GitHub Actions unreliable; local tests not run by maintainer rule): union candidate codex/prr-integ-8 = dev c03eafd + #7224 + #7223 + #7225 + #7217 + #6454 + #6594 plus a Gentle Shell import-cycle fix (integ-9 e1f289c: typecheck + full suite on mini (Windows) and lidge (Linux), compared with the same host's dev runs) and a test-only Windows path-escaping fix for the reasoning-retention routing test (integ-10 0d4cba7, tree a2b309a: that file re-run on both hosts).

Co-authored-by: xianhongtao <xianhongtao2022@outlook.com>
Co-authored-by: 김민우 <minwokim@gmarket.com>
Co-authored-by: hyuntae park <bluestar218ht@gmail.com>
Co-authored-by: randalo-trc <randalo@trociuk.com>
@lidge-jun

Copy link
Copy Markdown
Owner

Landed on dev in a8d1bb8 via #7223 (your change is its own commit in that bundle, and the squash keeps your authorship as Co-authored-by). Thank you!

@lidge-jun lidge-jun closed this Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants