Repository navigation
feat(cli): add --json to slm runs list - #17
Merged
Merged
Conversation
sandeeps85
approved these changes
Oct 15, 2026
sandeeps85
left a comment
Contributor
There was a problem hiding this comment.
Thanks @kukirin-ui, and thanks for asking on #13 first and laying out your plan. That's exactly how we'd like issues picked up. Sorry nobody answered you in time; that's on us.
What I checked
make lint, andmake testwithabc2midiinstalled: everything passes, including your three tests. The grader failures you saw were only the missing tool.- On real runs:
slm runs list --json --project shakespeare_chargives the 3 reference runs, each with its fullstatus.jsonfields, and| python3 -m json.toolworks. - Setting
run_idfrom the directory name is a nice touch. Current runs already write it intostatus.json, but this way the output never depends on that.
I'll add the --json example to the command list in CONTRIBUTING.md on our side. Approving; merging once CI is green.
3 tasks done
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a --json flag to
slm runs list. It prints only a JSON array, one object per run with the run ID and everything from its status.json, souv run slm runs list --json | python3 -m json.toolworks. It goes through the same --project filter as the table, and an empty result is just[].Tests in tests/unit/test_runs.py parse the output with json.loads, check both runs are there and that --project filters. Also added a CHANGELOG line under Unreleased.
ruff check/format are clean and the new tests pass. Locally the only failures in
make testare the abc_music grader tests, which need abc2midi installed.Closes #13