Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Tailscale's installer adds its folder to the system PATH, but sshd and every shell already open keep the old PATH until restarted, so `pair` missed the Tailscale name and address and the code carried only the local network one. Fall back to %ProgramFiles%\Tailscale\tailscale.exe on Windows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The pairing screen and the README say Windows' interpreter is usually python, and the README's Windows paragraph names what herdr-core gives there rather than a list of screens. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
makefunstuff
added a commit
that referenced
this pull request
Nov 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The app can now reach a Windows PC running the Herdr desktop app's herdr-core, over OpenSSH Server with Git for Windows' Bash as its shell.
herdr-push pairalso runs there, so a Windows PC is paired with the QR code like any other machine.What changes
HcDetection: the probe recognises Git Bash (uname -sisMINGW*,MSYS*orCYGWIN*), askshc server status(there is no socket path to read on Windows) and talks to herdr-core withhc connect. Linux and macOS take the same path as before.herdr-push pairon Windows: reads the host keys andsshd_configinC:\ProgramData\ssh; for a user in Administrators, while the stockMatch Group administratorsblock is there, writes toadministrators_authorized_keys(which needs a terminal opened as administrator); writes the one-time key's command with forward-slash paths for Bash; locks withmsvcrtwhere there is nofcntl; finds Tailscale's CLI in%ProgramFiles%\Tailscalewhen sshd's PATH predates its install. herdr-push goes to version 12; on Windows onlypairruns in this change.DefaultShell) and that the interpreter there is usuallypython.Checks
./gradlew -p core test: 609 tests. I ran them on Windows, where 52 tests already fail on main (Java's quoting ofsh -c, the Microsoft Store'spython3); the same ones fail here and no others;DictationTest's timing test failed once under load and passes on its own. Linux CI is the real check. New cases inHerdrCoreTestrun the real probe script with a fakeunameand a fake core../gradlew :app:testDebugUnitTest: 93 tests; the 13 that fail on main on Windows (file renames,RoutesTest) fail here too, no others.Shots
Dark; light ones beside them in
docs/screenshots/windows-machines/on thepr-shots/windowsbranch of my fork.Part of a series that makes a Windows PC a full herdr machine. Chat (#113), health (#114) and notifications (#115, stacked on this one) on Windows need it to reach the PC; the Python lookup (#110), search (#111) and the brief (#112) with herdr-core alone, and a port-forward crash (#109) stand on their own.
🤖 Generated with Claude Code