Repository navigation
Windows machines: herdr-core over Git Bash, and pairing there (from #108) - #117
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Tailscale's installer adds its folder to the system PATH, but sshd and every shell already open keep the old PATH until restarted, so `pair` missed the Tailscale name and address and the code carried only the local network one. Fall back to %ProgramFiles%\Tailscale\tailscale.exe on Windows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The pairing screen and the README say Windows' interpreter is usually python, and the README's Windows paragraph names what herdr-core gives there rather than a list of screens. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ver it is Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 8, 2026
makefunstuff
added a commit
that referenced
this pull request
Nov 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
puchedev's #108, carried on our branch so it can be fixed here: their 4 commits, main merged in, and one test fix.
The fix:
PushTest.watchesAndSendsstill expected herdr-push version "11" fromstatus, but #108 bumps it to 12, so CI failed. It now compares toHerdrPush.version.The security review (HERD-34) found #108 clean: the probe and
connecton Windows quote every value and never start a core; on Windowspairwrites toadministrators_authorized_keysonly for a user in Administrators under the stockMatch Group administratorsblock, and the one-time key keepsrestrict,expiry-timeand its forced command.Closes #108.
🤖 Generated with Claude Code