Repository navigation
spec(AST-090): touch presentations keep their native exit - #8536
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
AI review status for this pull request.
|
kentonquatman
marked this pull request as ready for review
October 26, 2026 15:53
kentonquatman
requested review from
cixzhang,
imdreamrunner and
josephfarina
as code owners
October 26, 2026 15:53
4 tasks done
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exact decision needed
Whether the
spec:AST-090exit switches reach touch presentations.As it stands on
main, AST-090 ships every dialog and layer exit off, with no exception for touch. Two current records say otherwise for touch presentations:spec:AST-094FR7: a touch presentation plays the exit its UIKit counterpart plays, on every touch platform.design:reduced-motionDR2: under reduced motion, a touch presentation cross-fades (opacity only, 200 ms or less), where AST-090 FR10 closes every surface at once.Existing authority searched
spec:AST-094(current): FR7 (touch exits), FR8 (their reduced-motion form), FR13 (a touch presentation is a coarse primary pointer after hydration; a server render and the hydrating render produce the pointer presentation), FR4 and DEC-11 (touch motion roles stay internal until the public set is decided). Its non-goals leave pointer (desktop) presentations' timing and easing to the theme's duration and easing tokens.design:reduced-motion(current): DR2 (touch cross-fades), DR3 (fine-pointer presentations change at once), DR4 (no opt-out in core).component:PopoverFR9 (current): under a finger, Popover grows out of its trigger and shrinks back into it; a mouse keeps its entrance.component:ContextMenuandcomponent:DropdownMenuuse the same pointer and touch presentation terms.spec:AST-090(draft, onmainfrom spec(AST-090): exits ship off, and a theme turns them on for dialogs and layers #8003).AST-090 is the record to change: AST-094 and design:reduced-motion are current, and AST-090 is the draft that conflicts with them.
Decision
Proposed, pending review by the motion owners (ernestt, cixzhang):
spec:AST-094FR13 and calls every other presentation a pointer presentation. FR1–FR13 apply to pointer presentations.--ease-exit, and--duration-exitdo not change it, whether a theme leaves a kind off or turns it on.design:reduced-motionDR3 and DR4. A touch presentation cross-fades through AST-094 FR8 (DR2).BottomSheet's close reads--ease-exitin a pointer presentation.spec:AST-094,design:reduced-motion), and an FR14 verification row follow from it. OQ1 asks about pointer-presented dialogs.Tokens, defaults, and every pointer-presentation behavior are unchanged.
Rejected alternatives
spec:AST-094FR7 requires.--ease-exitand--duration-exittime touch exits:spec:AST-094FR4 and DEC-11 keep touch motion roles internal until a public set is decided.Claim scope and non-goals
This changes only which presentations AST-090 governs. It does not change:
spec:AST-094, ordesign:reduced-motion;#8004 (
--ease-exit) is unaffected: it changes no behavior, and a touch close follows AST-094 once one ships.Evidence and implementation relationship
spec:AST-094FR13 and non-goals, anddesign:reduced-motionDR2 and DR3, quoted above.Writing rubric results
Rejected:line in DEC-5; the existing ones are unchanged.#followed by digits,/pull/, and/issues/).Scope
Validation
node scripts/check-knowledge.mjs --base origin/main: aligned.git diff --check: clean.