Repository navigation
docs(native): mark the Swift TextInput record current - #9272
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
meta-cla
Bot
added
the
CLA Signed
|
AI review status for this pull request.
|
PR Analysis Report
Generated by PR Enrichment workflow | View current CI run |
![astracat-bot[bot]](https://avatars.githubusercontent.com/in/4796231?s=60&v=4){kind=small}
There was a problem hiding this comment.
This review is waiting on a spec decision: making component:swift/TextInput current needs an engineering owner's approval of the record's content, and none is recorded on this pull request yet. Once the fixes below are pushed, an engineering owner records the decision by commenting /approve-spec <full head SHA> on the pull request; the author may do this as an engineering owner.
- The Compatibility/readiness row (line 33) still says "Draft;" and FR1–FR5 keep the review state
verify; update them to matchauthority: current, or keep the record draft. - Add a
## Writing rubric resultssection to the description, one line per R1–R6 item fromdocs/contributing/spec-writing.md. - The green
spec-owner-approvalstatus is not an approval:.github/scripts/change-scope.cjsdoes not recognise<Name>.<language>.spec.mdpaths, so the gate reported that no knowledge records changed (pnpm check:knowledgeandpnpm specs:forskip these records too, which is worth a separate fix).
[Automated review]
| id: component:swift/TextInput | ||
| platform_of: component:TextInput | ||
| authority: draft | ||
| authority: current |
There was a problem hiding this comment.
This makes the record current, but its Compatibility/readiness row (line 33) still says "Draft;" and FR1–FR5 keep the review state verify. Update them to match, or keep the record draft.
Cindy Zhang approved marking component:swift/TextInput current on 2026-10-31. Sets authority: current with approved_by and approved_at, drops the readiness row's Draft marker and the behavior table's draft review-state column, as current records read. No requirement changes.
There was a problem hiding this comment.
This pull request is waiting on a spec decision. Making component:swift/TextInput current turns FR1–FR5, AV1, ORD1, PR1 and AR1–AR2 into binding requirements, and that needs an engineering owner's approval of the record's content, which is not yet recorded on this head. The green spec-owner-approval status does not count as one: the gate does not yet recognise <Name>.swift.spec.md paths and reported that no knowledge records changed. An engineering owner records the decision by commenting /approve-spec <full head SHA> on this pull request; the author may do so as an engineering owner.
[Automated review]
|
/approve-spec 3c2f627 |
There was a problem hiding this comment.
This pull request is waiting on a spec decision: making component:swift/TextInput current needs an engineering owner's approval of the record's content, and none is recorded yet. The green spec-owner-approval status does not count as one, because the gate does not yet recognise <Name>.swift.spec.md paths and reported that no knowledge records changed. The earlier fixes are in, and an engineering owner records the decision by commenting /approve-spec <full head SHA> on this pull request; the author may do so as an engineering owner.
- The
Touched componentsCI job fails only because this branch predates.github/scripts/touched-components.mjsonmain; updating the branch frommainlets it run.
[Automated review]
There was a problem hiding this comment.
This pull request looks ready to merge: an engineering owner's /approve-spec on this head covers moving component:swift/TextInput to current, the readiness row and behavior table now read as a current record, and no requirement text changed. No further changes are needed here. As a follow-up, the owner gate, pnpm check:knowledge and pnpm specs:for do not yet recognise <Name>.swift.spec.md paths, so later edits to this record will not be routed to owner review until that tooling is fixed.
[Automated review]
1cb6969 to
3c2f627
Compare
|
/approve-spec cabb0ca |
There was a problem hiding this comment.
This pull request looks ready to merge: an engineering owner's /approve-spec on this head covers moving component:swift/TextInput to current, the readiness row and behavior table read as a current record, and no requirement text changed. With the merge from main, the knowledge checker and the spec-owner gate now read this record and pass it. Optionally, refresh the test plan, which still says the checker does not read <Name>.swift.spec.md paths.
[Automated review]
Summary
Marks the Swift TextInput record (
component:swift/TextInput) current. The record merged as a draft with #8310; its engineering owner approved it on 2026-10-31.Change
docs/specs/components/TextInput/TextInput.swift.spec.md:authority: current,approved_by: cixzhang,approved_at: 2026-10-31.No requirement, test, or source changes.
Writing rubric results
R1 narration: none; the record states the system in the present tense.
R2 research: none in the record.
R3 evidence: bases cite records and facts; none names a pull request, issue, or commit.
R4 rejected alternatives: none.
R5 change references: none in the record.
R6 open questions: none.
Test plan
pnpm check:knowledgewith the record at its former path (current records needapproved_byandapproved_at; the checker does not yet read<Name>.swift.spec.mdpaths).