Repository navigation
chore(changeset): the Lab removal note names Core's presentation sheets - #9846
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
AI review status for this pull request.
|
There was a problem hiding this comment.
The change looks good. The corrected note now points readers to the stable presentation prop that Tokenizer and PowerSearch take, instead of the experimental.presentation spelling this release removes, and the Changeset still passes pnpm check:changesets with its tag, package and bump unchanged. The current typecheck and test-node failures come from main (packages/core/src/Tokenizer/TokenizerBottomSheet.test.tsx line 1814 still passes experimental, and a resolution-compat snapshot is stale), not from this change. No changes needed here.
[Automated review]
PR Analysis Report🔎 Preview ·
|
3444476 to
7371b4c
Compare
There was a problem hiding this comment.
The change looks good. The corrected note now points readers to the stable presentation prop that Tokenizer and PowerSearch take, instead of the experimental.presentation spelling this release removes, and the Changeset keeps its tag, package and patch bump and still passes pnpm check:changesets. No changes needed here.
[Automated review]
Reader impact
The next release notes say that the removed Lab
MobileTokenizerandMobilePowerSearchflows live on as "Core's Tokenizer and PowerSearchexperimental.presentationsheets". The same release removes that spelling (#9796, #9797, #9836), so a reader who follows the note reaches an API that no longer exists. The note now points to the stablepresentationprop.Source of truth
presentationprop, and neither readsexperimental(feat(Tokenizer): presentation is a stable prop, and adaptive is its default #9796, feat(PowerSearch): presentation is a stable prop, and adaptive is its default #9797, chore(Tokenizer): remove experimental.presentation; presentation is the only spelling #9836).Correction
In
.changeset/cli-discover-lab-mobile-sheets-removed.md, "Core's Tokenizer and PowerSearchexperimental.presentationsheets" becomes "Core's Tokenizer and PowerSearchpresentationsheets". No other pending Changeset is stale. The two other Changesets that nameexperimental.presentation, Tokenizer's removal note and its codemod note, describe the removal itself.Evidence
A grep of every pending
.changeset/*.mdforexperimental.presentationandexperimental={{presentationfinds three hits. Only this one is stale.Scope
Testing
It is a one-line change to the Changeset text. The tag (
[chore]), the package and the bump are unchanged.