Repository navigation
Expand structured Comments to Note previews - #352
Merged
Merged
Conversation
Reuse the Chat Comment flow for Note rich text with existing conversation destinations, frozen source evidence and explicit hidden-draft discovery. Preserve Ink behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Retain both Note Comment documentation and the current-pointer editing contract. Update the browser regression to exercise readonly selection with touch input rather than switching back to mouse. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Progresses #351 with the approved Comment-only first release. Chat keeps its current conversation and has no picker. Expanded Note rich text gains Copy, Add as note and structured Comment staging into an existing current-Space conversation. The Comment branch never creates or starts an Agent. Ink/Lasso behavior, including its current acceptance-time destination reveal, is unchanged.
canvasId,nodeId,snapshotRevision) together. The revision fingerprints the rendered document at capture, not a server-acknowledged save. Use source-specific Chat/Note prompt wording and escape metadata as untrusted reference content.Validation
pnpm typecheckpassed.pnpm formatandpnpm lint:fixcompleted; lint has zero errors and 334 existing warnings. Focused lint on the new implementation/tests is clean.pnpm check:i18n, license-header check andgit diff --checkpassed.Boundaries and limitations
Only Chat and expanded Note rich text are included. Raw CodeMirror, Canvas Note-card selection, PDF/Web excerpts, ordinary Canvas node-selection Send and Ink redesign remain out of scope. Unsent drafts remain runtime-only and do not survive reload. Chromium touch emulation is covered; real iPad/native selection menus and physical pen hardware have not been verified. CI/review remain required. This PR does not close #351 and grants no merge or release authorization.