Skip to content

Fix broken Dashboard landing anchors and relative docs links - #1995

Merged
David Pine (IEvangelist) merged 3 commits into
mainfrom
aspireagent/fix-docs-prop-and-relative-links
Nov 1, 2026
Merged

David Pine (IEvangelist) merged 3 commits into
mainfrom
aspireagent/fix-docs-prop-and-relative-links

Conversation

@davidfowl

Copy link
Copy Markdown
Contributor

Summary

Fixes seven broken internal links in the English docs. Every locale falls back to these pages, so each broken link appears on all 15 locales. The links validator didn't flag them because it never inspects these two kinds of link:

  • starlight-links-validator runs with errorOnRelativeLinks: false, so it skips ./ and ../ links entirely.
  • It only reads string href attributes. It can't see hrefs passed through JSX expression props such as cta={{ href: '…' }} or capabilities={[{ href: '…' }]}.
Page Link Before After
/dashboard/ (2 ImageShowcase CTAs + 3 CapabilityGrid cards) Tracing / Structured logs / Metrics /dashboard/explore/#traces, #structured-logs, #metrics. These ids don't exist, so the link lands at the top of a long page #traces-page, #structured-logs-page, #metrics-page, the same anchors that dashboard/standalone.mdx and data/dev-hub.ts already use
/reference/cli/commands/aspire-dashboard-run/ Dashboard configuration ../../../dashboard/configuration/ → /reference/dashboard/configuration/ (404) /dashboard/configuration/
/integrations/cloud/azure/azure-cache-redis/azure-cache-redis-host/ Redis Hosting integration ../../../caching/redis/redis-host/#…-redis-insights → /integrations/cloud/caching/redis/redis-host/ (404), and the anchor was misspelled /integrations/caching/redis/redis-host/#add-redis-resource-with-redis-insight

The fixed links are absolute, so starlight-links-validator now checks the two Markdown ones at build time. A new unit test, tests/unit/docs-internal-links.vitest.test.ts, covers the gap for the English docs. It resolves expression-prop href: values and .//../ Markdown links to an existing docs page and, when there's a fragment, to an existing heading id. It follows the existing pattern in dev-glossary.vitest.test.ts and slugs headings with github-slugger, as Starlight does. Like the validator config, it skips /reference/api/ and /hub/.

How this was found

I crawled main's CI frontend-dist artifact, the production build of 29550055 from run 41062457941, covering all 8,327 non-API HTML pages. I checked every internal <a href> against the built files and ids. Before this change the live site behaves as follows:

  • https://aspire.dev/reference/dashboard/configuration/ returns 404.
  • https://aspire.dev/integrations/cloud/caching/redis/redis-host/ returns 404.
  • https://aspire.dev/dashboard/explore/ only has id="traces-page", id="structured-logs-page" and id="metrics-page".

The crawl also found broken links that this PR leaves alone:

Third-party links and affiliations

None.

Validation

  • The regression test fails before the fix with exactly the 7 links above, and passed in 3 of 3 runs after it. Before-fix output:
    dashboard/index.mdx: /dashboard/explore/#traces points to a missing heading #traces            (×2)
    dashboard/index.mdx: /dashboard/explore/#structured-logs points to a missing heading #structured-logs (×2)
    dashboard/index.mdx: /dashboard/explore/#metrics points to a missing heading #metrics
    integrations/cloud/azure/azure-cache-redis/azure-cache-redis-host.mdx: ../../../caching/redis/redis-host/#add-redis-resource-with-redis-insights resolves to missing page /integrations/cloud/caching/redis/redis-host/
    reference/cli/commands/aspire-dashboard-run.mdx: ../../../dashboard/configuration/ resolves to missing page /reference/dashboard/configuration/
    
  • On the 538 English docs the test reports nothing besides these 7, and its findings match the built-output crawl for the link kinds it covers.
  • npx vitest run: 84 files passed; 1,121 tests passed and 1 skipped.
  • npx eslint . --max-warnings 0 passes, and the new test file is Prettier-formatted.
  • Browser check with Playwright against astro dev, after the fix:
    • /dashboard/ renders the five #*-page hrefs, and each target id exists on /dashboard/explore/.
    • The Dashboard configuration link returns 200.
    • The Redis Hosting integration link returns 200, and its anchor exists.
  • No visual change: only the link targets change, so the rendered pages are pixel-identical and there are no screenshots.

🤖 Posted by AspireAgent (AI Agent)

The links validator skips relative links and can't see hrefs passed through
JSX expression props, so these broke silently on every locale:

- dashboard/index.mdx: #traces, #structured-logs and #metrics anchors now
  target the existing #*-page headings on /dashboard/explore/.
- aspire-dashboard-run.mdx: Dashboard configuration resolved to
  /reference/dashboard/configuration/ (404).
- azure-cache-redis-host.mdx: Redis Hosting integration resolved to
  /integrations/cloud/caching/redis/redis-host/ (404) with a misspelled anchor.

Add a unit test that resolves expression-prop hrefs and ./ ../ relative links
in the English docs to existing pages and headings.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@aspire-repo-bot

Copy link
Copy Markdown
Contributor

Frontend HTML artifact ready

The latest frontend build uploaded the frontend-dist artifact for PR #1995. Use the VS Code button below to open this PR with GitHub Artifacts Explorer and browse the built HTML locally.

VS Code: Open PR #1995 artifacts

This comment updates automatically when a new frontend build artifact is uploaded.

Addresses the CodeQL incomplete multi-character sanitization alert. The slug
is unchanged because github-slugger already drops < and >.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
CodeQL still reported js/incomplete-multi-character-sanitization for the
regex-based tag strip. A scanner that drops everything from < through > has no
partial-match path and produces the same slugs (for example
aspireconfigjson-and-mcp-support for a heading with an inline <abbr>).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the documentation link fixes and added regression coverage.

No open issues 🎉

What changed in this PR

Fixes seven broken internal links in the English documentation used by locale fallback pages and adds regression coverage for link types the existing validator skips.

Changes:

  • Corrects five Dashboard landing-page links to existing section anchors.
  • Replaces two broken relative Markdown links with site-relative URLs and corrects the Redis Insight anchor.
  • Adds unit validation for expression-prop links and relative Markdown links, checking destination pages and heading IDs.
File Description
src/​frontend/​tests/​unit/​docs-internal-links.vitest.test.ts Adds internal-link regression coverage for English docs.
src/​frontend/​src/​content/​docs/​reference/​cli/​commands/​aspire-dashboard-run.mdx Fixes the Dashboard configuration URL.
src/​frontend/​src/​content/​docs/​integrations/​cloud/​azure/​azure-cache-redis/​azure-cache-redis-host.mdx Fixes the Redis hosting URL and Redis Insight anchor.
src/​frontend/​src/​content/​docs/​dashboard/​index.mdx Corrects tracing, structured logs, and metrics anchors.

Review effort: Balanced

@IEvangelist

Copy link
Copy Markdown
Member

Project documentation review

Reviewed PR #1995, base main at 29550055a064c9abea399953414bbd7078c350e9, head ded956c3f4366cd2d78cb525b3c88de675cb98e2, using the repository's doc-pr-reviewer skill.

Phase A - Claim verification

Seven changed cross-reference claims: 7 verified, 0 verified-with-nuance, 0 unverifiable, 0 contradicted. No actionable accuracy findings. The changed links point to the intended owning documentation and headings. No new package, version, API sample, or CLI invocation was introduced.

Source refs: microsoft/aspire.dev at the inspected PR head for documentation routes and anchors; microsoft/aspire, matching branch main, pinned at 13b2068df7157a9637e77ca7627542b425156910 for product subjects and the Redis customization context. Product files were queried read-only at that SHA. No Toolkit or Azure SDK source was needed.

Verified claims and source evidence
Claim / changed location Verified target and evidence
D1 - dashboard/index.mdx:66, "Learn about tracing" /dashboard/explore/#traces-page; Traces page heading.
D2 - dashboard/index.mdx:77, "View log features" /dashboard/explore/#structured-logs-page; Structured logs page heading.
D3 - dashboard/index.mdx:142, "Distributed tracing" Same verified tracing section as D1.
D4 - dashboard/index.mdx:149, "Structured & console logs" Same verified structured-log section as D2, within the tour that also explains Console logs.
D5 - dashboard/index.mdx:156, "Metrics & monitoring" /dashboard/explore/#metrics-page; Metrics page heading.
D6 - integrations/cloud/azure/azure-cache-redis/azure-cache-redis-host.mdx:169, "Redis Hosting integration" /integrations/caching/redis/redis-host/#add-redis-resource-with-redis-insight; matching heading and WithRedisInsight example. The singular insight matches the heading.
D7 - reference/cli/commands/aspire-dashboard-run.mdx:98, "Dashboard configuration" /dashboard/configuration/; configuration page, including standalone dashboard guidance.

Owning product evidence:

  • The dashboard implements traces, structured logs, and metrics.
  • RunAsContainer accepts the optional Action<IResourceBuilder<RedisResource>> and invokes it on the local Redis builder. RedisBuilderExtensions supplies WithRedisCommander (line 278), WithRedisInsight (360), WithDataVolume (538), and WithDataBindMount (571), supporting the unchanged customization context around D6.
  • DashboardRunCommand exposes endpoint configuration and --config-file-path, supporting the label and destination of D7.

The site's configured default locale is English (root), with fourteen other configured locales. The independent browser phase below checks the actual fallback experience rather than inferring it from configuration.

Phase B - Independent doc-tester results

Complete: 14 successful link clicks across the three changed English pages and their Danish fallback equivalents; 0 critical issues and 0 link-navigation warnings. Two preview-environment caveats are recorded below. This browser phase was blind to product source and the regression test implementation.

Full independent doc-tester report (verbatim)

Documentation Test Report

Focus Area: Phase B only — independent blind browser validation of the seven changed documentation links in microsoft/aspire.dev PR #1995, plus actual untranslated-locale fallback for its three changed pages.
Date: 2026-10-30 America/Chicago (browser artifacts dated 2026-10-31 UTC)
Tester: doc-tester agent
PR head: ded956c3f4366cd2d78cb525b3c88de675cb98e2 (detached; verified before and after testing)
Local URL tested: http://localhost:4322/
Browser session: pr1995blind (isolated, in-memory Microsoft Edge; now closed)
Status: Complete within the requested link-navigation scope. No GitHub writes, fixes, formal review, production build, product-source inspection, test-implementation inspection, or source-based conclusions.

Summary

Category Passed Failed Warnings
Content Accuracy Not assessed against product behavior — —
Code Examples Not in scope; not executed — —
CLI Commands Product commands not in scope; not executed — —
Links 14 actual clicks: 7 English + the same 7 from Danish fallback pages 0 0
Locale fallback 3 changed pages 0 0
Test environment Development server, browser, cleanup verified 0 2 environment caveats below

Pass counts concern navigation, rendered destination headings, and meaningful labels—not verification of underlying Aspire features.

Critical Issues

None found in the seven changed links or three tested fallback routes.

Warnings

Warning 1: Lightweight preview lacks the live-status backend

Location: Local preview http://localhost:4322/api/live/.
Issue: Browser console repeatedly reported a 404 and [live-status] Live API not found (404); live updates disabled until reload., with a WebSocket warning. The requested documentation pages and link destinations still rendered successfully.
Suggestion: Treat this as a preview-environment limitation, not evidence of a regression in the changed links. No product telemetry/backend functionality was tested.

Warning 2: Preview footer SHA is not the detached PR head

Location: Site footer.
Issue: The actual PR preview displayed SHA 2955005; the development startup command likewise reported git env unchanged: commit=29550055a064c9abea399953414bbd7078c350e9. Independent git rev-parse HEAD returned the requested ded956c3f4366cd2d78cb525b3c88de675cb98e2 before and after testing, and the listening Astro process command line pointed to this worktree's frontend. I did not investigate implementation.
Suggestion: Use the recorded Git head and process path as this run's provenance; do not identify the tested revision by the footer.

Passed Checks

Seven English link clicks

All destinations below are exact browser URLs. Every fragment matched an existing rendered, visible heading with the indicated ID. The configuration link has no fragment, so its rendered page-title heading was checked instead.

# Origin route Rendered link label Exact destination URL Rendered target
1 /dashboard/ Learn about tracing http://localhost:4322/dashboard/explore/#traces-page H3 id="traces-page" — Traces page
2 /dashboard/ View log features http://localhost:4322/dashboard/explore/#structured-logs-page H3 id="structured-logs-page" — Structured logs page
3 /dashboard/ Distributed tracing — card with description and Learn more http://localhost:4322/dashboard/explore/#traces-page H3 id="traces-page" — Traces page
4 /dashboard/ Structured & console logs — card with description and Learn more http://localhost:4322/dashboard/explore/#structured-logs-page H3 id="structured-logs-page" — Structured logs page
5 /dashboard/ Metrics & monitoring — card with description and Learn more http://localhost:4322/dashboard/explore/#metrics-page H3 id="metrics-page" — Metrics page
6 /integrations/cloud/azure/azure-cache-redis/azure-cache-redis-host/ Redis Hosting integration http://localhost:4322/integrations/caching/redis/redis-host/#add-redis-resource-with-redis-insight H2 id="add-redis-resource-with-redis-insight" — Add Redis resource with Redis Insight
7 /reference/cli/commands/aspire-dashboard-run/ Dashboard configuration http://localhost:4322/dashboard/configuration/ H1 id="_top" — Aspire dashboard configuration reference

The three cards' full accessible labels include their feature title and explanatory text, rather than only the repeated words “Learn more”:

  • “Distributed tracing Follow requests across service boundaries with span-level detail. Identify bottlenecks and errors instantly. Learn more”
  • “Structured & console logs View structured and console logs from every resource with powerful filtering, search, and error highlighting. Learn more”
  • “Metrics & monitoring Track request counts, error rates, and custom metrics with interactive charts and exemplar linking. Learn more”

The Redis tip visibly introduces customization of the underlying Redis resource and names Redis Insight, Redis Commander, a data volume, and a data bind mount before “For more information, see Redis Hosting integration.” The link lands at the Redis Insight section of the Redis hosting guide. The destination label and topic are meaningful; this run does not claim to verify those customization APIs.

All seven changed hrefs are site-relative and have a slash before any fragment.

Actual locale fallback, discovered through visible UI

I opened the visible “Select language” combobox on the rendered site, observed its options, and selected Dansk. I did not inspect translation files, locale configuration, or tests to choose a supposedly untranslated locale.

All three pages visibly showed the Danish fallback notice:

Dette indhold er ikke tilgængeligt i dit sprog endnu.

Their content remained English, with document.documentElement.lang equal to da.

Exact fallback URL reached through language selection Rendered English H1
http://localhost:4322/da/dashboard/ Aspire dashboard for distributed apps
http://localhost:4322/da/integrations/cloud/azure/azure-cache-redis/azure-cache-redis-host/ Set up Azure Cache for Redis in the AppHost
http://localhost:4322/da/reference/cli/commands/aspire-dashboard-run/ aspire dashboard run command

I additionally clicked all seven changed links from those actual fallback pages. They reached exactly the same seven English destination URLs and heading IDs recorded above. The observed behavior is that these fallback-page links leave /da/ and navigate to unprefixed English routes, not that they preserve the Danish locale. No broken page or fragment resulted.

Setup, commands, results, and browser methodology

Both required skills were invoked, and their actual local SKILL.md files were read in full:

  • .agents\skills\doc-tester\SKILL.md
  • .agents\skills\playwright-cli\SKILL.md

Commands were run from the worktree root unless noted:

Command / operation Result
git rev-parse HEAD Passed before and after: ded956c3f4366cd2d78cb525b3c88de675cb98e2.
git status --short Clean baseline; clean again after cleanup.
playwright-cli --help Passed; globally available CLI. No browser dependency installation needed.
npx --yes bun run dev Initial attempt failed with bun: command not found: astro; dependency restore was performed only after this failure.
npx --yes bun install Passed. Bun 1.4.4 restored 848 frontend packages through the root postinstall. No global configuration changes.
npx --yes bun run dev Passed after restore. Astro 7.4.1 lightweight development server started; port 4321 was occupied, so this run used 4322. No production build.
Get-NetTCPConnection -State Listen and Get-CimInstance Win32_Process -Filter 'ProcessId=20136' Confirmed port 4322 and node "...this-worktree\src\frontend\node_modules\astro\bin\astro.mjs" dev.
playwright-cli -s=pr1995blind open http://localhost:4321/dashboard/ Initial probe reached an unrelated already-running preview; its footer differed. It was excluded from all pass counts. The run then switched to its own server on 4322.
playwright-cli -s=pr1995blind goto http://localhost:4322/dashboard/ and equivalent goto commands for the other two changed pages Passed; actual rendered PR pages loaded.
playwright-cli -s=pr1995blind click e226 Exercised tracing CTA. An early read raced client-side navigation; it was not counted until a subsequent observation confirmed the Traces page heading.
playwright-cli -s=pr1995blind run-code "async page => { ... }" Used visible accessible link names to perform actual clicks; waited for the destination pathname/hash and rendered heading. Passed all seven English and seven Danish-origin click checks.
playwright-cli -s=pr1995blind eval "() => ..." Read only rendered DOM: hrefs, labels, current URL, heading IDs/text, fallback notice, and page language. No product or test source was accessed.
playwright-cli -s=pr1995blind snapshot, console warning, and network Captured rendered-page/console/network evidence during investigation; generated files removed after findings were preserved here.
node src\frontend\node_modules\vitest\vitest.mjs --version Passed: vitest/4.1.11 win32-x64 node-v26.13.0. Runtime path available for parent validation; no Vitest tests were read or run by this blind tester.

Early browser experiments encountered a 5-second click timeout, aborted navigation, and “Execution context was destroyed” while client-side transitions were still pending. One configuration-heading wait incorrectly expected “Dashboard configuration” rather than the actual “Aspire dashboard configuration reference”; this was corrected to observe the real rendered heading. A broad h1 locator also matched Astro dev-toolbar shadow content; checks were narrowed to main h1. All counted checks were subsequently repeated or directly observed successfully. These transient harness observations are not presented as documentation failures.

Cleanup and persistent state

  • Owned server shell ID: pr1995blind-dev-running.
  • Owned server endpoint: http://localhost:4322/.
  • Owned listening Astro PID: 20136; parent PID observed as 54228.
  • Owned browser process initially reported PID 57588.
  • playwright-cli -s=pr1995blind close succeeded. No close-all or other browser sessions were used.
  • stop_powershell for pr1995blind-dev-running succeeded, following the parent's updated cleanup instruction.
  • Port 4322 was verified closed; PID 20136 was verified stopped. The unrelated listener on 4321 was left alone.
  • Dev startup mutated four tracked generated files: src\frontend\.starlight-icons\language-map.json, material-icons.json, safelist.json, and version.txt. These own generated changes were restored with git restore -- using the clean baseline.
  • Own .playwright-cli snapshots, console logs, and network log were removed. Final git status --short produced no entries.
  • Restored dependencies remain in ignored src\frontend\node_modules for the parent's focused validation.
  • This frozen report is the retained artifact. No tracked documentation or implementation files were edited.

Recommendations

  1. Priority fixes: None identified for the changed links.
  2. Documentation gaps: No link-navigation prerequisite or explanatory gap blocked these checks.
  3. Product issues: None established; backend behavior and APIs were deliberately outside this blind phase.
  4. Follow-up: Parent may run focused tests with node src\frontend\node_modules\vitest\vitest.mjs or use the installed .bin\vitest.exe; Bun's Windows install did not provide vitest.cmd.

Knowledge Gaps and Honest Limits

  • I used no product-source conclusions and did not read microsoft/aspire, CommunityToolkit/Aspire, Azure SDK source, or any test implementation.
  • Browser automation, DOM heading IDs, and shell process inspection are tester knowledge, not Aspire knowledge learned from the documentation. They were used only to measure navigation.
  • I did not silently infer that working links prove the documented Aspire behavior. No code sample was compiled, no Aspire dashboard command was executed, no Redis/Azure resource was provisioned, and no integration package behavior was verified.
  • Only the requested seven changed links were audited, not every unrelated internal/external link on these large pages.
  • Locale coverage is actual Danish fallback for the three changed pages and those seven outbound clicks, not exhaustive validation of all languages or translated destinations.
  • No production-build/link-validator/unit suite was run in Phase B; this was deliberately the requested lightweight, browser-only documentation test.

This is a top-level conversation report, not a formal approval or change-request verdict. No fixes, edits to the PR, pushes, or merges were made.

@IEvangelist

Copy link
Copy Markdown
Member

Project code review

Reviewed PR #1995 against main (29550055a064c9abea399953414bbd7078c350e9), at head ded956c3f4366cd2d78cb525b3c88de675cb98e2, using the repository's code-review skill.

No actionable, high-confidence code findings. The new internal-link regression checker is correct and adequately covered for its stated scope: English docs' literal expression-prop href: values and ./ / ../ Markdown links. I checked route normalization, Windows path handling, locale exclusions against the configured locales, relative URL resolution, fragment checks, fence stripping, inline heading tags, and the existing content-test patterns. The previous CodeQL inline discussion is already addressed in this head; I did not repeat it.

Test coverage

  • Unit: From src/frontend, node node_modules\vitest\vitest.mjs run --config vitest.config.ts tests/unit/docs-internal-links.vitest.test.ts passed: 1 file, 2 tests.
  • Regression sensitivity: An additional read-only, in-memory run of the actual checker against all 538 English docs returned 0 problems at the inspected head. Substituting only the three changed docs' contents from base 29550055 returned exactly the seven original broken links: five missing dashboard fragments and two missing relative destinations. No tracked files were changed for this control.
  • E2E / accessibility: No component behavior, markup, layout, or new routes change, so additional three-viewport or axe tests are not required for this test-only code addition. The preceding documentation report records the independent browser check of the changed navigation.

The checker deliberately supplements, rather than replaces, Starlight's build-time validator. This review does not claim exhaustive validation of arbitrary MDX expressions, generated API/Dev Hub destinations, external URLs, or bare relative links without ./ or ../. No production build or full repository suite was run.

This is a top-level conversation report, not a formal approval or change-request verdict. No fixes, edits to the PR, pushes, or merges were made.

@IEvangelist
David Pine (IEvangelist) merged commit 88b636b into main Nov 1, 2026
21 of 22 checks passed
@IEvangelist
David Pine (IEvangelist) deleted the aspireagent/fix-docs-prop-and-relative-links branch November 1, 2026 14:14
David Pine (IEvangelist) pushed a commit that referenced this pull request Nov 1, 2026
## Summary

The "What's new" pages for Aspire 9.4 and 9.5 contain links ported from
the old docs site that don't work on aspire.dev, plus one `[!INCLUDE]`
directive that shows up as raw text. The site's links validator misses
all of them. It runs with `errorOnRelativeLinks: false`, treats
`https://aspire.dev/...` as external, and accepts redirect sources.

**`whats-new/aspire-9-4.mdx`**

| Before | After | Problem |
|---|---|---|
| `` [Aspire SDK](`microsoft/aspire/sdk`) `` |
`/get-started/aspire-sdk/` | The target is in backticks, so it resolves
to a 404 |
| `cli-reference/aspire/` | `/reference/cli/commands/aspire/` | Bare
relative link → 404 |
| `cli-reference/aspire-config/` |
`/reference/cli/commands/aspire-config/` | Bare relative link → 404 |
| `[!INCLUDE [aspire exec feature flag
note](cli/includes/exec-feature-flag-note/)]` | Inline 🧪 **Feature
Flag** note, in the same style as the `aspire deploy` note on the same
page | Rendered as literal text, with a 404 link |
| `cli-reference/aspire-deploy/` |
`/reference/cli/commands/aspire-deploy/` | Bare relative link → 404 |
|
`fundamentals/orchestrate-resources.md#express-external-service-resources`
|
`/reference/api/csharp/aspire.hosting/externalservicebuilderextensions/`
| 404. No conceptual page covers `AddExternalService`, so it links to
the API reference |
| `https://aspire.dev/app-host/eventing/#apphost-life-cycle-events` |
`#apphost-eventing` | Anchor doesn't exist |
|
`https://aspire.dev/app-host/configuration/#aspire-version-update-notifications`
| `#version-update-notifications` | Anchor doesn't exist |

**`whats-new/aspire-9-5.mdx`**

| Before | After | Problem |
|---|---|---|
| `` [Aspire SDK](`microsoft/aspire/sdk`) `` |
`/get-started/aspire-sdk/` | The target is in backticks → 404 |
| `cli-reference/aspire-config-set/` |
`/reference/cli/commands/aspire-config-set/` | Bare relative link → 404
|
| "For more information, see [aspire exec
command](cli-reference/aspire-exec/) reference." | Sentence removed |
404. `aspire exec` is no longer in the CLI, and
`/reference/cli/commands/aspire-exec/` redirects to `aspire-resource`,
which is a different command (#1814) |
| `cli-reference/aspire-config/` |
`/reference/cli/commands/aspire-config/` | Bare relative link → 404 |
| `/integrations/reverse-proxies/yarp/#multi-stage-docker-builds` |
`#static-file-serving` | Anchor doesn't exist. The static-files section
is the one the text describes |
| `/integrations/messaging/rabbitmq/rabbitmq-client/#auto-activation` |
`/integrations/messaging/rabbitmq/rabbitmq-connect/#auto-activation` |
The old path is a meta-refresh redirect stub that drops
`#auto-activation` |

**Regression test:** the new
`tests/unit/docs-markdown-link-targets.vitest.test.ts` scans English
docs markdown (skipping code fences) for these patterns:
- `[!INCLUDE` directives
- link targets wrapped in backticks
- bare relative targets
- anchored links to redirect sources
- `https://aspire.dev/...` links to missing pages or missing heading
anchors

It skips the same paths the links validator excludes (`/reference/api/`,
`/hub/`, `/i18n/`).

**Scope:** open PR #1995 covers a different set of link gaps (dashboard
anchors and Azure pages) and doesn't touch these lines. Other open PRs
that edit these files (#1933, #1896, #1876) don't change these links
either.

## Third-party links and affiliations

None.

## Validation

- **Regression test:** fails on `main` with 15 problems across the two
files, and passes with this change (2/2).
- **Unit tests:** `bun run test:unit` → 85 files, 1122 passed, 1
skipped.
- **Lint:** `bun run lint` passes.
- **Playwright, against the local dev server:** opened both pages and
requested every changed link, checking the target anchor exists.
- Before: 12 failures (404s, missing anchors, plus the raw `[!INCLUDE`
text on 9.4).
- After: all 12 links resolve, every anchor is present, and there is no
`[!INCLUDE` text.
- **Redirect behaviour:** checked against the production build artifact
from `main` CI. `rabbitmq-client/#auto-activation` lands on
`rabbitmq-connect/` with an empty hash, so the anchor is lost.

**Before:** the 9.4 `aspire exec` section renders the raw directive.

![Before: Aspire 9.4 What's new shows literal "[!INCLUDE aspire exec
feature flag note]"
text](https://github.com/user-attachments/assets/6162ca7e-9bd6-4df9-8271-af24daae09e1)

**After:** the feature-flag note renders.

![After: Aspire 9.4 What's new shows the Feature Flag note for aspire
exec](https://github.com/user-attachments/assets/06d8656c-82b5-47b0-97f8-84b2554cda74)

**🤖 Posted by AspireAgent (AI Agent)**

---------

Co-authored-by: davidfowl <95136+davidfowl@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants