Skip to content

[release/17.0] Complete Go starter validation and polyglot scenario readiness - #22007

Closed
Mitch Denny (mitchdenny) wants to merge 1 commit into
mitchdenny-backport-17-0-09-pr21461from
mitchdenny-backport-17-0-10-pr21828
Closed

Mitch Denny (mitchdenny) wants to merge 1 commit into
mitchdenny-backport-17-0-09-pr21461from
mitchdenny-backport-17-0-10-pr21828

Conversation

@mitchdenny

Copy link
Copy Markdown
Member

Description

Backport of #21828 to release/17.0 (cherry-picked from 5138b2a with no modifications). Layer 10 of 55 in the release/17.0 backport stack; stacked on #22006.

Backport recommendation: Yes — Go starter otherwise ships an untidy go.mod and ignores --use-redis-cache false.

Backport of #21828

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No

## Description

Go starters should build from their shipped files without an initial
`aspire run` repairing dependencies, and Go preview validation should
exercise the same runtime and native-runner paths as other AppHosts.

- Ship a tidy API `go.mod` and generated `go.sum`. Add starter scenarios
checking gitignore, readonly API build, tidy stability, health and
weather responses; remove the Kubernetes manual-tidy workaround.
- Honor the existing `--use-redis-cache false` option for Go.
Omitted/true retains Redis; false omits the integration and resource.
Cover all three scaffold choices with generated-source snapshots and
both HTTP lifecycle variants with Docker E2E.
- Add `go vet` to Go polyglot fixtures, an EF Core fixture, and Foundry
tool/AKS node-pool parity. Exercise configuration-section list getters
in the real Go runtime smoke.
- Add Go to all six native starter-validation platforms, with official
checksum-verified Go installation, timeout budget, and runtime-only
selector edges for Go hosting, Go codegen, and Redis. Linux retains
API/Redis readiness; containerless Windows/macOS use the cache-free
starter with API readiness unchanged.
- Add isolated-local-feed Go/Java scaffolding and restore to the
stabilization smoke without rewriting template pins. Use a genuine
Release bundled driver outside repository mode, cold consumer caches,
and exact hosting-package extraction/provenance checks. Enable Java only
in its subprocess.
- Select languages by name rather than picker position. Restore stale
Java/TypeScript SDK baselines after `aspire add` so the following
`aspire restore` genuinely tests regeneration. Establish the TypeScript
baseline with an actual restore before reading cache metadata.
- Wait for the TypeScript Kubernetes application's actual Ready pod;
exercise the Go Helm namespace/chart-version callback.

Relates to #21202, #21206, #21209, #21210, #21201, and #21108.

### User-facing usage

```bash
# Default retains Redis.
aspire new aspire-go-starter --name GoReady --non-interactive --suppress-agent-init

# Containerless starter: the Go API runs without Redis or a Docker daemon.
aspire new aspire-go-starter --name GoReady --use-redis-cache false --non-interactive --suppress-agent-init
```

Both variants emit `api/go.sum` and an already-tidy API module. Its API
can build with `go build -mod=readonly` without first running the
AppHost's tidy resource.

### Dependencies and remaining acceptance

This PR is independent of #21823. Root-module brownfield E2E #21825
merged into the #21823 feature branch, not directly into main; its
delivery follows #21823. #21806 independently covers other Go
init/build/vet/stable-restore scenarios.

The existing stabilization gate remains disabled
(`STABILIZATION_ENABLED: 'false'`); enabling it needs a separate
CI/policy decision. Current `Aspire.Hosting.Java.csproj` still sets
`SuppressFinalPackageVersion=true` while the Java starter pins the
requested Aspire version. The corrected smoke reaches actual NuGet
restore and exposes that mismatch: `Aspire.Hosting.Java (= 17.0.0)` is
unavailable, the nearest local package is `17.0.0-dev`, and nuget.org
versions are not considered. No pin substitution or Java release-policy
change is included.

Native Linux validation built the genuine stabilized Release CLI/payload
and proved cold Go/Redis package restore and C# restore. This is **not a
clean stabilization pass**: the unsuppressed stable pack first
reproduced NU5104 on existing .NET 11 preview dependencies. The
diagnostic consumer feed downgraded only NU5104 with
`WarningsNotAsErrors=NU5104`; that exception is not committed. The final
smoke correctly exits 1 with only Java in its failure list.

The bounded shared-image fix is separate in #21849; this PR does not
modify image Dockerfiles or the image-build implementation. Its
`b8274fc8e0` image job and all four uploads passed, Infrastructure
passed 2090/2090 including all 13 new image cases, and all 116 CLI
archive E2E jobs passed. Earlier Windows extension fake-timer and DCP
Docker-startup failures were investigated with same-source passing main
controls; the morning live refresh reports its Final Results passing. It
remains independently review-gated. Do not infer actual timeout/fallback
execution from a healthy-mirror image pass.

No action SHA is added or changed. No official Azure DevOps pipeline is
modified. Parent's Go-minimum-version map rule/theory and the other
owner's extension-e2e map block are untouched. The cache option uses
existing embedded CLI inputs; no additional selector rule is required.
The stabilization script remains advisory/disabled rather than being
presented as a regular-PR gate.

This does not close #21108: live Azure Container Apps deployment and
real missing/old-toolchain E2E remain uncovered here. Cross-language
lifecycle redesigns are deferred.

### CI failures diagnosed and fixed

Original-head run
[42116644663](https://github.com/microsoft/aspire/actions/runs/42116644663)
exposed two causes:

- Windows x64/ARM64 and macOS x64/ARM64 starter validation failed
because Redis could not start: the Windows Docker engine pipe was absent
and macOS had no Docker executable. The API correctly waited on its
unhealthy dependency. Those native runners now use the supported
cache-free variant; Linux and Docker E2E retain Redis coverage. No
readiness assertion was removed.
- `TypeScriptCodegenValidationTests` read `.codegen-hash` immediately
after init, which supplies SDK sources but not restore-cache metadata.
An explicit baseline restore now precedes the snapshot and stale-cache
assertions.

**Head `1ab3ad1e30`: all six native starter lanes passed**, including
both Redis-enabled Ubuntu lanes and all four formerly failing
Windows/macOS lanes, in [run
42151619597](https://github.com/microsoft/aspire/actions/runs/42151619597).
Packaged CI subsequently passed
[GoStarterReadinessTests](https://github.com/microsoft/aspire/actions/runs/42151619597/job/127721672515)
(both cache choices),
[GoStarterTemplateTests](https://github.com/microsoft/aspire/actions/runs/42151619597/job/127721672968),
[JavaCodegenValidationTests](https://github.com/microsoft/aspire/actions/runs/42151619597/job/127721672216),
and
[TypeScriptCodegenValidationTests](https://github.com/microsoft/aspire/actions/runs/42151619597/job/127721664876).
All originally failing targeted lanes/classes therefore have passing
coverage.

The shared image job first timed out at 45 minutes twice. Attempt 2
fetched 108 MB from Azure Ubuntu in 41 minutes 29 seconds (43.4 kB/s),
versus a following GitHub download at 80.1 MB/s; GHA cache import also
returned HTTP 400 service-unavailable responses. After #21849's
same-input image control passed with all four uploads, one
evidence-based product revalidation was started. [Attempt 3's image job
passed](https://github.com/microsoft/aspire/actions/runs/42151619597/job/127718680817)
and admitted packaged E2E. No blind retries were made. The successful
infrastructure control used a healthy primary mirror; it does not
demonstrate timeout/fallback execution in that CI run.

**Head `bd30794b9e`: historical failures and final outcome are
distinct.** In [run
42167868738](https://github.com/microsoft/aspire/actions/runs/42167868738),
all six native starter lanes and Go/Java/TypeScript SDK validation
passed. The first [shared image
job](https://github.com/microsoft/aspire/actions/runs/42167868738/job/127729647462)
was canceled after 45 minutes 22 seconds with Azure Ubuntu apt downloads
still running and all four uploads skipped; the initial Linux
tree-actions attempt also failed on a stale immutable Running snapshot.
The morning live refresh subsequently shows [Final Results
passing](https://github.com/microsoft/aspire/actions/runs/42167868738/job/127754717945),
including
[GoStarterReadinessTests](https://github.com/microsoft/aspire/actions/runs/42167868738/job/127747615122).
This session did not initiate retries. A passing later attempt does not
repair the tree-actions race: its separate test-only fix #21854 still
needs independent approval/merge and incorporation before claiming the
race fixed in this checkout.

**Latest head `0bb6569d91` requires fresh checks**, now running in
[42222384609](https://github.com/microsoft/aspire/actions/runs/42222384609).
Both new review findings are corrected: SDK selection accepts only exact
numeric MAJOR.MINOR.PATCH package filenames, and Go starter startup is
inside its existing cleanup scope. Both threads were replied to and
resolved with evidence. Earlier-head CI is not presented as latest-head
proof.

Per the user's explicit authorization, the coordinator enabled normal
native **squash auto-merge** at 05:22:46Z on 2026-11-06. It remains
enabled behind required fresh checks and review requirements. No admin
bypass is authorized or used; the PR is not merged.

### Stabilization review corrections

The smoke now publishes a Release CLI with its real stabilized bundle
outside the checkout, propagates stabilization into child payload
builds, and clears inherited `ASPIRE_REPO_ROOT` for every consumer
invocation. Consumer packages are isolated after the driver build so
build-time extraction cannot hide a missing stable package. Successful
guest restores must produce metadata for the exact hosting pins,
including Redis for Go; provenance is retained in the output.

The real run also exposed two stale smoke assumptions: a pre-owned
parent feed mapping conflicts with scaffolding's project-local channel
policy, and current C# file-based templates use `#:package
Aspire.Hosting.AppHost@<version>`, not the obsolete SDK directive. The
smoke now lets the CLI establish its own authoritative project-scoped
feed mapping and checks the current hosting-package contract. No
customer NuGet policy is changed.

### Validation

- `.\restore.cmd` - passed.
- `dotnet build
tests\Aspire.Cli.EndToEnd.Tests\Aspire.Cli.EndToEnd.Tests.csproj
--no-restore --nologo -v quiet` - passed, zero warnings/errors; repeated
successfully after removing temporary fault injection for `0bb6569d91`.
- `dotnet test --project tests\Aspire.Cli.Tests\Aspire.Cli.Tests.csproj
--no-launch-profile -- --filter-class
'*.NewCommandTemplateConfigPersistenceTests' --filter-not-trait
'quarantined=true' --filter-not-trait 'outerloop=true'` - passed, 59
tests including default/true/false Go package and generated-source
assertions. Existing ILCompiler NU1903 advisory was emitted.
- With
`ASPIRE_E2E_CLI_ARCHIVE_DIR=artifacts\readiness-ci\cli-archive-new` and
`ASPIRE_E2E_DOTNET_IMAGE=aspire-e2e-polyglot-base:latest`, `dotnet test
--project
tests\Aspire.Cli.EndToEnd.Tests\Aspire.Cli.EndToEnd.Tests.csproj
--no-launch-profile -- --filter-method
'*.RestoreGeneratesSdkFiles_WithConfiguredToolchain' --filter-not-trait
'quarantined=true' --filter-not-trait 'outerloop=true'` - passed, all
four npm/bun/yarn/pnpm cases against exact `1ab3ad1e30` Linux
CLI/packages. The corresponding packaged CI class also passed above.
- With
`ASPIRE_E2E_CLI_ARCHIVE_DIR=artifacts\readiness-ci\cli-archive-new` and
`ASPIRE_E2E_POLYGLOT_GO_IMAGE=aspire-go-e2e-6972:latest`, `dotnet test
--project
tests\Aspire.Cli.EndToEnd.Tests\Aspire.Cli.EndToEnd.Tests.csproj
--no-launch-profile -- --filter-method
'*.StarterShipsTidyApiAndServesRequests' --filter-not-trait
'quarantined=true' --filter-not-trait 'outerloop=true'` - 1 passed/1
failed locally against exact `1ab3ad1e30`. Cache-free passed actual
scaffolding, readonly API build, tidy check, API-up, health/weather and
stop without a Docker socket. Redis timed out locally. The unchanged
`2859e199e2` control reproduced the same timeout on this Docker Desktop
host; no workaround or weaker assertion was added. **Both cases
subsequently passed packaged CI**, linked above. After the cleanup-scope
correction, this local command again passed cache-free and failed Redis
on API readiness; the independent CLI stop log confirmed successful
shutdown, while the shared terminal helper observed the prior ERR
prompt. That local run is not claimed green.
- Temporary fault-injection validation used that same E2E command with
only the cache-free case and a shell wrapper returning HTTP 503 for the
Dashboard probe after a real packaged AppHost launch - intentionally
failed. Terminal output showed `dashboard-http-failed`, then cleanup
invocation; the CLI log confirmed `apphost.go stopped successfully` and
exit 0. The wrapper and temporary test edit were removed before the
final clean build/commit. This verifies partial-start cleanup, not a
successful readiness scenario.
- `docker run --rm --entrypoint bash -v "${PWD}:/workspace:ro"
aspire-go-e2e-6972:latest -c "sed 's/\r$//'
/workspace/artifacts/readiness-ci/validate-stable-sdk-selection.sh |
bash"` - passed actual smoke-script preflight cases for missing SDK,
prerelease-only, mixed
stable/dev/preview/rc/build-metadata/four-component filenames,
multi-digit stable versions, and feed paths with spaces. The
instrumented driver received `BundleVersion=17.0.0` from the mixed feed.
Invalid-only feeds exited 1 with the explicit missing-stable diagnostic.
Temporary harness removed after retaining logs; not a new all-language
stabilization pass.
- `dotnet test --project
tests\Infrastructure.Tests\Infrastructure.Tests.csproj
--no-launch-profile -- --filter-class '*.TestTriggerMapTests'
--filter-not-trait 'quarantined=true' --filter-not-trait
'outerloop=true'` - passed, 176 tests.
- `dotnet run --project tools\SelectTests -- --changed-files
artifacts\readiness-changed-files.txt --explain` - passed against the
real graph/map; Go hosting/codegen, Redis, starter checksum and EF Core
fixture inputs select starter-validation/polyglot with zero unattributed
files. Schedule-only deployment remains advisory.
- `$env:DOTNET_ROOT = Join-Path $PWD '.dotnet'; $env:ASPIRE_REPO_ROOT =
$PWD; .\artifacts\bin\Aspire.Cli\Debug\net11.0\aspire.exe restore
--apphost tests\PolyglotAppHosts\<integration>\Go\apphost.go
--non-interactive` - passed separately for
`Aspire.Hosting.EntityFrameworkCore`, `Aspire.Hosting.Foundry`, and
`Aspire.Hosting`, generating actual SDK bindings.
- `docker run --rm --entrypoint bash -v "${PWD}:/workspace"
aspire-go-e2e-6972:latest -c 'set -e; for fixture in
Aspire.Hosting.EntityFrameworkCore Aspire.Hosting.Foundry
Aspire.Hosting; do cd "/workspace/tests/PolyglotAppHosts/$fixture/Go";
gofmt -w apphost.go; go build -buildvcs=false -o /tmp/fixture ./...; go
vet ./...; done'` - passed for all three fixtures.
- `docker run --rm --entrypoint bash -v "${PWD}:/workspace:ro"
aspire-go-e2e-6972:latest -c 'set -e; bash -n
/workspace/.github/workflows/polyglot-validation/test-go.sh
/workspace/.github/workflows/polyglot-validation/test-go-playground.sh
/workspace/eng/scripts/stabilization-smoke-init-restore.sh;
work=$(mktemp -d); trap "rm -rf $work" EXIT; cp
/workspace/src/Aspire.Cli/Templating/Templates/go-starter/api/*
"$work/"; cd "$work"; sed -i "s/{{projectNameLower}}/starter/g" go.mod;
go build -mod=readonly -o /tmp/go-ready-api .; go mod tidy -diff; go vet
./...'` - passed without a dependency-repair command.
- Native Linux `./restore.sh -p:SkipTestProjects=true
-p:SkipPlaygroundProjects=true` - passed with the pinned SDK.
- Native Linux `./dotnet.sh pack
src/Aspire.Hosting.AppHost/Aspire.Hosting.AppHost.csproj -c Release
-p:StabilizePackageVersion=true -p:SkipNativeBuild=true --nologo -v
quiet` - failed as expected on existing NU5104 preview dependencies; not
counted as a stabilization pass.
- To isolate consumer behavior, the diagnostic feed used `for project in
Aspire.Hosting Aspire.Hosting.AppHost Aspire.Hosting.Dotnet
Aspire.TypeSystem Aspire.Hosting.CodeGeneration.Go
Aspire.Hosting.CodeGeneration.Java Aspire.Hosting.Go
Aspire.Hosting.Redis Aspire.Hosting.Java Aspire.Hosting.JavaScript
Aspire.AppHost.Sdk Aspire.ProjectTemplates; do ./dotnet.sh pack
"src/$project/$project.csproj" -c Release
-p:StabilizePackageVersion=true -p:SkipNativeBuild=true
-p:WarningsNotAsErrors=NU5104 --nologo -v quiet; done` - passed. No
suppression is committed; Java remains `17.0.0-dev` by existing policy.
- Native Linux `STABILIZATION_SMOKE_CONFIGURATION=Release
ASPIRE_REPO_ROOT=/work/source bash
eng/scripts/stabilization-smoke-init-restore.sh` - built the genuine
stabilized Release driver/payload and completed the consumer flow.
**Exit 1 is the expected Java policy failure, not an all-language
pass.** Go/Redis `17.0.0` metadata names
`/work/source/artifacts/packages/Release/Shipping`; C# `17.0.0`
restored; Java reached real NuGet restore and rejected its absent stable
pin with no nuget.org fallback. Output assertions confirmed the final
failure list is exactly `java`. Sources were `1ab3ad1e30` plus the final
smoke correction; no mixed PR-stamped CLI was used.
- `bash -n eng/scripts/stabilization-smoke-init-restore.sh`, PowerShell
parser validation of `eng\scripts\cli-starter-validation.ps1`, and `git
diff --check` - passed.
- Full `Infrastructure.Tests.TestTriggerMap` namespace was not passed on
this Windows host: WSL's `bash.exe` cannot find `/bin/bash`; a narrowed
run also encountered readonly `.git` cleanup failures. Not counted as
successful validation.

## Checklist

- Is this feature complete?
  - [ ] Yes. Ready to ship.
  - [x] No. Follow-up changes expected.
- Are you including unit tests for the changes and scenario tests if
relevant?
  - [x] Yes
  - [ ] No
- Did you add public API?
  - [ ] Yes
    - If yes, did you have an API Review for it?
      - [ ] Yes
      - [ ] No
- Did you add `<remarks />` and `<code />` elements on your triple slash
comments?
      - [ ] Yes
      - [ ] No
  - [x] No
- Does the change make any security assumptions or guarantees?
  - [ ] Yes
    - If yes, have you done a threat model and had a security review?
      - [ ] Yes
      - [ ] No
  - [x] No

---------

Co-authored-by: IEvangelist <7679720+IEvangelist@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
(cherry picked from commit 5138b2a)
@github-actions

This comment has been minimized.

@mitchdenny
Mitch Denny (mitchdenny) force-pushed the mitchdenny-backport-17-0-10-pr21828 branch from f1f2193 to b1138d0 Compare November 10, 2026 04:22
@mitchdenny
Mitch Denny (mitchdenny) force-pushed the mitchdenny-backport-17-0-10-pr21828 branch from b1138d0 to f1f2193 Compare November 10, 2026 04:23
@github-actions

Copy link
Copy Markdown
Contributor

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 22007

Or

  • Run remotely in PowerShell:
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 22007"

@mitchdenny

Copy link
Copy Markdown
Member Author

Approved for inclusion in release/17.0. Do not merge yet.

@github-actions

This comment has been minimized.

@mitchdenny
Mitch Denny (mitchdenny) force-pushed the mitchdenny-backport-17-0-10-pr21828 branch from c283f5f to f1f2193 Compare November 10, 2026 07:04
@mitchdenny
Mitch Denny (mitchdenny) force-pushed the mitchdenny-backport-17-0-10-pr21828 branch from f1f2193 to c283f5f Compare November 10, 2026 07:15
@mitchdenny
Mitch Denny (mitchdenny) force-pushed the mitchdenny-backport-17-0-10-pr21828 branch from c283f5f to f1f2193 Compare November 10, 2026 09:14
Jose Perez Rodriguez (joperezr) pushed a commit that referenced this pull request Nov 11, 2026
…eadiness (#22104)

Backport of #21828 to release/17.0

/cc @IEvangelist

## Description

Standalone backport of Go starter validation and polyglot scenario
readiness. Targets `release/17.0` directly; the old chained backport
#22007 is left untouched.

Relates to #21202, #21206, #21209, #21210, #21201, and #21108. Does not
close their remaining work.

## Checklist

- Is this feature complete?
  - [x] Yes. Ready to ship.
  - [ ] No. Follow-up changes expected.
- Are you including unit tests for the changes and scenario tests if
relevant?
  - [x] Yes
  - [ ] No
- Did you add public API?
  - [ ] Yes
    - If yes, did you have an API Review for it?
      - [ ] Yes
      - [ ] No
- Did you add `<remarks />` and `<code />` elements on your triple slash
comments?
      - [ ] Yes
      - [ ] No
  - [x] No
- Does the change make any security assumptions or guarantees?
  - [ ] Yes
    - If yes, have you done a threat model and had a security review?
      - [ ] Yes
      - [ ] No
  - [x] No

## Customer Impact

Go starters ship tidy API dependencies without requiring the first run
to repair them, honor Redis exclusion, and gain native starter and
polyglot scenario coverage. Cache-free starters can run without a Docker
daemon.

## Testing

Backport verification: the aggregate diff has the same stable patch ID
as merged source commit `5138b2a86ab20b3834b01983382a8b478d6b6a39`:
`654ff923aac88d60791888affc4885c77b0c09c6`. The PR targets
`release/17.0` directly and has no native stack membership.

Source-PR validation, not rerun locally on this backport:

```powershell
dotnet test --project tests\Aspire.Cli.Tests\Aspire.Cli.Tests.csproj --no-launch-profile -- --filter-class '*.NewCommandTemplateConfigPersistenceTests' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true'
```

Passed: 59 tests, including default/true/false Redis scaffold choices.
Source [packaged
CI](https://github.com/microsoft/aspire/actions/runs/42151619597) passed
both Redis choices in GoStarterReadinessTests and all six native starter
lanes. The source local Redis readiness run timed out; only the
cache-free local case passed, so local Redis validation is not claimed
green.

No local release-branch tests were rerun. Release-branch CI was pending
when this section was written; this is not a claim that backport CI has
passed.

## Risk

Medium. Changes starter scaffolding and shared CI/scenario validation,
including runtime-only test-selection edges and stabilization smoke
coverage.

## Regression?

Unknown. The source PR does not identify a regressing release.

---------

Co-authored-by: IEvangelist <7679720+IEvangelist@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants