Skip to content

[release/17.0] Clarify source and skill summaries in aspire agent init - #22111

Closed
Mitch Denny (mitchdenny) wants to merge 1 commit into
mitchdenny-backport-21831-to-17-0from
mitchdenny-backport-21883-to-17-0
Closed

Mitch Denny (mitchdenny) wants to merge 1 commit into
mitchdenny-backport-21831-to-17-0from
mitchdenny-backport-21883-to-17-0

Conversation

@mitchdenny

Copy link
Copy Markdown
Member

Description

Backport of #21883 to release/17.0: clarify aspire agent init output by separating configured remote sources from installed local skills, showing actual source URLs (including retained OpenCode catalog pins), and reporting successful Playwright skill destinations.

Stack layer 2 of 4. Depends on parent #22110 (mitchdenny-backport-21831-to-17-0 at 080e7e0662e662a6c3f41337fa2427a1a009e8d1). Ultimate target: release/17.0. Stack order: #21831 → #21883 → #21855 → #21852; higher-layer backport PRs are forthcoming. This PR contains only #21883 relative to its parent and must be taken with the stack. Do not merge this layer independently into its temporary parent branch.

Cherry-picked without conflicts from 2fefac5abe97fbfa878abac3b9f3b5dbbd211cd7, preserving the cherry-pick provenance. The backport patch ID matches the original source patch.

Fixes # (issue)

User-facing usage

Run aspire agent init. Its final summary now distinguishes Configured sources (URLs and agent configuration locations) from Installed skills (skill names and successful destinations grouped by agent). Existing static skills and successfully installed Playwright skills are included.

Screenshots / Recordings

This PR includes CLI output changes. Updated output snapshots are included in the exact source backport and passed focused tests. TODO: add a terminal screenshot or recording of aspire agent init with Copilot, Claude Code, and OpenCode selected, including Playwright CLI installation; no live terminal capture was made for this backport.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No

Customer Impact

Users can mistake the generic installation preview for plugin configuration and cannot see configured source URLs or Playwright skill destinations. This backport makes those results explicit and accurately reports installed skills.

Testing

  • ./restore.sh — passed, 0 warnings and 0 errors.
  • MSBUILDTERMINALLOGGER=false dotnet test --project tests/Aspire.Cli.Tests/Aspire.Cli.Tests.csproj --no-launch-profile -- --filter-class '*.AgentInitClientSelectionTests' --filter-class '*.AgentInitCommandTests' --filter-class '*.PlaywrightCliInstallerTests' --filter-not-trait 'quarantined=true' --filter-not-trait 'outerloop=true' — passed: 270 tests, 0 failed, 0 skipped.
  • git diff --check HEAD^ HEAD — passed. Original and backport stable patch IDs match (e88398550bdc3aff2dac33675fe061102d7f6e5f).

Risk

Low. Localized CLI summary and successful-skill reporting changes, with corresponding resources, translations, test fakes, and output snapshots. No new public library API or execution mechanism.

Regression?

Unknown — the source PR does not identify a specific regressing release or commit.

`aspire agent init` shows a generic installation-location preview that
can be mistaken for plugin configuration. Its result summary omits
configured source URLs and does not show where Playwright skills are
installed.

This PR separates configured remote sources from installed local skills:

- Show repository URLs and the actual OpenCode catalogs, including
retained version pins, alongside configuration locations.
- Include successfully installed Playwright skills and already-current
static skills in the installed-skills summary.
- Group locations with their supported agents, separate result sections
with blank lines, and dim the shared-location notice.

The excerpts below show project-scoped setup with GitHub Copilot, Claude
Code, and OpenCode selected, installing Aspire configuration and
Playwright CLI.

### Before

```text
Installation locations:
  Skills: .agents/skills (shared: GitHub Copilot, OpenCode)
  Skills: .claude/skills
Shared files may be discovered by agents that aren't selected.
🤖 Configured Aspire plugin:
     GitHub Copilot: .github/copilot/settings.json
     Claude Code: .claude/settings.json
     OpenCode: opencode.jsonc
✅ Installed Playwright CLI.
✅ Agent environment configuration complete.
```

### After

```text
🤖 Configured sources:
     Sources: https://github.com/microsoft/aspire-skills, https://raw.githubusercontent.com/microsoft/aspire-skills/main/opencode/v1/
     Locations: .github/copilot/settings.json (GitHub Copilot), .claude/settings.json (Claude Code), opencode.jsonc (OpenCode)

✅ Installed Playwright CLI.

🤖 Installed skills:
     Skills: playwright-cli
     Locations: .agents/skills (GitHub Copilot, OpenCode), .claude/skills (Claude Code)
     Shared files may be discovered by agents that aren't selected.

✅ Agent environment configuration complete.
```

The shared-location notice is dim in the terminal; the text block does
not show that styling.

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: a47a61ad-c59b-4674-8e74-e493bff49b02

(cherry picked from commit 2fefac5)
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant