Skip to content

make _wrappedConfiguration into member variable - #1292

Closed
gietal-msft wants to merge 1 commit into
mainfrom
gietal/odw_config_fix_get_copy
Closed

gietal-msft wants to merge 1 commit into
mainfrom
gietal/odw_config_fix_get_copy

Conversation

@gietal-msft

Copy link
Copy Markdown

PROBLEM:
_wrappedConfiguration is a global variable which causes ODWLogConfiguration.getCopy() to return objects with a shared underlying ILogConfiguration instead of unique copies.
 
SOLUTION:
I believe _wrappedConfiguration was intended to be member variable of the ODWLogConfiguration, so patching it as such.

@gietal-msft
gietal-msft requested a review from a team as a code owner July 16, 2024 17:40
@lalitb

Copy link
Copy Markdown
Contributor

absaroj Can you help review this?

@bmehta001

Copy link
Copy Markdown
Contributor

I opened #1539 as a follow-up to this fix. It makes the wrapped configuration instance-owned, includes ownership of the copied C++ configuration, and adds an XCTest for independent copies. Leaving this PR open for its author/maintainers to close or merge as appropriate.

@bmehta001

Copy link
Copy Markdown
Contributor

Update: the fix from #1539 passed its iOS XCTest matrix and is now included in #1529. #1539 is being closed as a duplicate branch; please track #1529 for the merged copy-isolation and ownership change.

@bmehta001 bmehta001 closed this Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants