Conversation
Move the wrapped configuration from file scope to a per-instance owning pointer, preventing later copies from redirecting earlier wrappers and leaking prior allocations. Files: wrappers/obj-c/ODWLogConfiguration.mm, wrappers/obj-c/ODWLogConfiguration_private.h, tests/unittests/obj-c/ODWLogConfigurationTests.mm Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a668528d-5dc9-4648-a753-95c0235cc103
Check presence through HasConfig rather than converting an unset Variant to a string; this preserves the regression assertion without crashing debug iOS tests. Files: tests/unittests/obj-c/ODWLogConfigurationTests.mm Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a668528d-5dc9-4648-a753-95c0235cc103
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ODWLogConfigurationcopy its own wrapped configuration instead of sharing the file-scope pointer.Supersedes the fix proposed in #1292 with ownership and regression coverage.
Validation
git diff --checkpassed.